Page MenuHomePhabricator

[web] cleanup thread settings general + privacy tabs
ClosedPublic

Authored by ginsu on Feb 12 2024, 2:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 31, 7:26 AM
Unknown Object (File)
Oct 3 2024, 3:03 PM
Unknown Object (File)
Oct 3 2024, 3:03 PM
Unknown Object (File)
Oct 3 2024, 3:03 PM
Unknown Object (File)
Oct 3 2024, 3:03 PM
Unknown Object (File)
Oct 3 2024, 3:02 PM
Unknown Object (File)
Sep 14 2024, 9:55 PM
Unknown Object (File)
Aug 25 2024, 1:34 PM
Subscribers

Details

Summary

This diff cleans up the general + privacy tabs in the thread settings modal to follow the conventions of the new modal api. Since both the general + privacy tabs had very similar logic for their save button, to cleanup these tabs I introduced a new ThreadSettingsSaveButton which factored out all the shared logic of the save button and passed this new save button component as the primaryButton for these two components

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D11033

Test Plan

Please see the demo videos below

privacy tab:

general tab:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added inline comments.
web/modals/threads/settings/thread-settings-modal.react.js
60 ↗(On Diff #36987)

The very next diff in this stack will address and fix this

ginsu requested review of this revision.Feb 12 2024, 2:17 AM

Didn't read too carefully. Can you make sure removing form doesn't affect functionality?

This revision is now accepted and ready to land.Feb 12 2024, 1:05 PM

Can you make sure removing form doesn't affect functionality?

Test plan should confirm that there are no regressions with functionality