Page MenuHomePhorge
Feed Search

Dec 18 2023

ginsu requested review of D10393: [web] show unreads for each community in the community list.
Dec 18 2023, 11:04 PM
ginsu requested review of D10391: [web] show total unreads in the navigation sidebar home button.
Dec 18 2023, 10:51 PM
ginsu requested review of D10390: [web] introduce unread badge component.
Dec 18 2023, 9:39 PM

Dec 16 2023

ginsu attached a referenced file: F956012: Screenshot 2023-12-15 at 8.50.30 PM.png.
Dec 16 2023, 1:51 AM
ginsu attached a referenced file: F956006: Screenshot 2023-12-15 at 8.49.47 PM.png.
Dec 16 2023, 1:51 AM
ginsu added inline comments to D10359: [web] introduce community list item component.
Dec 16 2023, 1:51 AM

Dec 15 2023

ginsu requested review of D10364: [web] introduce navigation sidebar.
Dec 15 2023, 10:23 PM
ginsu requested review of D10363: [web] introduce community creation button for navigation sidebar.

will make sure ci passes before landing

Dec 15 2023, 10:09 PM
ginsu requested review of D10361: [web] introduce navigation sidebar home button.

will make sure ci passes before landing

Dec 15 2023, 10:02 PM
ginsu requested review of D10362: [web] introduce account settings button for navigation sidebar.
Dec 15 2023, 9:59 PM
ginsu requested review of D10359: [web] introduce community list item component.

will make sure ci passes before landing

Dec 15 2023, 9:39 PM
ginsu requested review of D10358: [web] introduce useNavigationSidebarTooltip hook.
Dec 15 2023, 9:25 PM
ginsu updated the summary of D10360: [web] introduce community list.
Dec 15 2023, 9:10 PM
ginsu requested review of D10357: [web] introduce calculateNavigationSidebarTooltipSize.
Dec 15 2023, 9:07 PM
ginsu requested review of D10360: [web] introduce community list.

will make sure ci passes before landing

Dec 15 2023, 9:05 PM
ginsu resigned from D10341: [emscripten] Switch Emscripten CI job to autoscaling runners.
Dec 15 2023, 8:27 PM
ginsu closed D10350: [web] introduce navigation sidebar tooltip.
Dec 15 2023, 8:27 PM
ginsu committed rCOMMb05240f9727a: [web] introduce navigation sidebar tooltip.
Dec 15 2023, 8:27 PM
ginsu closed D10349: [lib/native/web] convert appendSuffix to useAppendCommunitySuffix.
Dec 15 2023, 8:27 PM
ginsu committed rCOMM6a7b128d9d25: [lib/native/web] convert appendSuffix to useAppendCommunitySuffix.
Dec 15 2023, 8:27 PM
ginsu updated the diff for D10350: [web] introduce navigation sidebar tooltip.

rebase before landing

Dec 15 2023, 8:24 PM
ginsu updated the diff for D10349: [lib/native/web] convert appendSuffix to useAppendCommunitySuffix.

rebase before landing

Dec 15 2023, 8:24 PM
ginsu added inline comments to D10350: [web] introduce navigation sidebar tooltip.
Dec 15 2023, 8:21 PM
ginsu requested review of D10350: [web] introduce navigation sidebar tooltip.
Dec 15 2023, 9:49 AM
ginsu requested review of D10348: [web] fixup pinned message modal.
Dec 15 2023, 9:34 AM
ginsu requested review of D10349: [lib/native/web] convert appendSuffix to useAppendCommunitySuffix.
Dec 15 2023, 9:33 AM
ginsu requested review of D10346: [lib/web/native] rename toggle pin utils to be message pinning utils.
Dec 15 2023, 9:08 AM
ginsu requested review of D10347: [lib/native/web] introduce pinnedMessageCountText function.

will make sure ci passes before landing

Dec 15 2023, 8:43 AM
ginsu requested review of D10345: [web] rename message results modal to be pinned messages modal.
Dec 15 2023, 8:40 AM
ginsu requested review of D10344: [web] cleanup message results modal.
Dec 15 2023, 8:29 AM

Dec 14 2023

ginsu accepted D10332: [lib][web][native] Stop logging out from the Socket.
Dec 14 2023, 5:43 PM
ginsu accepted D10331: [lib] Call logout when connectionIssue is set.
Dec 14 2023, 5:40 PM
ginsu accepted D10288: [lib] Add setConnectionIssueActionType.

please make sure to address @ashoat's comment before landing

Dec 14 2023, 5:32 PM
ginsu accepted D10287: [lib] Add connectionIssue field.
Dec 14 2023, 5:30 PM
ginsu accepted D10229: [lib] Convert getPotentialMemberItems into a hook.

thanks for addressing my feedback @rohan

Dec 14 2023, 5:21 AM

Dec 12 2023

ginsu published D10324: [web] cleanup thread settings media gallery modal for review.
Dec 12 2023, 10:58 PM
ginsu requested review of D10323: [web] cleanup sidebars modal.

will make sure ci passes before landing

Dec 12 2023, 10:44 PM
ginsu requested review of D10322: [web] cleanup subchannels modal.

will make sure ci passes before landing

Dec 12 2023, 10:42 PM
ginsu requested review of D10321: [web] clean up thread picker modal.
Dec 12 2023, 10:37 PM
ginsu requested review of D10320: [web] remove margin from search component.

will make sure ci passes before landing

Dec 12 2023, 10:33 PM
ginsu requested review of D10319: [web] cleanup emoji avatar selection modal.
Dec 12 2023, 9:58 PM
ginsu requested review of D10318: [web] update account delete modal to use camelcase.
Dec 12 2023, 9:41 PM
ginsu added a comment to D10317: [web] cleanup account delete modal.

Also just a personal opinion on the design of the modal (I know you didn't introduce the change in this diff so no changes are needed here), but I think the little ! circle icon would look better inline with the text, either in its own column side-by-side to the text, or just next to the first line of text. Not a big deal though, just wanted to call it out

Dec 12 2023, 9:35 PM
ginsu requested review of D10315: [web] cleanup thread notifications modal.

will make sure ci passes before landing

Dec 12 2023, 9:23 PM
ginsu requested review of D10317: [web] cleanup account delete modal.
Dec 12 2023, 9:19 PM
ginsu requested review of D10316: [web] cleanup message search modal.
Dec 12 2023, 9:19 PM
ginsu closed D9673: [lib] correctly skip using established socket when urlPrefix is overriden.
Dec 12 2023, 11:20 AM
ginsu committed rCOMM38896494b582: [lib] correctly skip using established socket when urlPrefix is overriden.
Dec 12 2023, 11:20 AM
ginsu planned changes to D10208: [web] fix stretched encrypted images.

Are you sure you throttled this enough? And cleared local cache before?

Dec 12 2023, 10:29 AM
ginsu updated the diff for D9673: [lib] correctly skip using established socket when urlPrefix is overriden.

rebase before landing

Dec 12 2023, 9:46 AM
ginsu updated the diff for D10266: [web] introduce secondary button prop to modal component.

address comments

Dec 12 2023, 9:43 AM

Dec 11 2023

ginsu resigned from D10231: [lib/web/native] Introduce hook that constructs a resolved user search index and update usePotentialMemberItems.

code looks good and thanks for creating all the demo videos! going to resign just so someone else can take a look too

Dec 11 2023, 8:52 PM
ginsu accepted D10259: [lib/native] Show resolved ENS name in user profile.

thank you so much for doing this!!

Dec 11 2023, 7:51 PM
ginsu requested changes to D10229: [lib] Convert getPotentialMemberItems into a hook.

putting this back in your queue

Dec 11 2023, 7:47 PM
ginsu added inline comments to D10229: [lib] Convert getPotentialMemberItems into a hook.
Dec 11 2023, 7:45 PM

Dec 8 2023

ginsu requested review of D10282: [web] cleanup thread notifications modal rendering logic.
Dec 8 2023, 10:18 PM
ginsu requested review of D10279: [web] cleanup confirm leave thread modal.
Dec 8 2023, 9:57 PM
ginsu attached a referenced file: F920827: Screenshot 2023-12-08 at 4.24.26 PM.png.
Dec 8 2023, 9:25 PM
ginsu updated the test plan for D10276: [web] cleanup sidebar promote modal.
Dec 8 2023, 9:25 PM
ginsu updated the diff for D10276: [web] cleanup sidebar promote modal.

add double quotes

Dec 8 2023, 9:23 PM
ginsu requested review of D10276: [web] cleanup sidebar promote modal.
Dec 8 2023, 9:15 PM
ginsu requested review of D10273: [web] cleanup message reactions modal.
Dec 8 2023, 8:58 PM
ginsu requested review of D10269: [web] cleanup toggle pin modal.

will make sure ci passes before landing

Dec 8 2023, 8:41 PM
ginsu requested review of D10267: [web] cleanup push notif modal.
Dec 8 2023, 8:10 PM
ginsu requested review of D10266: [web] introduce secondary button prop to modal component.
Dec 8 2023, 8:05 PM
ginsu accepted D10243: [lib] Update `lib/types` to accomodate `RawThreadInfos`.
Dec 8 2023, 7:51 PM
ginsu accepted D10268: [lib] Replace `LegacyRawThreadInfos` with `RawThreadInfos` where simple in `shared/updates`.
Dec 8 2023, 7:51 PM

Dec 7 2023

ginsu requested review of D10242: [web] update password change modal css to use camalcase.
Dec 7 2023, 11:38 PM
ginsu requested review of D10241: [web] cleanup apps modal.
Dec 7 2023, 11:19 PM
ginsu requested review of D10240: [web] cleanup view invite link modal.
Dec 7 2023, 11:02 PM
ginsu requested changes to D10229: [lib] Convert getPotentialMemberItems into a hook.
Dec 7 2023, 11:01 PM
ginsu requested review of D10239: [web] cleanup manage invite links existing link modal.
Dec 7 2023, 10:51 PM
ginsu requested review of D10238: [web] cleanup manage invite links empty link modal.
Dec 7 2023, 10:34 PM
ginsu added a comment to D10232: [web] cleanup password change modal.

Does it make sense to define the error placeholder in the Modal component directly as an optional prop if we're going to need it in multiple places? Just an idea to enforce consistency

Dec 7 2023, 10:10 PM
ginsu added inline comments to D10232: [web] cleanup password change modal.
Dec 7 2023, 10:05 PM
ginsu added a comment to D10234: [web] introduce subheader prop to modal component.

will make sure that ci passes before landing

Dec 7 2023, 10:03 PM
ginsu requested review of D10234: [web] introduce subheader prop to modal component.
Dec 7 2023, 10:03 PM
ginsu requested review of D10237: [web] match the veritcal padding for modals with no button containers.
Dec 7 2023, 9:51 PM
ginsu requested review of D10236: [web] cleanup community creation modal.
Dec 7 2023, 9:27 PM
ginsu requested review of D10232: [web] cleanup password change modal.
Dec 7 2023, 8:45 PM
ginsu requested review of D10230: [web] cleanup community roles modal.
Dec 7 2023, 8:32 PM
ginsu added a comment to D10229: [lib] Convert getPotentialMemberItems into a hook.

About to go to lunch and will give a more quality review later, but just saw the blockedRelationshipsStatuses set and I think there maybe some code that you can reuse.

Dec 7 2023, 8:09 PM
ginsu requested review of D10228: [web] introduce new redesigned modal component.
Dec 7 2023, 7:33 PM
ginsu requested review of D9673: [lib] correctly skip using established socket when urlPrefix is overriden.

rerequesting review as a sanity check for my earlier confusion

Dec 7 2023, 12:22 AM

Dec 6 2023

ginsu updated the summary of D9673: [lib] correctly skip using established socket when urlPrefix is overriden.
Dec 6 2023, 11:18 PM
ginsu updated the diff for D9673: [lib] correctly skip using established socket when urlPrefix is overriden.

update

Dec 6 2023, 11:09 PM
ginsu planned changes to D9673: [lib] correctly skip using established socket when urlPrefix is overriden.
Dec 6 2023, 8:55 PM
ginsu reclaimed D9673: [lib] correctly skip using established socket when urlPrefix is overriden.
Dec 6 2023, 8:50 PM
ginsu attached a referenced file: F914552: Screen Recording 2023-12-05 at 4.33.56 PM.mov.
Dec 6 2023, 8:15 PM
ginsu attached a referenced file: F914548: Screen Recording 2023-12-05 at 4.35.46 PM.mov.
Dec 6 2023, 8:15 PM
ginsu updated the summary of D10208: [web] fix stretched encrypted images.
Dec 6 2023, 8:15 PM
ginsu requested review of D10208: [web] fix stretched encrypted images.
Dec 6 2023, 8:01 PM
ginsu closed D10149: [web] introduce light mode to app directory modal.
Dec 6 2023, 6:52 PM
ginsu committed rCOMM91f746899548: [web] introduce light mode to app directory modal.
Dec 6 2023, 6:52 PM
ginsu closed D10146: [web] introduce light to delete role modal.
Dec 6 2023, 6:52 PM
ginsu committed rCOMM30b93384e9d0: [web] introduce light to delete role modal.
Dec 6 2023, 6:52 PM
ginsu closed D10145: [web] introduce light mode to create/edit role modal.
Dec 6 2023, 6:52 PM
ginsu committed rCOMMc0c4171aedb5: [web] introduce light mode to create/edit role modal.
Dec 6 2023, 6:52 PM
ginsu closed D10144: [web] introduce light mode to community creation modal.
Dec 6 2023, 6:52 PM
ginsu committed rCOMM1fac16dbc45a: [web] introduce light mode to community creation modal.
Dec 6 2023, 6:52 PM