will make sure ci passes before landing
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Dec 18 2023
Dec 16 2023
Dec 15 2023
will make sure ci passes before landing
will make sure ci passes before landing
will make sure ci passes before landing
rebase before landing
rebase before landing
will make sure ci passes before landing
Dec 14 2023
please make sure to address @ashoat's comment before landing
thanks for addressing my feedback @rohan
Dec 12 2023
will make sure ci passes before landing
will make sure ci passes before landing
will make sure ci passes before landing
Also just a personal opinion on the design of the modal (I know you didn't introduce the change in this diff so no changes are needed here), but I think the little ! circle icon would look better inline with the text, either in its own column side-by-side to the text, or just next to the first line of text. Not a big deal though, just wanted to call it out
will make sure ci passes before landing
Are you sure you throttled this enough? And cleared local cache before?
rebase before landing
address comments
Dec 11 2023
code looks good and thanks for creating all the demo videos! going to resign just so someone else can take a look too
thank you so much for doing this!!
putting this back in your queue
Dec 8 2023
add double quotes
will make sure ci passes before landing
Dec 7 2023
Does it make sense to define the error placeholder in the Modal component directly as an optional prop if we're going to need it in multiple places? Just an idea to enforce consistency
will make sure that ci passes before landing
About to go to lunch and will give a more quality review later, but just saw the blockedRelationshipsStatuses set and I think there maybe some code that you can reuse.
rerequesting review as a sanity check for my earlier confusion
Dec 6 2023
update