Page MenuHomePhabricator
Feed Advanced Search

Mar 11 2024

atul abandoned D11288: [lib] Remove `threadOrParentThreadHasAdminRole` check from `threadIsWithBlockedUserOnly`.
Mar 11 2024, 2:11 PM
atul requested review of D11289: [lib] Delete `memberHasAdminPowers`.
Mar 11 2024, 1:36 AM
atul requested review of D11288: [lib] Remove `threadOrParentThreadHasAdminRole` check from `threadIsWithBlockedUserOnly`.
Mar 11 2024, 1:22 AM

Mar 10 2024

atul requested review of D11286: [lib] Introduce `persistedRoleInfoValidator` and use in `convertClientDBThreadInfoToRawThreadInfo`.
Mar 10 2024, 1:08 PM

Mar 7 2024

atul published D11276: [lib] Remove usage of `memberHasAdminPowers` in `useThreadSearchIndex` for review.
Mar 7 2024, 9:33 AM
atul closed D11262: [CommCoreModule] Add `#include <functional>` to `NotificationsCryptoModule`.
Mar 7 2024, 8:37 AM
atul committed rCOMM5da845a3943d: [CommCoreModule] Add `#include <functional>` to `NotificationsCryptoModule` (authored by atul).
[CommCoreModule] Add `#include <functional>` to `NotificationsCryptoModule`
Mar 7 2024, 8:37 AM
atul updated the diff for D11262: [CommCoreModule] Add `#include <functional>` to `NotificationsCryptoModule`.

rebase and alnd

Mar 7 2024, 8:35 AM

Mar 6 2024

atul requested review of D11263: [lib] Remove usage of `memberHasAdminPowers` in `useKeyserverAdmin`.
Mar 6 2024, 3:32 PM
atul requested review of D11261: [lib] Omit `isDefault` field in `rawThreadInfoFromServerThreadInfo`.
Mar 6 2024, 2:26 PM

Mar 5 2024

atul requested review of D11254: [lib] Remove `isDefault` field from `RoleInfo` in `patchRoleInfoWithSpecialRole`.
Mar 5 2024, 10:00 PM
atul requested review of D11253: [lib] Remove `isDefault` field from `RoleInfo`.
Mar 5 2024, 9:52 PM
atul requested review of D11252: [lib] Make `specialRoles` field of `RoleInfo` required.
Mar 5 2024, 9:51 PM
atul requested review of D11248: [lib] Constrain dep list of `useRoleMemberCountsForCommunity` and `useRoleUserSurfacedPermissions`.
Mar 5 2024, 2:37 PM
atul requested review of D11209: [lib] Update `threadHasAdminRole` to consider `specialField`.

However, if there is no specialRole field encountered, we will assume we're dealing with a Server/"legacy" type and fallback to sketchy string search.

What is the scenario when this can happen?

Mar 5 2024, 2:35 PM
atul updated the diff for D11205: [lib][native] Introduce `useRoleNamesToSpecialRole` to remove `"Admins"` string check in `RolePanelEntry`.

memoize useRoleNamesToSpecialRole

Mar 5 2024, 2:17 PM
atul added inline comments to D11205: [lib][native] Introduce `useRoleNamesToSpecialRole` to remove `"Admins"` string check in `RolePanelEntry`.
Mar 5 2024, 2:12 PM
atul added inline comments to D11205: [lib][native] Introduce `useRoleNamesToSpecialRole` to remove `"Admins"` string check in `RolePanelEntry`.
Mar 5 2024, 2:08 PM
atul removed a reviewer for D11188: [web] Redux migration to patch in `specialRole` field: ginsu.

Removing Ginsu as reviewer since he's OOO and feedback was addressed.

Mar 5 2024, 1:13 PM
atul added a comment to D11243: [CI] Clean on failure for Emscripten pipeline.

Will run on the MacBook Air (where it was previously failing) here: https://phab.comm.dev/D11245

Mar 5 2024, 8:23 AM

Mar 1 2024

atul published D11209: [lib] Update `threadHasAdminRole` to consider `specialField` for review.
Mar 1 2024, 1:19 PM
atul requested review of D11208: [lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is[Editable/Deletable]` directly in `RoleActionsMenu`.
Mar 1 2024, 1:13 PM
atul requested review of D11206: [web] Compute `existingRole` instead of `existingRoleID` in `RoleActionsMenu`.
Mar 1 2024, 12:35 PM
atul published D11205: [lib][native] Introduce `useRoleNamesToSpecialRole` to remove `"Admins"` string check in `RolePanelEntry` for review.
Mar 1 2024, 12:06 PM
atul updated the summary of D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.
Mar 1 2024, 11:42 AM
atul requested review of D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.
Mar 1 2024, 11:06 AM

Feb 29 2024

atul closed D11202: [GH Actions] Move Android CI workflows to `macOS`.
Feb 29 2024, 3:22 PM
atul committed rCOMMff7b0bf442fe: [GH Actions] Move Android CI workflows to `macOS` (authored by atul).
[GH Actions] Move Android CI workflows to `macOS`
Feb 29 2024, 3:22 PM
atul updated the diff for D11202: [GH Actions] Move Android CI workflows to `macOS`.

setting JAVA_HOME before command worked, using the env approach with ANDROID_SIGNING_PASSWORD didn't.

Feb 29 2024, 3:21 PM
atul updated the diff for D11202: [GH Actions] Move Android CI workflows to `macOS`.

bring back mkdir w/ -p flag

Feb 29 2024, 3:04 PM
atul accepted D11166: [lib] introduce community reducer.
Feb 29 2024, 3:00 PM
atul updated the test plan for D11202: [GH Actions] Move Android CI workflows to `macOS`.
Feb 29 2024, 2:59 PM
atul updated the test plan for D11202: [GH Actions] Move Android CI workflows to `macOS`.
Feb 29 2024, 2:57 PM
atul published D11202: [GH Actions] Move Android CI workflows to `macOS` for review.
Feb 29 2024, 2:56 PM
atul added a comment to D10967: [CI] Use M1 runners for macOS-based GH Actions workflows.

Forgot this was landed, looks like it brought iOS build times down to ~13-14min from ~50min

Feb 29 2024, 12:48 PM

Feb 28 2024

atul requested review of D11188: [web] Redux migration to patch in `specialRole` field.

Version will be bumped in "flip the switch" diff. native, web, and keyserver all need to be updated at the same time as a release.

Feb 28 2024, 3:07 PM

Feb 27 2024

atul accepted D11183: [lib] Compare only entities from one keyserver when checking the inconsistencies.
Feb 27 2024, 1:19 PM
atul accepted D11182: [lib] Add keyserverID to processServerRequestsActionType.
Feb 27 2024, 1:17 PM
atul accepted D11181: [lib] Use keyserverID when generating initial message using socket.
Feb 27 2024, 1:16 PM
atul updated the test plan for D11188: [web] Redux migration to patch in `specialRole` field.
Feb 27 2024, 12:28 PM
atul requested review of D11188: [web] Redux migration to patch in `specialRole` field.
Feb 27 2024, 12:24 PM
atul updated the diff for D11099: [native] Redux migration to patch in `specialRole` field.

update

Feb 27 2024, 11:29 AM
atul added inline comments to D11099: [native] Redux migration to patch in `specialRole` field.
Feb 27 2024, 10:32 AM
atul closed D11149: [lib] Update `roleIsDefaultRole` to consider `roleInfo?.specialRole`.
Feb 27 2024, 9:55 AM
atul committed rCOMM97d75c7931c6: [lib] Update `roleIsDefaultRole` to consider `roleInfo?.specialRole` (authored by atul).
[lib] Update `roleIsDefaultRole` to consider `roleInfo?.specialRole`
Feb 27 2024, 9:55 AM
atul closed D11148: [lib] Update `roleIsAdminRole` to consider `roleInfo?.specialRole`.
Feb 27 2024, 9:55 AM
atul committed rCOMMc05d8f18fefe: [lib] Update `roleIsAdminRole` to consider `roleInfo?.specialRole` (authored by atul).
[lib] Update `roleIsAdminRole` to consider `roleInfo?.specialRole`
Feb 27 2024, 9:55 AM
atul updated the diff for D11149: [lib] Update `roleIsDefaultRole` to consider `roleInfo?.specialRole`.

rebase and land

Feb 27 2024, 9:28 AM

Feb 26 2024

atul accepted D11177: [lib][keyserver] Delete MORE_ONE_TIME_KEYS mechanism.

Looks good, just want to make sure that this won't break any older clients? I see the following in Test Plan:

Feb 26 2024, 2:21 PM
atul accepted D11176: [lib] Add keyserverID param to getClientResponsesSelector.
Feb 26 2024, 2:19 PM
atul accepted D11167: [lib] populate community store on user login.

Looks good

Feb 26 2024, 2:19 PM
atul resigned from D11164: [sqlite] implement processing community store ops on worker.

I don't have any experience with web workers, will defer to other reviewers

Feb 26 2024, 2:16 PM
atul requested changes to D11166: [lib] introduce community reducer.

Mostly looks good, but do we need to handle clearing the data on log out/delete account/etc?

Feb 26 2024, 2:13 PM
atul accepted D11165: [lib] introduce addCommunityActionType.
Feb 26 2024, 2:12 PM
atul requested changes to D11115: [web] Check backup client wasm integrity buildkite.

Looks like the Emscripten workflow is failing? Sending back to your queue, feel free to re-request review if I'm missing something

Feb 26 2024, 1:58 PM

Feb 23 2024

atul added a comment to D11115: [web] Check backup client wasm integrity buildkite.

Passing two command flags seems weird, can we do like yarn build-db-wasm && yarn build-db-wasm?

Feb 23 2024, 11:35 AM
atul accepted D11156: [CI] Switch Emscripten CI job to mac runners.
Feb 23 2024, 6:38 AM
atul published D11156: [CI] Switch Emscripten CI job to mac runners for review.
Feb 23 2024, 6:38 AM

Feb 22 2024

atul requested review of D11149: [lib] Update `roleIsDefaultRole` to consider `roleInfo?.specialRole`.
Feb 22 2024, 8:14 PM
atul requested review of D11148: [lib] Update `roleIsAdminRole` to consider `roleInfo?.specialRole`.
Feb 22 2024, 8:13 PM
atul retitled D11099: [native] Redux migration to patch in `specialRole` field from [DRAFT][native] Redux migration to patch in `specialRole` field to [native] Redux migration to patch in `specialRole` field.
Feb 22 2024, 7:54 PM
atul added a comment to D11099: [native] Redux migration to patch in `specialRole` field.

What is the downside of making this diff a draft instead of marking its title with a label?

Feb 22 2024, 7:54 PM
atul accepted D10938: [lib] Basic implementation of identity search context provider without message sending.
Feb 22 2024, 7:52 PM
atul closed D10119: [web] Update existing checks on isDefault in role-actions-menu.reactjs.
Feb 22 2024, 7:24 PM
atul committed rCOMM50a22bbfd6f6: [web] Update existing checks on isDefault in role-actions-menu.reactjs (authored by atul).
[web] Update existing checks on isDefault in role-actions-menu.reactjs
Feb 22 2024, 7:24 PM
atul closed D10118: [native] Update existing checks on isDefault in role-panel-entry.react.js.
Feb 22 2024, 7:24 PM
atul committed rCOMM558d73e620ad: [native] Update existing checks on isDefault in role-panel-entry.react.js (authored by atul).
[native] Update existing checks on isDefault in role-panel-entry.react.js
Feb 22 2024, 7:24 PM
atul updated the diff for D10119: [web] Update existing checks on isDefault in role-actions-menu.reactjs.

tmp

Feb 22 2024, 2:09 PM
atul updated the diff for D10118: [native] Update existing checks on isDefault in role-panel-entry.react.js.

update and land

Feb 22 2024, 2:06 PM
atul closed D10116: [lib] Update existing checks on isDefault in thread-utils.js.
Feb 22 2024, 1:58 PM
atul committed rCOMM277f0ba1557f: [lib] Update existing checks on isDefault in thread-utils.js (authored by atul).
[lib] Update existing checks on isDefault in thread-utils.js
Feb 22 2024, 1:58 PM
atul updated the diff for D10116: [lib] Update existing checks on isDefault in thread-utils.js.

update and alnd

Feb 22 2024, 1:34 PM
atul abandoned D10117: [keyserver] Update existing checks on isDefault in invite-link-creator.js.

No longer relevant since we have separate server and client types. In the future we will flip things when we have minimally encoded permissions in memberships table, at which point we can change the logic here.

Feb 22 2024, 11:37 AM

Feb 21 2024

atul accepted D11089: [lib] Make api-request-handler keyserver-specific.
Feb 21 2024, 10:34 PM
atul accepted D11130: [lib] Modify update calendar query so that it can update a subset of keyservers.
Feb 21 2024, 9:35 PM
atul accepted D11131: [lib] Add a keyserverID prop to calendar-query-handler.
Feb 21 2024, 9:26 PM
atul accepted D11133: [lib] Filter out calendar filters that use threads from a different keyserver.
Feb 21 2024, 1:22 PM
atul accepted D11135: [lib] Add a keyserverID to an action payload.
Feb 21 2024, 1:21 PM
atul accepted D11137: [native] Don't overwrite main SQLCipher key when creating logs key.

Looks good. Also looks like we don't need to run yarn build-db-wasm on these changes

Feb 21 2024, 1:04 PM
atul closed D11136: [native] Fix for encrypted media.
Feb 21 2024, 12:52 PM
atul committed rCOMMa3d27f5b40ed: [native] Fix for encrypted media (authored by atul).
[native] Fix for encrypted media
Feb 21 2024, 12:52 PM
atul updated the diff for D11136: [native] Fix for encrypted media.

stage all

Feb 21 2024, 12:01 PM
atul updated the test plan for D11136: [native] Fix for encrypted media.
Feb 21 2024, 11:36 AM
atul published D11136: [native] Fix for encrypted media for review.
Feb 21 2024, 11:35 AM

Feb 20 2024

atul closed D11097: [native] Reintroduce `updateClientDBThreadStoreThreadInfos`.
Feb 20 2024, 12:19 PM
atul committed rCOMMe76b220b6dc2: [native] Reintroduce `updateClientDBThreadStoreThreadInfos` (authored by atul).
[native] Reintroduce `updateClientDBThreadStoreThreadInfos`
Feb 20 2024, 12:19 PM
atul updated the diff for D11097: [native] Reintroduce `updateClientDBThreadStoreThreadInfos`.

land

Feb 20 2024, 12:18 PM
atul attached a referenced file: F1194023: 82faa1.png.
Feb 20 2024, 12:17 PM
atul added a comment to D11097: [native] Reintroduce `updateClientDBThreadStoreThreadInfos`.

Sorry, added annotation showing original code.

Feb 20 2024, 12:17 PM
atul closed D11095: [native] Reintroduce `createUpdateDBOpsForThreadStoreThreadInfos` for new `RawThreadInfo` encoding.
Feb 20 2024, 12:15 PM
atul committed rCOMM1cfcd7f83568: [native] Reintroduce `createUpdateDBOpsForThreadStoreThreadInfos` for new… (authored by atul).
[native] Reintroduce `createUpdateDBOpsForThreadStoreThreadInfos` for new…
Feb 20 2024, 12:15 PM
atul updated the diff for D11095: [native] Reintroduce `createUpdateDBOpsForThreadStoreThreadInfos` for new `RawThreadInfo` encoding.

land

Feb 20 2024, 11:45 AM
atul added inline comments to D11095: [native] Reintroduce `createUpdateDBOpsForThreadStoreThreadInfos` for new `RawThreadInfo` encoding.
Feb 20 2024, 11:44 AM

Feb 15 2024

atul requested review of D11099: [native] Redux migration to patch in `specialRole` field.
Feb 15 2024, 2:06 PM
atul added a reviewer for D11097: [native] Reintroduce `updateClientDBThreadStoreThreadInfos`: michal.
Feb 15 2024, 1:51 PM
atul added a reviewer for D11095: [native] Reintroduce `createUpdateDBOpsForThreadStoreThreadInfos` for new `RawThreadInfo` encoding: michal.
Feb 15 2024, 1:51 PM
atul added a reviewer for D11097: [native] Reintroduce `updateClientDBThreadStoreThreadInfos`: kamil.
Feb 15 2024, 1:51 PM
atul added a reviewer for D11095: [native] Reintroduce `createUpdateDBOpsForThreadStoreThreadInfos` for new `RawThreadInfo` encoding: kamil.
Feb 15 2024, 1:50 PM
atul closed D11057: [native] Deprecate and move `updateClientDBThreadStoreThreadInfos` and `createUpdateDBOpsForThreadStoreThreadInfos`.
Feb 15 2024, 1:42 PM
atul committed rCOMM2b5b72a18455: [native] Deprecate and move `updateClientDBThreadStoreThreadInfos` and… (authored by atul).
[native] Deprecate and move `updateClientDBThreadStoreThreadInfos` and…
Feb 15 2024, 1:42 PM