looks good, skimmed through the tests file (trusting your test plan here), but please see one inline comment
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Sep 29 2023
Sep 29 2023
rohan updated the summary of D9325: [lib] Introduce a canBeSidebarSource function in each message spec.
ginsu added a comment to D9322: [keyserver/lib] Dedup isMessageSidebarSourceReactionEditOrPin into isInvalidSidebarSource.
rohan updated the diff for D9325: [lib] Introduce a canBeSidebarSource function in each message spec.
Get rid of redundant logic
rebase before landing
rebase before landing
rebase before landing
rebase before landing
rohan requested review of D9331: [lib] Move test messages outside of the describe scope to reuse them.
rohan updated the diff for D9322: [keyserver/lib] Dedup isMessageSidebarSourceReactionEditOrPin into isInvalidSidebarSource.
Use messageTypes constant
bartek added inline comments to D9316: [Tunnelbroker] always persist WebSocket messages in database.
rohan updated the diff for D9325: [lib] Introduce a canBeSidebarSource function in each message spec.
Update describe statement in unit tests
Thanks
Setting as "plan changes" so it's not landed by mistake
Rebase
Restricted Repository Identity closed D9266: [lib/keyserver] Make Info generic mandatory in state sync specs.
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMb36d473e7c24: [lib/keyserver] Make Info generic mandatory in state sync specs.
Restricted Repository Identity closed D9253: [lib/keyserver] Improve state sync types.
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM9c57379d7a7e: [lib/keyserver] Improve state sync types.
In D9313#274083, @bartek wrote:Did you think of expected behavior in case of failure?
This should probably be error! instead of debug! right?
michal added inline comments to D9316: [Tunnelbroker] always persist WebSocket messages in database.
kamil published D9320: [lib] don't dispatch policy acknowledgment action when user is not logged in for review.
bartek added inline comments to D9316: [Tunnelbroker] always persist WebSocket messages in database.
Did you think of expected behavior in case of failure?
Current code aborts publishing a message to RabbitMQ if DDB persistence fails. Is that expected?
Thanks for addressing feedback!
Sep 28 2023
Sep 28 2023
rohan requested review of D9325: [lib] Introduce a canBeSidebarSource function in each message spec.
rohan requested review of D9324: [lib] Update types for SIDEBAR_SOURCE messages to reflect isInvalidSidebarSource.
I'll rerun CI when it's back up, requesting review in the meantime
rohan requested review of D9323: [keyserver/lib] Move isInvalidSidebarSource from message-utils to message-types.
I'll rerun CI when it's back up, requesting review in the meantime
rohan requested review of D9322: [keyserver/lib] Dedup isMessageSidebarSourceReactionEditOrPin into isInvalidSidebarSource.
I'll rerun CI when it's back up, requesting review in the meantime
fix merge conflict after merging master
Spacing out hashes calculations on web page load and login/register.
kamil published D9312: [Commtest] add mock olm accounts, configure creating authenticated device for review.
kamil published D9310: [Commtest] extract code to create a socket session with Tunnelbroker for review.