[web] convert pendingUsersToAdd into a map
ClosedPublic
Actions

Authored by ginsu on Jan 25 2024, 11:40 AM.

Details

Reviewers

atul
inka

Commits

rCOMM83363ea1dcea: [web] convert pendingUsersToAdd into a map

Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

This next part of the stack will introduce the concept of "vip users" (happy to change the name of this just couldn't think of anything better). "vip users" will be selected users that are visually separated from the other users (similar to Linear). For context here is what the selected vip users section should look like:

Screenshot 2024-01-25 at 2.45.02 PM.png (1×1 px, 426 KB)

As I was implementing this I realized that pendingUsersToAdd should actually be a map and not a set. This diff makes that following change

Linear task: https://linear.app/comm/issue/ENG-5960/selected-users-section

Depends on D10747

Test Plan

flow + confirmed that there were no regressions to the add users experience

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 25 2024, 11:40 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 25 2024, 11:40 AM

ginsu edited the summary of this revision. (Show Details)Jan 25 2024, 11:46 AM

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D10747: [web] update add user list header based on if searching users.

Harbormaster completed remote builds in B26162: Diff 36139.Jan 25 2024, 11:59 AM

ginsu requested review of this revision.Jan 25 2024, 11:59 AM

ginsu added a child revision: D10820: [web] introduce previouslySelectedUsers map to add users list.Jan 25 2024, 12:13 PM

ginsu edited the summary of this revision. (Show Details)Jan 25 2024, 12:37 PM

ginsu mentioned this in D10820: [web] introduce previouslySelectedUsers map to add users list.Jan 25 2024, 1:13 PM

Looks good. From a naming standpoint, I think I'd prefer something like previouslySelectedUsers or something along those lines.

(I like the "VIP" naming and think it makes sense when you're looking at the UI and see the users appear above the separator, but think the meaning can be confusing when you're reading the code.)

This revision is now accepted and ready to land.Jan 29 2024, 7:28 PM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 15 2024, 1:19 AM

Closed by commit rCOMM83363ea1dcea: [web] convert pendingUsersToAdd into a map (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM83363ea1dcea: [web] convert pendingUsersToAdd into a map.

Harbormaster completed remote builds in B26887: Diff 37178.Feb 15 2024, 1:36 AM