Page MenuHomePhabricator

[web] reintroduce error message to thread settings modal
ClosedPublic

Authored by ginsu on Feb 12 2024, 2:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 8:28 AM
Unknown Object (File)
Sat, Nov 2, 8:37 AM
Unknown Object (File)
Thu, Oct 31, 7:26 AM
Unknown Object (File)
Oct 3 2024, 3:03 PM
Unknown Object (File)
Oct 3 2024, 3:03 PM
Unknown Object (File)
Oct 3 2024, 3:03 PM
Unknown Object (File)
Oct 3 2024, 3:03 PM
Unknown Object (File)
Oct 3 2024, 3:02 PM
Subscribers

Details

Summary

This diff reintroduces the error message for the thread settings modal. Additionally, I deleted the SubmitSection component since this was no longer being used

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D11034

Test Plan

Please see the screenshots below

Screenshot 2024-02-12 at 5.15.16 AM.png (2×3 px, 884 KB)

Screenshot 2024-02-12 at 5.15.12 AM.png (2×3 px, 915 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu requested review of this revision.Feb 12 2024, 2:27 AM
This revision is now accepted and ready to land.Feb 12 2024, 1:06 PM