Page MenuHomePhabricator

[lib] Split thread-types
ClosedPublic

Authored by michal on May 10 2023, 9:49 AM.
Tags
None
Referenced Files
F3368127: D7783.diff
Mon, Nov 25, 6:17 PM
Unknown Object (File)
Sat, Nov 23, 3:18 AM
Unknown Object (File)
Wed, Nov 6, 10:04 PM
Unknown Object (File)
Mon, Oct 28, 8:57 AM
Unknown Object (File)
Oct 21 2024, 3:20 AM
Unknown Object (File)
Oct 9 2024, 12:38 AM
Unknown Object (File)
Oct 8 2024, 3:07 PM
Unknown Object (File)
Sep 28 2024, 3:10 PM
Subscribers

Details

Summary

Splits thread-types.js into two files: thread-permission-types.js and `thread-types-enum.js. It's done for the same reason as when we extracted the message enum - to remove a dependency cycle (that would be otherwise introduced in the next diffs).

There's one small additional change: validators in thread-types-enum.js now have to be explicitly annotated (because they are now imported across files), and this required changing the flow type of tcomb.dict() function to accept string literal unions/enums and not just strings.

Depends on D7749

Test Plan

Run yarn jest-all and yarn flow-all. Check if web and landing work.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Remove unnecessary changes

Accepting to save you rebasing

lib/types/thread-permission-types.js
1 ↗(On Diff #26358)

Add a newline here

This revision is now accepted and ready to land.May 12 2023, 2:12 AM