This diff cleans up the one off styles in the push notif modal and replaces it with styles of the redesigned modal.
Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs
Depends on D10266
Details
Details
- Reviewers
atul rohan kamil - Commits
- rCOMM547e61a52389: [web] cleanup push notif modal
Summary
Test Plan
Please see screenshot below
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 11:49 AM2023-12-08 11:49:06 (UTC-8)
ginsu edited the summary of this revision. (Show Details)Dec 8 2023, 11:53 AM2023-12-08 11:53:49 (UTC-8)
ginsu added a child revision: D10269: [web] cleanup toggle pin modal.Dec 8 2023, 11:55 AM2023-12-08 11:55:57 (UTC-8)
Harbormaster completed remote builds in B24910: Diff 34444.Dec 8 2023, 12:10 PM2023-12-08 12:10:30 (UTC-8)
This revision is now accepted and ready to land.Dec 10 2023, 8:16 AM2023-12-10 08:16:22 (UTC-8)
Harbormaster completed remote builds in B26862: Diff 37138.Feb 15 2024, 12:32 AM2024-02-15 00:32:15 (UTC-8)
Closed by commit rCOMM547e61a52389: [web] cleanup push notif modal (authored by ginsu). · Explain WhyFeb 15 2024, 12:43 AM2024-02-15 00:43:48 (UTC-8)
This revision was automatically updated to reflect the committed changes.