Page MenuHomePhabricator

[web] cleanup toggle pin modal
ClosedPublic

Authored by ginsu on Dec 8 2023, 11:55 AM.
Tags
None
Referenced Files
F3507101: D10269.diff
Fri, Dec 20, 7:21 PM
Unknown Object (File)
Fri, Dec 6, 8:54 PM
Unknown Object (File)
Fri, Dec 6, 6:09 PM
Unknown Object (File)
Nov 18 2024, 12:33 AM
Unknown Object (File)
Oct 31 2024, 10:09 AM
Unknown Object (File)
Oct 3 2024, 6:40 PM
Unknown Object (File)
Oct 3 2024, 6:40 PM
Unknown Object (File)
Oct 3 2024, 6:40 PM
Subscribers

Details

Summary

This diff cleans up the one off styles in the toggle pin modal and replaces it with styles of the redesigned modal.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D10267

Test Plan

Please see screenshot below

Screenshot 2023-12-08 at 2.37.23 PM.png (1×3 px, 961 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 8 2023, 12:35 PM
Harbormaster failed remote builds in B24912: Diff 34446!
ginsu requested review of this revision.Dec 8 2023, 12:41 PM

will make sure ci passes before landing

The new modal looks nice!

This revision is now accepted and ready to land.Dec 10 2023, 8:17 AM
This revision was automatically updated to reflect the committed changes.