Page MenuHomePhabricator

[web] clean up thread picker modal
ClosedPublic

Authored by ginsu on Dec 12 2023, 1:39 PM.
Tags
None
Referenced Files
F3508405: D10321.id34548.diff
Fri, Dec 20, 9:56 PM
F3506964: D10321.diff
Fri, Dec 20, 6:43 PM
Unknown Object (File)
Mon, Dec 16, 4:50 AM
Unknown Object (File)
Fri, Nov 29, 2:09 AM
Unknown Object (File)
Thu, Nov 28, 11:07 PM
Unknown Object (File)
Thu, Nov 28, 10:15 PM
Unknown Object (File)
Thu, Nov 28, 12:05 PM
Unknown Object (File)
Nov 17 2024, 10:30 PM
Subscribers

Details

Summary

This diff cleans up the one off styles in the thread picker modal and replaces it with styles of the redesigned modal.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D10320

Test Plan

Please see the screenshots below

default:

Screenshot 2023-12-12 at 4.40.30 PM.png (1×3 px, 820 KB)

hover:

Screenshot 2023-12-12 at 4.40.20 PM.png (1×3 px, 821 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu requested review of this revision.Dec 12 2023, 2:37 PM
This revision is now accepted and ready to land.Dec 14 2023, 9:55 AM
This revision was landed with ongoing or failed builds.Feb 15 2024, 12:44 AM
This revision was automatically updated to reflect the committed changes.