Page MenuHomePhabricator
Differential D10323

[web] cleanup sidebars modal
ClosedPublic
Actions

Authored by ginsu on Dec 12 2023, 2:40 PM.
Tags
None
Referenced Files
F3586634: D10323.diff
Sun, Dec 29, 11:26 PM
Unknown Object (File)
Fri, Dec 20, 10:16 PM
Unknown Object (File)
Fri, Dec 20, 8:56 PM
Unknown Object (File)
Sun, Dec 15, 3:57 AM
Unknown Object (File)
Sat, Dec 7, 6:20 PM
Unknown Object (File)
Nov 25 2024, 5:55 AM
Unknown Object (File)
Nov 21 2024, 4:22 AM
Unknown Object (File)
Nov 7 2024, 6:11 PM
View All 73 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMMdb7b569823a5: [web] cleanup sidebars modal
Summary

This diff cleans up the one off styles in the sidebars modal and replaces it with styles of the redesigned modal.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D10322

Test Plan

Please see screenshot below

Screenshot 2023-12-12 at 5.43.43 PM.png (1×3 px, 858 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 12 2023, 2:40 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 12 2023, 2:40 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 12 2023, 2:43 PM
Harbormaster failed remote builds in B25010: Diff 34551!
ginsu requested review of this revision.Dec 12 2023, 2:44 PM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10322: [web] cleanup subchannels modal.
ginsu attached a referenced file: F931860: Screenshot 2023-12-12 at 5.43.43 PM.png. (Show Details)

will make sure ci passes before landing

ginsu added a child revision: D10324: [web] cleanup thread settings media gallery modal.Dec 12 2023, 2:53 PM
rohan accepted this revision.Dec 14 2023, 11:43 AM
This revision is now accepted and ready to land.Dec 14 2023, 11:43 AM
ginsu updated this revision to Diff 37152.Feb 15 2024, 12:40 AM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 15 2024, 12:44 AM
Closed by commit rCOMMdb7b569823a5: [web] cleanup sidebars modal (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMdb7b569823a5: [web] cleanup sidebars modal.
Harbormaster completed remote builds in B26876: Diff 37152.Feb 15 2024, 1:07 AM

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
sidebars/
3 lines
2 lines

Diff 34551

View Options

web/modals/threads/sidebars/sidebars-modal.css

Loading...
View Options

web/modals/threads/sidebars/sidebars-modal.react.js

Loading...