Page MenuHomePhabricator
Differential D10241

[web] cleanup apps modal
ClosedPublic
Actions

Authored by ginsu on Dec 7 2023, 2:23 PM.
Tags
None
Referenced Files
F3507674: D10241.id37123.diff
Fri, Dec 20, 9:29 PM
F3507432: D10241.id37135.diff
Fri, Dec 20, 8:49 PM
Unknown Object (File)
Wed, Dec 18, 9:38 AM
Unknown Object (File)
Sat, Dec 14, 7:54 PM
Unknown Object (File)
Oct 31 2024, 9:51 AM
Unknown Object (File)
Oct 31 2024, 9:51 AM
Unknown Object (File)
Oct 31 2024, 9:51 AM
Unknown Object (File)
Oct 31 2024, 9:51 AM
View All 54 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMM8575cbe405be: [web] cleanup apps modal
Summary

This diff cleans up the one off styles in the apps modal and replaces it with styles of the redesigned modal.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D10240

Test Plan

Please see screenshot below

Screenshot 2023-12-07 at 5.25.53 PM.png (1×3 px, 842 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 7 2023, 2:23 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 7 2023, 2:23 PM
ginsu edited the summary of this revision. (Show Details)Dec 7 2023, 2:26 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10240: [web] cleanup view invite link modal.
ginsu attached a referenced file: F917305: Screenshot 2023-12-07 at 5.25.53 PM.png. (Show Details)
Harbormaster completed remote builds in B24875: Diff 34399.Dec 7 2023, 3:19 PM
ginsu requested review of this revision.Dec 7 2023, 3:19 PM
ginsu added a child revision: D10242: [web] update password change modal css to use camalcase.Dec 7 2023, 3:21 PM
rohan accepted this revision.Dec 8 2023, 5:07 AM
This revision is now accepted and ready to land.Dec 8 2023, 5:07 AM
ginsu updated this revision to Diff 37123.Feb 15 2024, 12:03 AM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 15 2024, 12:10 AM
Closed by commit rCOMM8575cbe405be: [web] cleanup apps modal (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM8575cbe405be: [web] cleanup apps modal.
Harbormaster completed remote builds in B26859: Diff 37123.Feb 15 2024, 12:20 AM

Revision Contents
Changeset List

PathSize
web/
modals/
apps/
3 lines

Diff 37135

View Options

web/modals/apps/apps.css

Loading...