Differential D10269 Authored by ginsu on Dec 8 2023, 11:55 AM.
Details
Summary This diff cleans up the one off styles in the toggle pin modal and replaces it with styles of the redesigned modal. Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs Depends on D10267 Test Plan Please see screenshot below 
Diff Detail
Event TimelineHerald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 11:55 AM2023-12-08 11:55:14 (UTC-8) ginsu edited the summary of this revision. (Show Details)Dec 8 2023, 11:55 AM2023-12-08 11:55:57 (UTC-8) Harbormaster returned this revision to the author for changes because remote builds failed.Dec 8 2023, 12:35 PM2023-12-08 12:35:13 (UTC-8) ginsu added a child revision: D10273: [web] cleanup message reactions modal.Dec 8 2023, 12:42 PM2023-12-08 12:42:43 (UTC-8) This revision is now accepted and ready to land.Dec 10 2023, 8:17 AM2023-12-10 08:17:04 (UTC-8) Harbormaster completed remote builds in B26863: Diff 37139.Feb 15 2024, 12:33 AM2024-02-15 00:33:05 (UTC-8) Closed by commit rCOMMf35d481be277: [web] cleanup toggle pin modal (authored by ginsu). · Explain WhyFeb 15 2024, 12:43 AM2024-02-15 00:43:55 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 37139 |