Page MenuHomePhabricator
Differential D10279

[web] cleanup confirm leave thread modal
ClosedPublic
Actions

Authored by ginsu on Dec 8 2023, 1:30 PM.
Tags
None
Referenced Files
F3300185: D10279.diff
Sun, Nov 17, 6:36 PM
F3296127: D10279.id37159.diff
Sun, Nov 17, 12:49 AM
Unknown Object (File)
Sat, Nov 16, 8:40 AM
Unknown Object (File)
Sat, Nov 16, 5:25 AM
Unknown Object (File)
Fri, Nov 15, 11:23 PM
Unknown Object (File)
Thu, Nov 14, 9:17 PM
Unknown Object (File)
Thu, Nov 14, 5:23 PM
Unknown Object (File)
Thu, Oct 31, 10:09 AM
View All 55 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMMe095dff1c782: [web] cleanup confirm leave thread modal
Summary

This diff cleans up the one off styles in the confirm leave thread modal and replaces it with styles of the redesigned modal.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D10276

Test Plan

Please see screenshot below

Screenshot 2023-12-08 at 4.26.26 PM.png (1×3 px, 834 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 8 2023, 1:30 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 1:30 PM
ginsu edited the summary of this revision. (Show Details)Dec 8 2023, 1:31 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added a parent revision: D10276: [web] cleanup sidebar promote modal.
ginsu added reviewers: atul, rohan, kamil.
ginsu attached a referenced file: F920882: Screenshot 2023-12-08 at 4.26.26 PM.png. (Show Details)
Harbormaster completed remote builds in B24925: Diff 34459.Dec 8 2023, 1:57 PM
ginsu requested review of this revision.Dec 8 2023, 1:57 PM
ginsu added a child revision: D10282: [web] cleanup thread notifications modal rendering logic.Dec 8 2023, 1:58 PM
atul accepted this revision.Dec 10 2023, 5:24 PM
This revision is now accepted and ready to land.Dec 10 2023, 5:24 PM
ginsu updated this revision to Diff 37142.Feb 15 2024, 12:24 AM

rebase before landing

Harbormaster completed remote builds in B26866: Diff 37142.Feb 15 2024, 12:40 AM
Closed by commit rCOMMe095dff1c782: [web] cleanup confirm leave thread modal (authored by ginsu). · Explain WhyFeb 15 2024, 12:44 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMe095dff1c782: [web] cleanup confirm leave thread modal.

Revision Contents
Changeset List

Diff 37142

View Options

web/modals/threads/confirm-leave-thread-modal.css

Loading...
View Options

web/modals/threads/confirm-leave-thread-modal.react.js

Loading...