Page MenuHomePhabricator
Differential D10319

[web] cleanup emoji avatar selection modal
ClosedPublic
Actions

Authored by ginsu on Dec 12 2023, 1:04 PM.
Tags
None
Referenced Files
F3300631: D10319.id37148.diff
Sun, Nov 17, 8:28 PM
Unknown Object (File)
Sat, Nov 2, 8:38 AM
Unknown Object (File)
Thu, Oct 31, 9:36 AM
Unknown Object (File)
Thu, Oct 31, 9:36 AM
Unknown Object (File)
Thu, Oct 31, 9:36 AM
Unknown Object (File)
Thu, Oct 31, 9:36 AM
Unknown Object (File)
Thu, Oct 31, 9:36 AM
Unknown Object (File)
Mon, Oct 28, 8:36 AM
View All 53 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMM5bd009379ebf: [web] cleanup emoji avatar selection modal
Summary

This diff cleans up the one off styles in the emoji avatar modal and replaces it with styles of the redesigned modal.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D10318

Test Plan

Please see screenshot below

Screenshot 2023-12-12 at 4.06.56 PM.png (1×3 px, 944 KB)

Screenshot 2023-12-12 at 4.06.52 PM.png (1×3 px, 811 KB)

Screenshot 2023-12-12 at 4.06.39 PM.png (1×3 px, 939 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 12 2023, 1:04 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 12 2023, 1:04 PM
ginsu edited the summary of this revision. (Show Details)Dec 12 2023, 1:07 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10318: [web] update account delete modal to use camelcase.
ginsu attached a referenced file: F931183: Screenshot 2023-12-12 at 4.06.56 PM.png. (Show Details)
ginsu attached a referenced file: F931182: Screenshot 2023-12-12 at 4.06.52 PM.png. (Show Details)
ginsu attached a referenced file: F931181: Screenshot 2023-12-12 at 4.06.39 PM.png. (Show Details)
ginsu added a child revision: D10320: [web] remove margin from search component.Dec 12 2023, 1:36 PM
Harbormaster completed remote builds in B25003: Diff 34544.Dec 12 2023, 1:58 PM
ginsu requested review of this revision.Dec 12 2023, 1:58 PM
rohan accepted this revision.Dec 14 2023, 9:54 AM
This revision is now accepted and ready to land.Dec 14 2023, 9:54 AM
ginsu updated this revision to Diff 37148.Feb 15 2024, 12:36 AM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 15 2024, 12:44 AM
Closed by commit rCOMM5bd009379ebf: [web] cleanup emoji avatar selection modal (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM5bd009379ebf: [web] cleanup emoji avatar selection modal.
Harbormaster completed remote builds in B26872: Diff 37148.Feb 15 2024, 12:57 AM

Revision Contents
Changeset List

Diff 37163

View Options

web/avatars/emoji-avatar-selection-modal.css

Loading...
View Options

web/avatars/emoji-avatar-selection-modal.react.js

Loading...