Page MenuHomePhabricator

[web] remove margin from search component
ClosedPublic

Authored by ginsu on Dec 12 2023, 1:32 PM.
Tags
None
Referenced Files
F3508049: D10320.id37164.diff
Fri, Dec 20, 9:46 PM
F3506965: D10320.diff
Fri, Dec 20, 6:44 PM
Unknown Object (File)
Sun, Dec 15, 2:25 PM
Unknown Object (File)
Tue, Dec 10, 7:14 AM
Unknown Object (File)
Oct 31 2024, 9:36 AM
Unknown Object (File)
Oct 31 2024, 9:36 AM
Unknown Object (File)
Oct 31 2024, 9:36 AM
Unknown Object (File)
Oct 31 2024, 9:36 AM
Subscribers

Details

Summary

In this diff I remove the margin in the Search component. In subsquent diffs there are some modals that use the Search component and now that we want the edges of the Search component to be flush with the padding of the modals we need to remove the margin in this component and introduce padding containers for the search bars that still need it

Depends on D10319

Test Plan

Confirmed that all places that needed a padding container around the search bar still looked the same

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 12 2023, 2:32 PM
Harbormaster failed remote builds in B25006: Diff 34547!
ginsu requested review of this revision.Dec 12 2023, 2:33 PM

will make sure ci passes before landing

This revision is now accepted and ready to land.Dec 14 2023, 9:55 AM
This revision was landed with ongoing or failed builds.Feb 15 2024, 12:44 AM
This revision was automatically updated to reflect the committed changes.