Page MenuHomePhabricator

[web] fix prop drilling within relationships modals
ClosedPublic

Authored by ginsu on Jan 19 2024, 11:34 AM.
Tags
None
Referenced Files
F3300661: D10743.id37174.diff
Sun, Nov 17, 8:37 PM
F3300627: D10743.id37189.diff
Sun, Nov 17, 8:26 PM
F3300608: D10743.id35891.diff
Sun, Nov 17, 8:19 PM
F3300156: D10743.diff
Sun, Nov 17, 6:23 PM
Unknown Object (File)
Thu, Nov 14, 6:51 PM
Unknown Object (File)
Mon, Nov 11, 2:29 AM
Unknown Object (File)
Sun, Nov 10, 9:22 AM
Unknown Object (File)
Sun, Nov 10, 8:18 AM
Subscribers

Details

Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

As I was working with the relationship modals/panels I found that we were drilling this onClose prop method that pretty much was just popModal. We don't need to drill this down everywhere and instead we can just call popModal using useModalContext hook where we need it.

Depends on D10742

Test Plan

flow + confirmed that the modal on close behavoir was popping as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 19 2024, 4:18 PM
This revision was landed with ongoing or failed builds.Feb 15 2024, 1:18 AM
This revision was automatically updated to reflect the committed changes.