Page MenuHomePhabricator
Differential D12025

[native] display loading spinner in TagChannelButton during loading state
ClosedPublic
Actions

Authored by ginsu on May 13 2024, 11:34 PM.
Tags
None
Referenced Files
F3390837: D12025.id40148.diff
Sat, Nov 30, 1:10 AM
Unknown Object (File)
Tue, Nov 26, 6:45 AM
Unknown Object (File)
Sun, Nov 24, 4:00 PM
Unknown Object (File)
Sun, Nov 24, 1:18 AM
Unknown Object (File)
Sat, Nov 23, 9:08 PM
Unknown Object (File)
Sat, Nov 23, 8:51 AM
Unknown Object (File)
Sat, Nov 23, 4:50 AM
Unknown Object (File)
Sat, Nov 23, 4:16 AM
View All 69 Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
inka
Commits
rCOMM583d5efcfec2: [native] display loading spinner in TagChannelButton during loading state
Summary

When a farcaster channel tag is being created/updated we should show a loading spinner to the user to indicate that their request is currently being handled

Depends on D12024

Test Plan

Confirmed that a loading spinner would be displayed during the loading state

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.May 13 2024, 11:34 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 13 2024, 11:34 PM
ginsu edited the summary of this revision. (Show Details)May 13 2024, 11:35 PM
ginsu added reviewers: tomek, inka.
ginsu added a parent revision: D12024: [native] introduce TagChannelButton.
Harbormaster completed remote builds in B28889: Diff 40148.May 13 2024, 11:50 PM
ginsu requested review of this revision.May 13 2024, 11:50 PM
ginsu added a child revision: D12027: [lib] update community reducer to handle new community action types.May 13 2024, 11:53 PM
tomek accepted this revision.May 14 2024, 3:29 AM
This revision is now accepted and ready to land.May 14 2024, 3:29 AM
ginsu mentioned this in D11894: [native] introduce tag channel by name option in action sheet.May 15 2024, 2:40 PM
ginsu updated this revision to Diff 41009.Jun 5 2024, 11:17 PM

rebase before landing

Harbormaster completed remote builds in B29474: Diff 41009.Jun 5 2024, 11:36 PM
Closed by commit rCOMM583d5efcfec2: [native] display loading spinner in TagChannelButton during loading state (authored by ginsu). · Explain WhyJun 5 2024, 11:57 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM583d5efcfec2: [native] display loading spinner in TagChannelButton during loading state.

Revision Contents
Changeset List

PathSize
native/
community-settings/
tag-farcaster-channel/
39 lines

Diff 40148

View Options

native/community-settings/tag-farcaster-channel/tag-channel-button.react.js

Loading...