Differential D11894
[native] introduce tag channel by name option in action sheet Authored by ginsu on May 6 2024, 12:16 AM. Tags None Referenced Files
Details This diff introduces removes all the unnecessary UI elements and introduces a new "Other" option in the action sheet. When the user presses on the"Other" option they will be navigated to the TagFarcasterChannelByName screen If the user presses on a channel name then a farcaster channel tag will be created with that channel The UI will continue to be updated + improved in a subsequent diff Depends on D11893 Confirmed that a farcaster channel tag was created if a channel name was selected: EDIT: here is a screenshot with the updated /CHANNEL_ID format:  Please see the demo video below
Diff Detail
Event TimelineComment Actions
When the user presses the "Tag channel" button in TagFarcasterChannelByName we will dispatch the create or update farcaster channel tag action and when then when we get a successful response we will go back to this screen, where the user will be able to see the existing newly created tag (showing the existing tag will be introduced in a subsequent diff and is tracked in this linear task: https://linear.app/comm/issue/ENG-7946/display-the-currently-tagged-farcaster-channel-in-the-tag-farcaster ). The implementation for this callback was introduced in D11866. Comment Actions I think it's not obvious that the way to find a channel is to press the pencil button. This is made extra confusing by showing the "Can't find a channel?" prompt. Where exactly should we be expected to find a channel? This UI is confusing and should be revised Comment Actions Let's use eg. /comm instead of Comm. Besides matching Farcaster conventions better, this also lets the user understand more clearly that "Other" isn't a channel name
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||