Adding @tomek because of a new dependency
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Aug 29 2023
Adding @tomek because of new dependency
This and the next diffs seem a bit complicated for the email configuration. I'm going to accept them because this is probably more of a preference but what do you think about:
- Moving the "token replacement from env", from FromStr to the parse method introduces later in the stack. I don't I have ever seen a non-pure from_str so that feels weird to me
- Instead of having a #[clap(ignore)] OnceCell, add a email config to the reports service (probably as an Option<>), and just fill it once during init
LGTM, it's really similar to the previous diff, so I'm assuming any react native stuff will get solved there
LGTM on the backup api, not accepting because it seems like there is some discussion on react-native side, that I'm not very familiar
This is a larger change that we probably don't need to implement but what about creating something more like this:
const httpEndpoints = Object.freeze({ UPLOAD_BACKUP: () => { path: '/backups', method: 'POST', }, GET_USER_KEYS_AUTH: (backup_id) => { path: `/backups/${backup_id}/user_keys`, method: 'GET', },
Maybe even add an argument for auth identity, and make the returned objects contain headers?: string[], that would be added with spread operator to the other headers?
Aug 28 2023
Note that blob cleanup (if error occurs later during upload) will be added in another diff.
Not a fan of ReportInput::time handling with serde, but I don't think we can do much better...
Aug 25 2023
Could we generalise this so it can also DeleteRequest?
Rebase, update lockfiles
Regenerate backup lockfile because of issues with resolving deps. Also updated lockfile of feature flags from anyhow in lib.
Add logging on auth errors
Rebase
Aug 23 2023
Respond to review
Update http port to the previous gRPC port, similar to the planned blob service changes
Thank you for all links for the invariants!
Aug 22 2023
LGTM, depending on how it is used / if there are going to be non-const-creatable fields in the config in the future, we could consider adding a const default:
impl ExponentialBackoffConfig { const DEFAULT: Self = Self { max_attempts: 8, base_duration: std::time::Duration::from_millis(25), retry_on_provisioned_capacity_exceeded: true, }; } impl Default for ExponentialBackoffConfig { fn default() -> Self { Self::DEFAULT } }
so e.g. a service can just create a global const instead of passing the config in some other way.
Add qrCode
Revert the blob client port change
Cool, changed approach to just ignoring the examples
LGTM on the rust side
Aug 21 2023
Rebase
Rebase
Rebase
Removed await. I think I just experimented with a few different solutions and this got left behind.
Rebase
Fix
Remove unrelated changes
I agree with @jon, this was slightly confusing to me at the beginning when I started working on the services.