Page MenuHomePhabricator
Feed Advanced Search

Aug 29 2023

michal added inline comments to D9003: [client-backup] implement backup handler.
Aug 29 2023, 10:34 AM
michal added inline comments to D8988: [reports-service] Send e-mails when received reports.
Aug 29 2023, 10:19 AM
michal accepted D8988: [reports-service] Send e-mails when received reports.
Aug 29 2023, 9:56 AM
michal accepted D8987: [reports-service] Add functions to send e-mails.

Adding @tomek because of a new dependency

Aug 29 2023, 9:49 AM
michal accepted D8986: [reports-service] E-mail: inconsistency report details.
Aug 29 2023, 9:45 AM
michal accepted D8985: [reports-service] E-mail: download links and JSON preview.
Aug 29 2023, 9:37 AM
michal accepted D8984: [reports-service] E-mail subject and summary text.
Aug 29 2023, 9:31 AM
michal accepted D8983: [reports-service] Introduce e-mail template.

Adding @tomek because of new dependency

Aug 29 2023, 9:19 AM
michal accepted D8994: [client-backup] implement API call to get BackupID.
Aug 29 2023, 9:08 AM
michal accepted D8990: [client-backup] add backup-service facts.
Aug 29 2023, 9:06 AM
michal added a reviewer for D8975: [reports-service] Implement Blob storage: tomek.

Adding @tomek because of new dependency while @ashoat is unavailable

Aug 29 2023, 9:05 AM
michal accepted D8980: [reports-service] Parse email config from CLI args.
Aug 29 2023, 8:46 AM
michal accepted D8978: [reports-service] Introduce emails config.

This and the next diffs seem a bit complicated for the email configuration. I'm going to accept them because this is probably more of a preference but what do you think about:

  1. Moving the "token replacement from env", from FromStr to the parse method introduces later in the stack. I don't I have ever seen a non-pure from_str so that feels weird to me
  2. Instead of having a #[clap(ignore)] OnceCell, add a email config to the reports service (probably as an Option<>), and just fill it once during init
Aug 29 2023, 8:45 AM
michal added inline comments to D9002: [client-backup] implement initial restore backup protocol.
Aug 29 2023, 8:02 AM
michal added inline comments to D9001: [client-backup] implement initial backup protocol.
Aug 29 2023, 8:02 AM
michal accepted D8996: [client-backup] implement API call to get UserData.

LGTM, it's really similar to the previous diff, so I'm assuming any react native stuff will get solved there

Aug 29 2023, 7:52 AM
michal added a comment to D8995: [client-backup] implement API call to get UserKeys.

LGTM on the backup api, not accepting because it seems like there is some discussion on react-native side, that I'm not very familiar

Aug 29 2023, 7:50 AM
michal added a comment to D8990: [client-backup] add backup-service facts.

This is a larger change that we probably don't need to implement but what about creating something more like this:

const httpEndpoints = Object.freeze({
  UPLOAD_BACKUP: () => {
    path: '/backups',
    method: 'POST',
  },
  GET_USER_KEYS_AUTH: (backup_id) => {
    path: `/backups/${backup_id}/user_keys`,
    method: 'GET',
  },

Maybe even add an argument for auth identity, and make the returned objects contain headers?: string[], that would be added with spread operator to the other headers?

Aug 29 2023, 7:44 AM
michal added inline comments to D8990: [client-backup] add backup-service facts.
Aug 29 2023, 7:39 AM
michal added inline comments to D8994: [client-backup] implement API call to get BackupID.
Aug 29 2023, 7:31 AM
michal added inline comments to D8990: [client-backup] add backup-service facts.
Aug 29 2023, 7:12 AM
michal accepted D8888: [client-backup] implement C++ functions for encoding/decoding string in `utf-8`.
Aug 29 2023, 5:59 AM
michal accepted D8786: [services-lib] Add HTTP client auth support.
Aug 29 2023, 5:35 AM
michal accepted D8974: [services-lib][blob-client] Use Bytes instead of Vec<u8>.
Aug 29 2023, 5:35 AM

Aug 28 2023

michal accepted D8973: [reports-service] Endpoint for listing reports.
Aug 28 2023, 6:53 AM
michal accepted D8972: [reports-service] Endpoint for Redux Devtools import.
Aug 28 2023, 6:51 AM
michal added inline comments to D8963: [backup] Introduce upload endpoint.
Aug 28 2023, 6:45 AM
michal added inline comments to D8965: [backup] Implement download latest endpoints.
Aug 28 2023, 6:33 AM
michal added inline comments to D8969: [Backup] Old backup cleanup.
Aug 28 2023, 6:32 AM
michal added inline comments to D8959: [blob-service] Remove gRPC service, change default port.
Aug 28 2023, 4:44 AM
michal accepted D8971: [reports-service] Endpoint for viewing single report.
Aug 28 2023, 4:33 AM
michal accepted D8970: [reports-service] Endpoint for uploading reports.
Aug 28 2023, 4:30 AM
michal accepted D8968: [reports-service] Add service error types.
Aug 28 2023, 4:16 AM
michal requested review of D8969: [Backup] Old backup cleanup.
Aug 28 2023, 2:55 AM
michal requested review of D8967: [backup] Revoke holders on upload error.
Aug 28 2023, 2:52 AM
michal requested review of D8965: [backup] Implement download latest endpoints.
Aug 28 2023, 2:19 AM
michal added a comment to D8963: [backup] Introduce upload endpoint.

Note that blob cleanup (if error occurs later during upload) will be added in another diff.

Aug 28 2023, 2:18 AM
michal requested review of D8964: [backup] Introduce download endpoints.
Aug 28 2023, 2:07 AM
michal requested review of D8963: [backup] Introduce upload endpoint.
Aug 28 2023, 1:52 AM
michal requested review of D8962: [backup] Update `BlobItem`.
Aug 28 2023, 1:15 AM
michal accepted D8959: [blob-service] Remove gRPC service, change default port.
Aug 28 2023, 12:44 AM
michal accepted D8951: [reports-service] Add authenticated service.
Aug 28 2023, 12:43 AM
michal accepted D8961: [blob-service] Minor AWS cleanups.
Aug 28 2023, 12:41 AM
michal accepted D8937: [report-service] Add report types structs.

Not a fan of ReportInput::time handling with serde, but I don't think we can do much better...

Aug 28 2023, 12:38 AM
michal accepted D8895: [services-lib] Add BatchWriteItem utility function.

LGTM

Aug 28 2023, 12:11 AM

Aug 25 2023

michal requested review of D8954: [backup] Update dynamodb.
Aug 25 2023, 10:11 AM
michal requested review of D8953: [backup] Split database module.
Aug 25 2023, 10:07 AM
michal requested review of D8952: [backup] Introduce backup error.
Aug 25 2023, 10:07 AM
michal added a comment to D8895: [services-lib] Add BatchWriteItem utility function.

Could we generalise this so it can also DeleteRequest?

Aug 25 2023, 7:57 AM
michal updated the diff for D8911: [services-lib] Add authorization http middleware.

Rebase, update lockfiles

Aug 25 2023, 6:22 AM
michal updated the diff for D8892: [services] Extract multipart handling logic to lib.

Regenerate backup lockfile because of issues with resolving deps. Also updated lockfile of feature flags from anyhow in lib.

Aug 25 2023, 6:20 AM
michal updated the diff for D8911: [services-lib] Add authorization http middleware.

Add logging on auth errors

Aug 25 2023, 6:07 AM
michal updated the diff for D8892: [services] Extract multipart handling logic to lib.

Rebase

Aug 25 2023, 6:00 AM
michal accepted D8936: [backup] Extract constants to lib.
Aug 25 2023, 12:33 AM

Aug 23 2023

michal added inline comments to D8911: [services-lib] Add authorization http middleware.
Aug 23 2023, 10:52 PM
michal added inline comments to D8911: [services-lib] Add authorization http middleware.
Aug 23 2023, 10:50 PM
michal updated the diff for D8911: [services-lib] Add authorization http middleware.

Respond to review

Aug 23 2023, 10:49 PM
michal updated the diff for D8882: [backup] Basic http server.

Update http port to the previous gRPC port, similar to the planned blob service changes

Aug 23 2023, 10:49 PM
michal accepted D8928: [services-lib][blob-client] Revoke holder after upload failure.
Aug 23 2023, 10:48 PM
michal accepted D8932: [keyserver][lib][native][web] Remove connection field from redux.
Aug 23 2023, 10:46 PM
michal accepted D8931: [lib][native][web] Use connection from keyserverStore.

Thank you for all links for the invariants!

Aug 23 2023, 10:45 PM
michal accepted D8924: [keyserver][lib][native] Add connection to keyserverStore.
Aug 23 2023, 10:45 PM
michal accepted D8922: [kesyerver] Remove sessionID from website responders top level.
Aug 23 2023, 6:20 AM
michal added inline comments to D8911: [services-lib] Add authorization http middleware.
Aug 23 2023, 12:23 AM

Aug 22 2023

michal requested review of D8911: [services-lib] Add authorization http middleware.
Aug 22 2023, 7:04 AM
michal accepted D8894: [services-lib] Add DDB batch operation helpers.

LGTM, depending on how it is used / if there are going to be non-const-creatable fields in the config in the future, we could consider adding a const default:

impl ExponentialBackoffConfig {
  const DEFAULT: Self = Self {
        max_attempts: 8,
        base_duration: std::time::Duration::from_millis(25),
        retry_on_provisioned_capacity_exceeded: true,
      };
}
impl Default for ExponentialBackoffConfig {
    fn default() -> Self {
      Self::DEFAULT
    }
  }

so e.g. a service can just create a global const instead of passing the config in some other way.

Aug 22 2023, 3:11 AM
michal updated the diff for D8880: [keyserver] Convert urlInfo in website responders.

Add qrCode

Aug 22 2023, 2:55 AM
michal updated the diff for D8883: [backup] Use blob client.

Revert the blob client port change

Aug 22 2023, 2:50 AM
michal updated the diff for D8889: [comm-services-lib] Fix doctests.

Cool, changed approach to just ignoring the examples

Aug 22 2023, 2:48 AM
michal added inline comments to D8882: [backup] Basic http server.
Aug 22 2023, 2:46 AM
michal accepted D8885: [client-backup] implement Rust function for computing `BackupKey`.

LGTM on the rust side

Aug 22 2023, 2:37 AM
michal added inline comments to D8883: [backup] Use blob client.
Aug 22 2023, 1:11 AM
michal added inline comments to D8882: [backup] Basic http server.
Aug 22 2023, 12:58 AM

Aug 21 2023

michal requested review of D8892: [services] Extract multipart handling logic to lib.
Aug 21 2023, 10:52 AM
michal requested review of D8889: [comm-services-lib] Fix doctests.
Aug 21 2023, 10:06 AM
michal updated the diff for D8883: [backup] Use blob client.

Rebase

Aug 21 2023, 9:41 AM
michal updated the diff for D8882: [backup] Basic http server.

Rebase

Aug 21 2023, 9:40 AM
michal updated the diff for D8881: [services] Extract cors config to services-lib.

Rebase

Aug 21 2023, 9:40 AM
michal updated the diff for D8869: [backup] Standardize localstack config.

Rebase

Aug 21 2023, 9:40 AM
michal updated the diff for D8868: [backup] Update depracted parsing functions.

Rebase

Aug 21 2023, 9:40 AM
michal updated the diff for D8796: [backup] Remove gRPC from backup.

Rebase

Aug 21 2023, 9:39 AM
michal updated the diff for D8867: [blob] Bump async_stream.

Rebase

Aug 21 2023, 9:39 AM
michal updated the diff for D8880: [keyserver] Convert urlInfo in website responders.

Removed await. I think I just experimented with a few different solutions and this got left behind.

Aug 21 2023, 9:37 AM
michal updated the test plan for D8880: [keyserver] Convert urlInfo in website responders.
Aug 21 2023, 8:28 AM
michal updated the diff for D8880: [keyserver] Convert urlInfo in website responders.

Rebase

Aug 21 2023, 8:26 AM
michal updated the diff for D8879: [lib] Move conversion function out of validation utils.

Fix

Aug 21 2023, 8:25 AM
michal updated the diff for D8879: [lib] Move conversion function out of validation utils.

Remove unrelated changes

Aug 21 2023, 8:22 AM
michal planned changes to D8880: [keyserver] Convert urlInfo in website responders.
Aug 21 2023, 8:01 AM
michal planned changes to D8879: [lib] Move conversion function out of validation utils.
Aug 21 2023, 8:00 AM
michal updated the test plan for D8883: [backup] Use blob client.
Aug 21 2023, 5:56 AM
michal requested review of D8883: [backup] Use blob client.
Aug 21 2023, 2:41 AM
michal requested review of D8882: [backup] Basic http server.
Aug 21 2023, 2:31 AM
michal requested review of D8881: [services] Extract cors config to services-lib.
Aug 21 2023, 2:25 AM
michal requested review of D8880: [keyserver] Convert urlInfo in website responders.
Aug 21 2023, 2:14 AM
michal requested review of D8879: [lib] Move conversion function out of validation utils.
Aug 21 2023, 2:05 AM
michal accepted D8865: [reports-service] Add basic config.

I agree with @jon, this was slightly confusing to me at the beginning when I started working on the services.

Aug 21 2023, 12:51 AM

Aug 18 2023

michal accepted D8850: [blob][feature-flags] Replace deprecated methods.
Aug 18 2023, 9:35 AM
michal requested review of D8869: [backup] Standardize localstack config.
Aug 18 2023, 8:13 AM
michal requested review of D8868: [backup] Update depracted parsing functions.
Aug 18 2023, 8:11 AM
michal requested review of D8867: [blob] Bump async_stream.
Aug 18 2023, 8:02 AM