Thanks for fixing this!

Thanks for doing this! I know you're working primarily on web, but while you're doing this could you also rename the MessageResultsScreen for native for the same thing? Let me know if it's a little complicated / it'll delay your work and I can do it later myself as well!

Rebase

CI

CI

I don't think I have enough knowledge here to be helpful, but feel free to re-add me if anything comes up

Thanks for this change! The text is way better than just a blank modal

parentThread --> communityThread

In D10250#298764, @inka wrote:

Doesn't your code make it so that the otherMemberList is always empty?

Rename

Spoke with @ginsu and addressed feedback following that

Looks good - just one comment inline.

Filter users first. Tested to make sure they correctly got filtered if the conditions of excludeStatuses applied

Address feedback

Seams reasonable

In D10250#298189, @inka wrote:

Same comment as in previous diff - even though we were using userStoreSearchIndex we were only displaying the users from this thread. There is some logic in MembersList that takes care of this, that can probably be simplified now. Let me know if you think it should be left as is though, I can see that we could want that. Just wanted to flag that this should be considered

Just requesting changes for the inline comment so it goes back in your queue

'is' --> 'are'

Memoize values(userInfos)

Memoize values(userInfos)

Memoize values(userInfos)

The new modal looks nice!

Rebase + fix conflicts

Rebase + fix conflicts

Rebase

Address feedback

I think @marcin and/or @bartek have more context here than I do, so I'll leave the review to them for this diff

Does it make sense to define the error placeholder in the Modal component directly as an optional prop if we're going to need it in multiple places? Just an idea to enforce consistency

Thanks for doing this!

Use relationshipBlockedInEitherDirection instead of redefining a blocked set

Looks good, I agree on having the comments consistent though

Looks good to me, but it would be nice if someone with more context on this could take a look as well