Page MenuHomePhabricator
Feed Advanced Search

Jan 22 2024

atul updated the diff for D10626: [lib] First pass at removing `LegacyRawThreadInfo`.

rebase

Jan 22 2024, 11:53 AM
atul updated the diff for D10625: Expand instances of `RawThreadInfo` to `LegacyRawThreadInfo|MinimallyEncodedRawTheadInfo`.

rebase

Jan 22 2024, 11:52 AM
atul closed D10624: [lib] Update `ClientCheckStateServerRequest` to contain `MinimallyEncodedRawThreadInfo`s.
Jan 22 2024, 11:49 AM
atul committed rCOMM248cb249022b: [lib] Update `ClientCheckStateServerRequest` to contain… (authored by atul).
[lib] Update `ClientCheckStateServerRequest` to contain…
Jan 22 2024, 11:49 AM
atul closed D10609: [lib] Narrow `ClientFullStateSync` to `MinimallyEncodedRawThreadInfos`.
Jan 22 2024, 11:49 AM
atul committed rCOMM5da040f1a485: [lib] Narrow `ClientFullStateSync` to `MinimallyEncodedRawThreadInfos` (authored by atul).
[lib] Narrow `ClientFullStateSync` to `MinimallyEncodedRawThreadInfos`
Jan 22 2024, 11:49 AM
atul updated the diff for D10624: [lib] Update `ClientCheckStateServerRequest` to contain `MinimallyEncodedRawThreadInfo`s.

rebase and land

Jan 22 2024, 11:47 AM
atul closed D10588: Constrain client `ThreadStore` to `MinimallyEncodedRawThreadInfos`.
Jan 22 2024, 11:42 AM
atul committed rCOMM0f51cccf0ef6: Constrain client `ThreadStore` to `MinimallyEncodedRawThreadInfos` (authored by atul).
Constrain client `ThreadStore` to `MinimallyEncodedRawThreadInfos`
Jan 22 2024, 11:42 AM
atul updated the diff for D10588: Constrain client `ThreadStore` to `MinimallyEncodedRawThreadInfos`.

rebase before landing

Jan 22 2024, 11:38 AM
atul updated the diff for D10792: Rename `ThreadCurrentUserInfo` to `LegacyThreadCurrentUserInfo`.

include the validator change

Jan 22 2024, 11:21 AM
atul requested review of D10792: Rename `ThreadCurrentUserInfo` to `LegacyThreadCurrentUserInfo`.
Jan 22 2024, 11:14 AM
atul requested review of D10791: [lib] Rename `MinimallyEncodedMemberInfo` to `MemberInfo`.
Jan 22 2024, 11:12 AM
atul requested review of D10790: [lib] Remove single usage of `LegacyMemberInfo`.
Jan 22 2024, 10:44 AM
atul requested review of D10789: [lib] Expand `MemberInfo` to `LegacyMemberInfo | MinimallyEncodedMemberInfo`.
Jan 22 2024, 10:33 AM
atul accepted D10747: [web] update add user list header based on if searching users.
Jan 22 2024, 9:47 AM
atul requested changes to D10746: [web] introduce clear all button to add users list.

Let's move the inline CSS styles to the CSS file

Jan 22 2024, 9:46 AM
atul accepted D10745: [web] introduce barebones list header section in add users list.

Looks like CI was network issue. I'll restart

Jan 22 2024, 9:41 AM
atul accepted D10742: [web] fix add users list modal functionality.
Jan 22 2024, 9:38 AM
atul accepted D10735: [web] update add friends modal selection logic.
Jan 22 2024, 9:38 AM
atul accepted D10722: [web] update add users list item ui.
Jan 22 2024, 9:26 AM
atul accepted D10719: [web] move the send friend request button to add users list modal.
Jan 22 2024, 9:24 AM
atul requested review of D10588: Constrain client `ThreadStore` to `MinimallyEncodedRawThreadInfos`.

The invariants in thread-reducer were removed later in the stack. Specifically in D10609 and D10624.

Jan 22 2024, 7:35 AM
atul added a comment to D10609: [lib] Narrow `ClientFullStateSync` to `MinimallyEncodedRawThreadInfos`.

Going to land as is, created a task to track making ServerStateSyncFullSocketPayload ReadOnly: https://linear.app/comm/issue/ENG-6515/make-serverstatesyncfullsocketpayload-readonly

Jan 22 2024, 7:25 AM

Jan 19 2024

atul accepted D10743: [web] fix prop drilling within relationships modals.

Nice, def cleaner

Jan 19 2024, 4:19 PM

Jan 18 2024

atul accepted D10717: [web] make mouse pointer when hovering over checkbox input.

Seems fine to me as long as we're consistent with this sort of thing.

Jan 18 2024, 9:50 PM
atul added inline comments to D10714: [web] add feedback if user list is empty.
Jan 18 2024, 9:48 PM
atul accepted D10714: [web] add feedback if user list is empty.

Unsolicited, but would prefer a simple "No results" without the "Please try searching a different username."

Jan 18 2024, 9:45 PM
atul accepted D10712: [web] introduce block list panel.

Look good. Personally would've preferred deduplicating BlockListModal, but not sure how involved that would've been.

Jan 18 2024, 9:43 PM
atul requested review of D10734: [lib] Rename `MinimallyEncodedRoleInfo` to `RoleInfo`.
Jan 18 2024, 2:35 PM
atul requested review of D10733: [lib] Remove `LegacyRoleInfo` where possible in `lib`.
Jan 18 2024, 2:32 PM
atul requested review of D10731: [lib] Expand `RoleInfo` to `LegacyRoleInfo | MinimallyEncodedRoleInfo`.
Jan 18 2024, 2:28 PM
atul requested review of D10730: Rename `MinimallyEncodedRelativeMemberInfo` to `RelativeMemberInfo`.
Jan 18 2024, 2:24 PM
atul requested review of D10729: [lib] Remove all remaining instances of `LegacyRelativeMemberInfo` from codebase.
Jan 18 2024, 2:22 PM
atul requested review of D10728: [web][native] Remove client usages of `LegacyRelativeMemberInfo`.
Jan 18 2024, 2:19 PM
atul requested review of D10727: [lib] First pass at removing `LegacyRelativeMemberInfo` from `lib`.
Jan 18 2024, 2:15 PM
atul requested review of D10726: Expand `RelativeMemberInfo` to `LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo`.
Jan 18 2024, 2:02 PM
atul requested review of D10725: [lib] Remove unused utilities and validators.
Jan 18 2024, 1:49 PM
atul requested review of D10724: [lib] Remove simple usages of `LegacyRawThreadInfo`.
Jan 18 2024, 1:49 PM
atul requested review of D10720: [lib] Remove `LegacyThreadInfo`-related type utilities.
Jan 18 2024, 12:29 PM
atul requested review of D10721: [lib] Remove `LegacyThreadInfo` and `legacyThreadInfoValidator`.
Jan 18 2024, 12:22 PM
atul published D10718: [lib] Remove branching from `threadInfoFromRawThreadInfo(...)` for review.
Jan 18 2024, 11:40 AM
atul requested review of D10715: [lib] Remove most remaining instances of `LegacyThreadInfo` from codebase.
Jan 18 2024, 11:24 AM
atul requested review of D10713: [keyserver] Remove single instance of `LegacyThreadInfo` from `keyserver`.
Jan 18 2024, 11:04 AM

Jan 17 2024

atul accepted D10688: [lib][web][native] Rename callServerEndpoint to callSingleKeyserverEndpoint.
Jan 17 2024, 10:53 PM
atul requested review of D10678: [lib] Remove `LegacyThreadInfo` where simple in `thread-utils`.
Jan 17 2024, 4:45 PM
atul requested review of D10677: [lib] Remove most remaining instances of `LegacyThreadInfo` from `lib`.
Jan 17 2024, 4:45 PM
atul published D10676: [native] Remove all instances of `LegacyThreadInfo` from `native` for review.
Jan 17 2024, 4:06 PM
atul published D10675: [web] Remove all instances of `LegacyThreadInfo` from `web` for review.
Jan 17 2024, 3:32 PM
atul published D10674: Rename `MinimallyEncodedResolvedThreadInfo` to `ResolvedThreadInfo` for review.
Jan 17 2024, 3:31 PM
atul requested review of D10673: Remove `LegacyResolvedThreadInfo` from the codebase entirely.
Jan 17 2024, 3:22 PM
atul requested review of D10672: [native] Remove instances of `LegacyThreadInfo` throughout `native`.
Jan 17 2024, 3:16 PM
atul added inline comments to D10670: [lib] Update `useResolvedThreadInfos` to remove `LegacyThreadInfo`.
Jan 17 2024, 2:37 PM
atul published D10671: [web] Remove instances of `LegacyThreadInfo` throughout `web` for review.
Jan 17 2024, 2:36 PM
atul requested review of D10670: [lib] Update `useResolvedThreadInfos` to remove `LegacyThreadInfo`.
Jan 17 2024, 2:28 PM

Jan 16 2024

atul requested review of D10655: Expand `ResolvedThreadInfo` alias to `[Legacy/MinimallyEncoded]ResolvedThreadInfo`.
Jan 16 2024, 1:50 PM
atul requested review of D10654: [lib] Remove instances of `LegacyThreadInfo` from `DrawerUtils`.
Jan 16 2024, 1:49 PM

Jan 15 2024

atul requested review of D10645: [lib] First pass at removing `LegacyThreadInfo` from `chat-selectors`.
Jan 15 2024, 3:05 PM
atul requested review of D10646: [lib] Narrow `threadUIName` to `ThreadInfo`.
Jan 15 2024, 2:51 PM
atul requested review of D10644: [lib] Remove `LegacyThreadInfo` from `thread-selectors`.
Jan 15 2024, 2:36 PM
atul requested review of D10643: Rename `MinimallyEncodedThreadInfo` to `ThreadInfo`.
Jan 15 2024, 2:00 PM
atul requested review of D10642: [lib] Remove `ThreadInfo` alias for `[Legacy/MinimallyEncoded]ThreadInfo`.
Jan 15 2024, 1:52 PM
atul requested review of D10641: [lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in `thread-utils`.
Jan 15 2024, 1:31 PM
atul requested review of D10640: [lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in `thread-selectors`.
Jan 15 2024, 1:17 PM
atul requested review of D10639: Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo`.
Jan 15 2024, 1:01 PM
atul requested review of D10638: [lib] Rename `MinimallyEncodedRawThreadInfos` to `RawThreadInfos`.
Jan 15 2024, 11:16 AM
atul requested review of D10637: [lib] Rename `RawThreadInfos` to `MixedRawThreadInfos`.
Jan 15 2024, 11:10 AM
atul published D10634: Rename `MinimallyEncodedRawThreadInfo` to `RawThreadInfo` for review.
Jan 15 2024, 7:19 AM
atul updated the diff for D10627: [lib] First pass at removing `RawThreadInfos`.

stage more

Jan 15 2024, 7:04 AM
atul updated the diff for D10627: [lib] First pass at removing `RawThreadInfos`.

include more changes

Jan 15 2024, 6:59 AM
atul added a comment to D10622: [Buildkite] Bump `node` for ESLint/Flow/Jest and JSI CodeGen workflows.

Re. failing Codegen JSI

fatal: detected dubious ownership in repository at '/comm'
To add an exception for this directory, call:
 
	git config --global --add safe.directory /comm

Not sure what started to cause this, but I had the exact same problem with the "gRPC-Web Codegen CI" job and fixed it by adding the following command:

steps:
  - label: 'Foo'
    command:
      - 'git config --global --add safe.directory "*"'
      - ...
Jan 15 2024, 6:57 AM

Jan 14 2024

atul requested review of D10627: [lib] First pass at removing `RawThreadInfos`.
Jan 14 2024, 8:48 PM
atul updated the diff for D10626: [lib] First pass at removing `LegacyRawThreadInfo`.

include some more

Jan 14 2024, 8:05 PM
atul requested review of D10626: [lib] First pass at removing `LegacyRawThreadInfo`.
Jan 14 2024, 7:51 PM
atul requested review of D10625: Expand instances of `RawThreadInfo` to `LegacyRawThreadInfo|MinimallyEncodedRawTheadInfo`.
Jan 14 2024, 6:49 PM
atul requested review of D10624: [lib] Update `ClientCheckStateServerRequest` to contain `MinimallyEncodedRawThreadInfo`s.
Jan 14 2024, 5:45 PM
atul closed D10608: [lib] Narrow `Register[Response/Result]` to `MinimallyEncodedRawThreadInfos`.
Jan 14 2024, 4:23 PM
atul committed rCOMM4566286262c9: [lib] Narrow `Register[Response/Result]` to `MinimallyEncodedRawThreadInfos` (authored by atul).
[lib] Narrow `Register[Response/Result]` to `MinimallyEncodedRawThreadInfos`
Jan 14 2024, 4:23 PM
atul updated the diff for D10608: [lib] Narrow `Register[Response/Result]` to `MinimallyEncodedRawThreadInfos`.

land

Jan 14 2024, 4:19 PM
atul closed D10606: [lib] Narrow `LogIn[Response/Result]` to `MinimallyEncodedRawThreadInfos`.
Jan 14 2024, 4:11 PM
atul committed rCOMMc6999dbbc0a7: [lib] Narrow `LogIn[Response/Result]` to `MinimallyEncodedRawThreadInfos` (authored by atul).
[lib] Narrow `LogIn[Response/Result]` to `MinimallyEncodedRawThreadInfos`
Jan 14 2024, 4:11 PM
atul updated the diff for D10606: [lib] Narrow `LogIn[Response/Result]` to `MinimallyEncodedRawThreadInfos`.

make cookieChange readonly

Jan 14 2024, 3:09 PM

Jan 13 2024

atul attached a referenced file: F1058362: 922a45.png.
Jan 13 2024, 12:18 AM
atul added inline comments to D10609: [lib] Narrow `ClientFullStateSync` to `MinimallyEncodedRawThreadInfos`.
Jan 13 2024, 12:17 AM
atul updated the diff for D10609: [lib] Narrow `ClientFullStateSync` to `MinimallyEncodedRawThreadInfos`.

make readonly

Jan 13 2024, 12:07 AM

Jan 12 2024

atul updated the diff for D10608: [lib] Narrow `Register[Response/Result]` to `MinimallyEncodedRawThreadInfos`.

remove extraneous change

Jan 12 2024, 11:54 PM
atul updated the diff for D10608: [lib] Narrow `Register[Response/Result]` to `MinimallyEncodedRawThreadInfos`.

address feedback (make readonly)

Jan 12 2024, 11:45 PM
atul planned changes to D10622: [Buildkite] Bump `node` for ESLint/Flow/Jest and JSI CodeGen workflows.
Jan 12 2024, 11:36 PM
atul accepted D10617: [web] introduce friend list panel.

Thanks for linking the Linear task!

Jan 12 2024, 1:44 PM
atul accepted D10614: [web] introduce friend and block lists to user settings list.
Jan 12 2024, 1:21 PM
atul accepted D10612: [web] introduce user settings list.
Jan 12 2024, 1:20 PM
atul added inline comments to D10561: [nix] Upgrade to latest version of nixpkgs-unstable.
Jan 12 2024, 1:19 PM
atul attached a referenced file: F1057741: ca8aed.png.
Jan 12 2024, 1:19 PM
atul requested review of D10622: [Buildkite] Bump `node` for ESLint/Flow/Jest and JSI CodeGen workflows.
Jan 12 2024, 1:19 PM
atul accepted D10611: [web] introduce user settings list item.
Jan 12 2024, 12:43 PM
atul accepted D10610: [web] introduce panel header component.
Jan 12 2024, 12:27 PM
atul accepted D10561: [nix] Upgrade to latest version of nixpkgs-unstable.
Jan 12 2024, 11:24 AM

Jan 11 2024

atul planned changes to D10609: [lib] Narrow `ClientFullStateSync` to `MinimallyEncodedRawThreadInfos`.

pre-commit hooks aren't catching flow issues in keyserver, will try a clean install

Jan 11 2024, 9:47 AM
atul planned changes to D10608: [lib] Narrow `Register[Response/Result]` to `MinimallyEncodedRawThreadInfos`.
Jan 11 2024, 9:46 AM
atul published D10609: [lib] Narrow `ClientFullStateSync` to `MinimallyEncodedRawThreadInfos` for review.
Jan 11 2024, 9:45 AM