One last round here, this looks almost ready

Would be great if @atul could take a look as well. If we're not propagating VOICED_IN_ANNOUNCEMENT_CHANNELS I guess this is okay, but in that case I might need a reminder on how we're applying it in subchannels

This is close, but one last round here

1. The WHOLE point of this diff is to unify the existing role logic with your new logic. You need to make getRolePermissionBlobs work based off of:
   • A new, modified version of universalCommunityPermissions that differentiates based on ThreadType
   • configurableCommunityPermissions
2. This diff needs to actually change the code in getRolePermissionBlobs. It is not enough to introduce some new utility. If you want to skip this diff into multiple, please do not request review until all of the diffs are ready.
3. This diff should be a no-op. There should be no changes to the result of getRolePermissionBlobs. It should simply be updated to function based on your new logic.

Please do NOT update this diff again until you schedule a 1:1 call with me

To be frank I was confused before and I'm more confused now.

Worried that the RegExp is invalidating some legitimate ENS names. Please try to read the spec and figure out what counts as a legitimate ENS name. Would be good to introduce some test cases to cover those

The package doesn't export it and the API docs don't mention it, so I'm thinking we cannot access it.

Both of these use an unexposed method validateLabel to process the labels:

I'm confused by the description above.

This seems like a significant change. @marcin, should you consider re-requesting review?

This seems like a significant change. @marcin, should you consider re-requesting review?

Adding @atul here because he has the most context on SQLite redux-persist migrations

Thanks for explaining!

and as far as I understand for now we are just leaving all data related to a keyserver when we leave it. @ginsu is that right?

Can you share a screenshot of the UI that was changed? Not just the pill, but the pill in the context of where it's used

This was a massive diff. I really would've appreciated it if you had broken it down further like I requested yesterday. When you have a diff that is so huge, it's your responsibility as the diff author to make sure each line is basically identical and trivial. I would strongly prefer that next time, you break down ANYTHING that isn't "identical and trivial" into a separate, freestanding diff. Accepting this to unblock but please internalize this feedback – I will request changes next time

You say you're matching master, but it seems to me that you're changing the behavior of getRolePermissionBlobsForCommunity in this diff.

Am I missing something? Seems like a lot of issues here. I didn't get through the whole review (it's pretty time-consuming to trace each individual permission through these function calls) but it seems pretty clear that at least some of it is wrong. Hoping you can fix it up before I do a full review so I can save some time.

I think there's a mistake here – see my inline comment. Please make sure to remove that change before landing (or if there's some good reason for it, can you re-request review)?

Love the detailed test plan and all the videos!

Rebase

Rebase after addressing users-state-sync-spec.js changes in earlier diffs in the stack (where it's relevant)

Lint fixes for last rebase

Rebase

Rebase

Have you checked the spec?

Rebase

Rebase and address @kamil's feedback

Address @michal's feedback to avoid excessive runtime checks

Rebase

Rebase

Rebase

Seems reasonable to me. I haven't audited all places on the client where reports are constructed – hoping you went through all of those cases carefully

Rebase

@michal's suggestion

This may be the wrong diff to ask this question on, but I'm wondering – how will the MessageStore (and other stores such as ThreadStore) be affected when a keyserver is dropped from the KeyserverStore?

Rebase

Thanks @inka! In general I agree, but I think this copy won't be surfaced to users (right @ginsu?) so it's probably not that important. Correct me if I'm wrong though!

Rebase

Please add types before landing

Rebase