Page MenuHomePhabricator
Feed All Stories

Mar 29 2024

bartek published D11471: [protos][identity] Add primary device keys to GetKeyserverKeys response for review.

Some comments/proposals appeared in ENG-7598 that we need to take into account here. Requesting review now to open discussions

Mar 29 2024, 12:34 AM
bartek published D11470: [native] Add JSI bindings for LogInExistingDevice RPC for review.
Mar 29 2024, 12:20 AM
bartek published D11469: [native] Add LogInExistingDevice to native_rust_library for review.
Mar 29 2024, 12:19 AM
bartek published D11468: [commtest] Add test for LogInExistingDevice RPC for review.
Mar 29 2024, 12:19 AM
bartek published D11467: [commtest] Add helpers for ED25519 signing messages for review.
Mar 29 2024, 12:18 AM
bartek published D11466: [identity] Implement LogInExistingDevice RPC for review.
Mar 29 2024, 12:11 AM

Mar 28 2024

bartek published D11465: [protos] Add RPC to log in existing device for review.
Mar 28 2024, 11:49 PM
bartek published D11464: [commtest] Add test for FindUserIdentity RPC for review.
Mar 28 2024, 11:05 PM
bartek published D11435: [protos] Reorder some RPCs for review.
Mar 28 2024, 11:05 PM
ginsu requested review of D11463: [native] introduce already connected button to farcaster connect.

will make sure the ci passes before landing

Mar 28 2024, 10:09 PM
ginsu requested review of D11462: [native] implement onSuccess callback for ConnectFarcaster registration step.

will make sure ci passes before landing

Mar 28 2024, 9:47 PM
ginsu requested review of D11461: [native] add the connect farcaster step into the registration flow.
Mar 28 2024, 9:45 PM
ginsu accepted D11457: [lib] Fix `UpdateRelationshipMessageSpec.validator`.
Mar 28 2024, 8:43 PM
ginsu accepted D11455: [lib] Update `rawMessageInfoFromClientDB` to support `RawUpdateRelationshipMessageInfo`.
Mar 28 2024, 8:43 PM
ginsu accepted D11452: [lib] Partially update `UpdateRelationshipMessageSpec` to support updated `UpdateRelationship` message type.
Mar 28 2024, 8:32 PM
ginsu accepted D11443: [lib] Update `messageContentFor[Client/Server]DB` to handle `UpdateRelationship`.
Mar 28 2024, 8:26 PM
ginsu accepted D11439: [lib] Update union types in `message-types` to include `UpdateRelationship` types.
Mar 28 2024, 8:25 PM
ginsu accepted D11438: [lib] Introduce bare minimum `messageTypes.UPDATE_RELATIONSHIP`.

lgtm

Mar 28 2024, 8:24 PM
ginsu accepted D11460: [lib] Hook everything together in FarcasterDataHandler.
Mar 28 2024, 8:21 PM
ashoat requested review of D11460: [lib] Hook everything together in FarcasterDataHandler.
Mar 28 2024, 7:46 PM
ashoat closed D11444: [native] Fix up project.pbxproj after yarn cleaninstall.
Mar 28 2024, 7:13 PM
ashoat committed rCOMMa0cab739d3ff: [native] Fix up project.pbxproj after yarn cleaninstall (authored by ashoat).
[native] Fix up project.pbxproj after yarn cleaninstall
Mar 28 2024, 7:13 PM
ashoat accepted D11459: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`.

I previously reviewed this code in person

Mar 28 2024, 7:09 PM
will added inline comments to D11422: [lib/native/web] introduce synced metadata reducer.
Mar 28 2024, 5:03 PM
will updated the diff for D11422: [lib/native/web] introduce synced metadata reducer.

review feedback

Mar 28 2024, 4:55 PM
ashoat accepted D11458: [lib] Handle `farcaster_mutual` case in `robotext/notificationTexts`.

We have ENG-7514 to track improving the robotext here, so that it mentions the user's Farcaster username

Mar 28 2024, 4:30 PM
will added inline comments to D11417: [sqlite] add methods to operate on synced metadata table.
Mar 28 2024, 4:23 PM
will accepted D11444: [native] Fix up project.pbxproj after yarn cleaninstall.

Just as a note, planning on removing this file from project.pbxproj. Context: https://phab.comm.dev/D11417?id=38396#inline-69092

Mar 28 2024, 4:16 PM
varun closed D11433: [lib][web][native] add unlinkFarcasterAccount to IdentityServiceClient interface and implementations.
Mar 28 2024, 3:17 PM
varun committed rCOMM3806a88cd6aa: [lib][web][native] add unlinkFarcasterAccount to IdentityServiceClient… (authored by varun).
[lib][web][native] add unlinkFarcasterAccount to IdentityServiceClient…
Mar 28 2024, 3:17 PM
varun closed D11431: [native] add unlinkFarcasterAccount to CommRustModule.
Mar 28 2024, 3:17 PM
varun closed D11430: [native_rust_library] unlink_farcaster_account method.
Mar 28 2024, 3:17 PM
varun committed rCOMM8cda325dd924: [native] add unlinkFarcasterAccount to CommRustModule (authored by varun).
[native] add unlinkFarcasterAccount to CommRustModule
Mar 28 2024, 3:17 PM
varun committed rCOMMcfc0654d4c18: [native_rust_library] unlink_farcaster_account method (authored by varun).
[native_rust_library] unlink_farcaster_account method
Mar 28 2024, 3:17 PM
varun closed D11423: [identity] unlink farcaster account RPC.
Mar 28 2024, 3:17 PM
varun committed rCOMM361377ad6c39: [identity] unlink farcaster account RPC (authored by varun).
[identity] unlink farcaster account RPC
Mar 28 2024, 3:17 PM
varun closed D11413: [identity] on linkFarcasterUser we should return an error if the FID already exists for a different user in the users table.
Mar 28 2024, 3:17 PM
varun closed D11412: [identity] check if fid is already taken when registering new user.
Mar 28 2024, 3:17 PM
varun committed rCOMM7e269eae587e: [identity] on linkFarcasterUser we should return an error if the FID already… (authored by varun).
[identity] on linkFarcasterUser we should return an error if the FID already…
Mar 28 2024, 3:17 PM
varun committed rCOMMc648927875bc: [identity] check if fid is already taken when registering new user (authored by varun).
[identity] check if fid is already taken when registering new user
Mar 28 2024, 3:17 PM
varun closed D11411: [identity] don't let linkFarcasterAccount overwrite existing fid for user.
Mar 28 2024, 3:17 PM
varun closed D11410: [web] add client methods to web.
Mar 28 2024, 3:17 PM
varun committed rCOMM8ec3ffdc4d77: [identity] don't let linkFarcasterAccount overwrite existing fid for user (authored by varun).
[identity] don't let linkFarcasterAccount overwrite existing fid for user
Mar 28 2024, 3:17 PM
varun committed rCOMM563337b5ede7: [web] add client methods to web (authored by varun).
[web] add client methods to web
Mar 28 2024, 3:17 PM
varun closed D11409: [native] add linkFarcasterAccount to native IdentityServiceContextProvider.
Mar 28 2024, 3:17 PM
varun closed D11408: [native] add linkFarcasterAccount to commRustModule.
Mar 28 2024, 3:17 PM
varun committed rCOMM046f7eed864b: [native] add linkFarcasterAccount to native IdentityServiceContextProvider (authored by varun).
[native] add linkFarcasterAccount to native IdentityServiceContextProvider
Mar 28 2024, 3:17 PM
varun committed rCOMM80b046bb17c9: [native] add linkFarcasterAccount to commRustModule (authored by varun).
[native] add linkFarcasterAccount to commRustModule
Mar 28 2024, 3:17 PM
varun closed D11407: [native_rust_library] implement link_farcaster_account client method.
Mar 28 2024, 3:17 PM
varun committed rCOMM607b65279825: [native_rust_library] implement link_farcaster_account client method (authored by varun).
[native_rust_library] implement link_farcaster_account client method
Mar 28 2024, 3:17 PM
varun closed D11406: [identity] link farcaster account implementation.
Mar 28 2024, 3:13 PM
varun closed D11405: [lib][native] Add getFarcasterUsers to IdentityServiceContextProvider.
Mar 28 2024, 3:13 PM
varun committed rCOMMf1d96072c6f2: [identity] link farcaster account implementation (authored by varun).
[identity] link farcaster account implementation
Mar 28 2024, 3:13 PM
varun committed rCOMM17638e45a66f: [lib][native] Add getFarcasterUsers to IdentityServiceContextProvider (authored by ashoat).
[lib][native] Add getFarcasterUsers to IdentityServiceContextProvider
Mar 28 2024, 3:13 PM
varun closed D11403: [native_rust_library] get_farcaster_users client method.
Mar 28 2024, 3:13 PM
varun closed D11404: [native] add getFarcasterUsers to commRustModule.
Mar 28 2024, 3:13 PM
varun committed rCOMMa9273fca68b7: [native_rust_library] get_farcaster_users client method (authored by varun).
[native_rust_library] get_farcaster_users client method
Mar 28 2024, 3:13 PM
varun committed rCOMM1c4801b3aae5: [native] add getFarcasterUsers to commRustModule (authored by varun).
[native] add getFarcasterUsers to commRustModule
Mar 28 2024, 3:13 PM
varun closed D11402: [identity] get farcaster users rpc implementation.
Mar 28 2024, 3:13 PM
varun committed rCOMM88d9a0987b2b: [identity] get farcaster users rpc implementation (authored by varun).
[identity] get farcaster users rpc implementation
Mar 28 2024, 3:13 PM
varun closed D11401: [identity] db method to get users for a set of farcaster ids.
Mar 28 2024, 2:55 PM
varun closed D11400: [terraform] add GSI for farcasterID.
Mar 28 2024, 2:55 PM
varun committed rCOMMaa1feb75a585: [identity] db method to get users for a set of farcaster ids (authored by varun).
[identity] db method to get users for a set of farcaster ids
Mar 28 2024, 2:55 PM
varun committed rCOMM6a0e5b571f8b: [terraform] add GSI for farcasterID (authored by varun).
[terraform] add GSI for farcasterID
Mar 28 2024, 2:55 PM
varun closed D11399: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs.
Mar 28 2024, 2:55 PM
varun closed D11398: [native] expose farcaster id param to native identity service context provider.
Mar 28 2024, 2:55 PM
varun committed rCOMMcbc627ce542e: [native] expose farcaster id param to native identity service context provider (authored by varun).
[native] expose farcaster id param to native identity service context provider
Mar 28 2024, 2:55 PM
varun committed rCOMMcbdd966e6c5f: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs (authored by varun).
[identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs
Mar 28 2024, 2:55 PM
varun closed D11396: [proto][identity] add optional fid to registration request messages.
Mar 28 2024, 2:55 PM
varun committed rCOMM75706c132d20: [proto][identity] add optional fid to registration request messages (authored by varun).
[proto][identity] add optional fid to registration request messages
Mar 28 2024, 2:55 PM
varun added inline comments to D11406: [identity] link farcaster account implementation.
Mar 28 2024, 2:45 PM
varun added inline comments to D11411: [identity] don't let linkFarcasterAccount overwrite existing fid for user.
Mar 28 2024, 2:33 PM
varun added inline comments to D11403: [native_rust_library] get_farcaster_users client method.
Mar 28 2024, 2:17 PM
varun added inline comments to D11401: [identity] db method to get users for a set of farcaster ids.
Mar 28 2024, 2:06 PM
will abandoned D11454: [sqlite] downgrade migration version on native from '65' to '64'.

https://linear.app/comm/issue/ENG-7597/app-crashes-when-running-migration-65#comment-8b4375fe resolved

Mar 28 2024, 1:54 PM
will added a comment to D11454: [sqlite] downgrade migration version on native from '65' to '64'.

https://linear.app/comm/issue/ENG-7597/app-crashes-when-running-migration-65#comment-8b4375fe resolved.

Mar 28 2024, 1:48 PM
will abandoned D11453: Revert "[native][web] Read integrity thread hashes from SQLite on app start".

https://linear.app/comm/issue/ENG-7597/app-crashes-when-running-migration-65#comment-8b4375fe resolved

Mar 28 2024, 1:48 PM
will abandoned D11456: Revert "[lib] integrity reducer tests".

https://linear.app/comm/issue/ENG-7597/app-crashes-when-running-migration-65#comment-8b4375fe resolved.

Mar 28 2024, 1:48 PM
varun added inline comments to D11401: [identity] db method to get users for a set of farcaster ids.
Mar 28 2024, 1:38 PM
atul requested review of D11459: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`.
Mar 28 2024, 1:10 PM
ginsu added inline comments to D11442: [native] introduce ConnectFarcaster registration screen.
Mar 28 2024, 12:45 PM
ginsu updated the diff for D11442: [native] introduce ConnectFarcaster registration screen.

update

Mar 28 2024, 12:44 PM
atul published D11458: [lib] Handle `farcaster_mutual` case in `robotext/notificationTexts` for review.
Mar 28 2024, 12:12 PM
varun accepted D11379: [protos][identity] Add RPC to find username by user ID.

do we need to change any client code now that some of these RPCs are returning "not found" ?

Mar 28 2024, 12:03 PM
atul requested review of D11457: [lib] Fix `UpdateRelationshipMessageSpec.validator`.
Mar 28 2024, 11:49 AM
ashoat accepted D11454: [sqlite] downgrade migration version on native from '65' to '64'.
Mar 28 2024, 11:46 AM
ashoat accepted D11456: Revert "[lib] integrity reducer tests".
Mar 28 2024, 11:46 AM
ashoat accepted D11453: Revert "[native][web] Read integrity thread hashes from SQLite on app start".
Mar 28 2024, 11:46 AM
will requested review of D11453: Revert "[native][web] Read integrity thread hashes from SQLite on app start".
Mar 28 2024, 11:42 AM
will requested review of D11456: Revert "[lib] integrity reducer tests".
Mar 28 2024, 11:40 AM
atul published D11455: [lib] Update `rawMessageInfoFromClientDB` to support `RawUpdateRelationshipMessageInfo` for review.
Mar 28 2024, 11:35 AM
will added a reverting change for D11359: [lib] integrity reducer tests: D11456: Revert "[lib] integrity reducer tests".
Mar 28 2024, 11:25 AM
will added a reverting change for rCOMM2c577fabda21: [lib] integrity reducer tests: D11456: Revert "[lib] integrity reducer tests".
Mar 28 2024, 11:25 AM
will requested review of D11454: [sqlite] downgrade migration version on native from '65' to '64'.
Mar 28 2024, 11:24 AM
will added a reverting change for D11358: [native][web] Read integrity thread hashes from SQLite on app start: D11453: Revert "[native][web] Read integrity thread hashes from SQLite on app start".
Mar 28 2024, 11:08 AM
will added a reverting change for rCOMM5695216e237f: [native][web] Read integrity thread hashes from SQLite on app start: D11453: Revert "[native][web] Read integrity thread hashes from SQLite on app start".
Mar 28 2024, 11:08 AM
ginsu closed D11434: [native] introduce FarcasterLogo.
Mar 28 2024, 10:58 AM
ginsu closed D11432: [landing/lib/native] introduce FarcasterWebView.
Mar 28 2024, 10:58 AM
ginsu committed rCOMM3941d90cb605: [native] introduce FarcasterLogo (authored by ginsu).
[native] introduce FarcasterLogo
Mar 28 2024, 10:58 AM
ginsu committed rCOMMaabf91724a80: [landing/lib/native] introduce FarcasterWebView (authored by ginsu).
[landing/lib/native] introduce FarcasterWebView
Mar 28 2024, 10:58 AM