In D9158#269711, @ashoat wrote:

Awesome that we get the health check for free! I assume we'll need to implement something on the client for that to work, yes? The Tunnelbroker client in keyserver currently uses the ws library for Node.js

address feedback (CommSecureStore changes will come later, but wanted to acknowledge the comment)

stage all

land

Awesome that we get the health check for free! I assume we'll need to implement something on the client for that to work, yes? The Tunnelbroker client in keyserver currently uses the ws library for Node.js

In D9142#269446, @atul wrote:

What's the command to run tests? Can they be run without any additional configuration?

rebase before landing

rebase before landing

rebase before landing

spelling :/

address @atul's feedback

thanks for fixing this!

Personal preference is memoization "inside" the component w/ useMemo hook so everything is self-contained and memoization is consistent and whatnot, but this is valid

Sending back to your queue to address feedback from @inka/@ashoat

address @ginsu's feedback

rebase and land

What's the command to run tests? Can they be run without any additional configuration?

rebase and land

I wonder if it would be possible to rewrite this to use React hooks instead of createSelector. I believe that all uses of createSelector can be replaced by React.useMemo. The selector funcs passed to createSelector turn into dep lists. React hooks are more modern idioms than createSelector, but I'm not sure as to all of the tradeoffs.

Can we dedup this with the existing getOneTimeKeyValues? Looks like D8751 moves it around.

I think the reason is that ChatContextProvider renders dummy nodes for height measurement, and now those dummy nodes need navigation state since they might be rendering a link to a chat

Thank you!!

1. I think we should implement a separate reducer for this. We should expect that the access token will need to be cleared for a log out, account deletion, and session invalidation. For an example, see here
2. I think the reducer should be in lib, since this action will be shared with web. I think it should be possible to submit this diff purely on lib, without touching native or web
3. Please keep in mind that we will also need this info to be in CommSecureStore for @marcin's purposes, since he needs to be able to access it from native code (and NSE in particular)

Nice!! Some nonstandard stuff in this diff; requesting changes in the hopes that we can use the more standard mechanisms

Ah, my bad. It looks like @atul is right... this change would have been marginally beneficial. Sorry @ginsu!

If the UX change originating from this diff is not acceptable the alternative approach we can experiment with is to silence every collapsible notifications and schedule local notifications from the NSE. This way we will be able to set request.identifier property (since we are the ones creating the UNNotificationRequest instance) and let the OS do the coalescing.

Update coalescing condition.

Looking at the code of our Olm fork, it looks like the only effect of calling mark_prekey_as_published() is on the result of calling unpublished_prekey(). The only place we check unpublished_prekey is in the above code, where we use it to make sure that we don't throw away an old prekey before the newer prekey is published.

LGTM, mostly just a rename

What happens if this action fails?

@bartek, @michal could you take a brief look at Rust?

JS looks good, but I don't know Rust so couldn't review that part

Is it possible that a user with this id will not be in our store?