Page MenuHomePhabricator
Differential D10273

[web] cleanup message reactions modal
ClosedPublic
Actions

Authored by ginsu on Dec 8 2023, 12:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 1, 6:11 AM
Unknown Object (File)
Sat, Nov 30, 11:55 PM
Unknown Object (File)
Sat, Nov 30, 9:26 AM
Unknown Object (File)
Sat, Nov 30, 4:42 AM
Unknown Object (File)
Fri, Nov 29, 11:38 AM
Unknown Object (File)
Nov 17 2024, 8:20 PM
Unknown Object (File)
Oct 31 2024, 10:09 AM
Unknown Object (File)
Oct 24 2024, 4:14 PM
View All 54 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMM1742e82ab50a: [web] cleanup message reactions modal
Summary

This diff cleans up the one off styles in the message reactions modal and replaces it with styles of the redesigned modal.

Linear task: Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D10269

Test Plan

Please see screenshot below

Screenshot 2023-12-08 at 3.38.17 PM.png (1×3 px, 871 KB)

Diff Detail

Repository
rCOMM Comm
Branch
eng-5923 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 8 2023, 12:40 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 12:40 PM
ginsu edited the summary of this revision. (Show Details)Dec 8 2023, 12:42 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10269: [web] cleanup toggle pin modal.
ginsu attached a referenced file: F920580: Screenshot 2023-12-08 at 3.38.17 PM.png. (Show Details)
ginsu added a child revision: D10276: [web] cleanup sidebar promote modal.Dec 8 2023, 12:57 PM
Harbormaster completed remote builds in B24918: Diff 34452.Dec 8 2023, 12:58 PM
ginsu requested review of this revision.Dec 8 2023, 12:58 PM
rohan accepted this revision.Dec 10 2023, 8:17 AM
This revision is now accepted and ready to land.Dec 10 2023, 8:17 AM
ginsu updated this revision to Diff 37140.Feb 15 2024, 12:19 AM

rebase before landing

Harbormaster completed remote builds in B26864: Diff 37140.Feb 15 2024, 12:36 AM
Closed by commit rCOMM1742e82ab50a: [web] cleanup message reactions modal (authored by ginsu). · Explain WhyFeb 15 2024, 12:43 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM1742e82ab50a: [web] cleanup message reactions modal.

Revision Contents
Changeset List

PathSize
web/
modals/
chat/
1 line

Diff 34452

View Options

web/modals/chat/message-reactions-modal.css

Loading...