Page MenuHomePhabricator
Differential D11866

[native] implement onPressTagChannel for TagUnfollowedFarcasterChannel
ClosedPublic
Actions

Authored by ginsu on May 3 2024, 12:49 AM.
Tags
None
Referenced Files
F3303116: D11866.diff
Mon, Nov 18, 10:26 AM
Unknown Object (File)
Fri, Nov 15, 6:06 AM
Unknown Object (File)
Sun, Nov 10, 3:22 PM
Unknown Object (File)
Sun, Nov 10, 12:10 PM
Unknown Object (File)
Sun, Nov 10, 11:41 AM
Unknown Object (File)
Sun, Nov 10, 8:54 AM
Unknown Object (File)
Fri, Nov 8, 7:18 PM
Unknown Object (File)
Oct 11 2024, 6:38 PM
View All 71 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
ashoat
Commits
rCOMMd6191262831f: [native] implement onPressTagChannel for TagUnfollowedFarcasterChannel
Summary

This diff implements the logic for onPressTagChannel in TagUnfollowedFarcasterChannel. The important thing about this method is that before dispatching our action promise, we want to validate the input through fetchFarcasterChannelByName

Depends on D11857

Test Plan

Confirmed that fetchFarcasterChannelByName correctly validates the input and createOrUpdateFarcasterChannelTag action is dispatched when the input is valid. Otherwise confirmed that I was logging the error message

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.May 3 2024, 12:49 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 3 2024, 12:49 AM
ginsu edited the summary of this revision. (Show Details)May 3 2024, 12:51 AM
ginsu added a reviewer: inka.
ginsu added a parent revision: D11865: [lib] introduce fetchFarcasterChannelByName to neynar client class.
ginsu added inline comments.
native/community-settings/tag-farcaster-channel/tag-unfollowed-farcaster-channel.react.js
72 ↗(On Diff #39759)

This will be implemented in a subsequent diff

ginsu published this revision for review.May 3 2024, 12:53 AM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)

will make sure ci passes before landing

native/community-settings/tag-farcaster-channel/tag-unfollowed-farcaster-channel.react.js
57 ↗(On Diff #39759)

This will be implemented in a subsequent diff

Harbormaster failed remote builds in B28641: Diff 39759!May 3 2024, 12:59 AM
ashoat accepted this revision.May 4 2024, 11:08 AM
ashoat added inline comments.
native/community-settings/tag-farcaster-channel/tag-unfollowed-farcaster-channel.react.js
87 ↗(On Diff #39759)

Should we add .fetchFarcasterChannelByName here?

This revision is now accepted and ready to land.May 4 2024, 11:08 AM
ginsu edited the summary of this revision. (Show Details)May 5 2024, 5:45 PM
ginsu added a parent revision: D11857: [native] implement UI for TagUnfollowedFarcasterChannel screen.
ginsu removed a parent revision: D11865: [lib] introduce fetchFarcasterChannelByName to neynar client class.
ginsu removed a parent revision: D11857: [native] implement UI for TagUnfollowedFarcasterChannel screen.
ginsu added a parent revision: D11857: [native] implement UI for TagUnfollowedFarcasterChannel screen.May 5 2024, 5:48 PM
ginsu added a child revision: D11893: [native] improve error handling for TagUnfollowedFarcasterChannel screen.May 6 2024, 12:10 AM
ginsu added inline comments.May 6 2024, 9:43 AM
native/community-settings/tag-farcaster-channel/tag-unfollowed-farcaster-channel.react.js
87 ↗(On Diff #39759)

No because .fetchFarcasterChannelByName is a defined within the NeynarClient class, I believe that just adding neynarClientContext.client into our dep list should be enough to correctly memoize this callback.

Additionally in other places where we call methods defined in the NeynarClient, we only add the client as part of our dep list.

https://github.com/CommE2E/comm/blob/master/lib/components/farcaster-data-handler.react.js#L107
https://github.com/CommE2E/comm/blob/master/native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js#L70

ginsu updated this revision to Diff 39862.May 6 2024, 9:45 AM

rebase before landing

Harbormaster completed remote builds in B28712: Diff 39862.May 6 2024, 10:00 AM
Closed by commit rCOMMd6191262831f: [native] implement onPressTagChannel for TagUnfollowedFarcasterChannel (authored by ginsu). · Explain WhyMay 6 2024, 10:09 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMd6191262831f: [native] implement onPressTagChannel for TagUnfollowedFarcasterChannel.
ginsu mentioned this in D11894: [native] introduce tag channel by name option in action sheet.May 6 2024, 10:55 AM

Revision Contents
Changeset List

PathSize
native/
community-settings/
tag-farcaster-channel/
63 lines

Diff 39864

View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-by-name.react.js

Loading...