Page MenuHomePhabricator

[web] cleanup message search modal
ClosedPublic

Authored by ginsu on Dec 12 2023, 12:44 PM.
Tags
None
Referenced Files
F3508441: D10316.id37145.diff
Fri, Dec 20, 10:10 PM
F3508081: D10316.id34540.diff
Fri, Dec 20, 9:47 PM
F3507003: D10316.diff
Fri, Dec 20, 7:00 PM
Unknown Object (File)
Tue, Dec 17, 11:30 PM
Unknown Object (File)
Nov 16 2024, 7:53 PM
Unknown Object (File)
Oct 31 2024, 9:17 AM
Unknown Object (File)
Oct 31 2024, 9:17 AM
Unknown Object (File)
Oct 31 2024, 9:17 AM
Subscribers

Details

Summary

This diff cleans up the one off styles in the message search modal and replaces it with styles of the redesigned modal.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs and https://linear.app/comm/issue/ENG-5946/fix-up-search-modal

Depends on D10315

Test Plan

Please see screenshots below

Screenshot 2023-12-12 at 3.46.19 PM.png (1×3 px, 886 KB)

Screenshot 2023-12-12 at 3.45.53 PM.png (1×3 px, 820 KB)

Screenshot 2023-12-12 at 3.46.06 PM.png (1×3 px, 892 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu requested review of this revision.Dec 12 2023, 1:19 PM
This revision is now accepted and ready to land.Dec 12 2023, 1:20 PM
This revision was landed with ongoing or failed builds.Feb 15 2024, 12:44 AM
This revision was automatically updated to reflect the committed changes.