Page MenuHomePhabricator
Differential D10236

[web] cleanup community creation modal
ClosedPublic
Actions

Authored by ginsu on Dec 7 2023, 11:55 AM.
Tags
None
Referenced Files
F3506947: D10236.diff
Fri, Dec 20, 6:36 PM
Unknown Object (File)
Sat, Dec 7, 10:59 AM
Unknown Object (File)
Wed, Nov 27, 5:01 AM
Unknown Object (File)
Mon, Nov 25, 8:37 PM
Unknown Object (File)
Mon, Nov 25, 4:25 PM
Unknown Object (File)
Mon, Nov 25, 12:11 AM
Unknown Object (File)
Sun, Nov 24, 7:02 PM
Unknown Object (File)
Oct 31 2024, 10:59 AM
View All 52 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMM7d9860b5542f: [web] cleanup community creation modal
Summary

This diff cleans up the one off styles in the community creation modal and replaces it with styles of the redesigned modal.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D10234

Test Plan

Please see the screenshot below

Screenshot 2023-12-07 at 2.53.26 PM.png (1×3 px, 802 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 7 2023, 11:55 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 7 2023, 11:55 AM
ginsu edited the summary of this revision. (Show Details)Dec 7 2023, 11:57 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10234: [web] introduce subheader prop to modal component.
ginsu attached a referenced file: F916921: Screenshot 2023-12-07 at 2.53.26 PM.png. (Show Details)
ginsu added a child revision: D10237: [web] match the veritcal padding for modals with no button containers.Dec 7 2023, 12:25 PM
Harbormaster completed remote builds in B24868: Diff 34392.Dec 7 2023, 1:27 PM
ginsu requested review of this revision.Dec 7 2023, 1:27 PM
rohan accepted this revision.Dec 7 2023, 1:29 PM
This revision is now accepted and ready to land.Dec 7 2023, 1:29 PM
ginsu updated this revision to Diff 37118.Feb 14 2024, 11:57 PM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 15 2024, 12:10 AM
Closed by commit rCOMM7d9860b5542f: [web] cleanup community creation modal (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM7d9860b5542f: [web] cleanup community creation modal.
Harbormaster completed remote builds in B26854: Diff 37118.Feb 15 2024, 12:13 AM

Revision Contents
Changeset List

PathSize
web/
sidebar/
community-creation/
7 lines
66 lines

Diff 37118

View Options

web/sidebar/community-creation/community-creation-modal.css

Loading...
View Options

web/sidebar/community-creation/community-creation-modal.react.js

Loading...