Page MenuHomePhabricator
Differential D10237

[web] match the veritcal padding for modals with no button containers
ClosedPublic
Actions

Authored by ginsu on Dec 7 2023, 12:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 31, 10:59 AM
Unknown Object (File)
Thu, Oct 31, 10:59 AM
Unknown Object (File)
Thu, Oct 31, 10:59 AM
Unknown Object (File)
Thu, Oct 31, 10:59 AM
Unknown Object (File)
Thu, Oct 31, 10:58 AM
Unknown Object (File)
Oct 3 2024, 6:58 PM
Unknown Object (File)
Sep 20 2024, 4:13 AM
Unknown Object (File)
Sep 20 2024, 4:13 AM
View All 41 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMMb7dcd3f40bdb: [web] match the veritcal padding for modals with no button containers
Summary

Some modals will not have a CTA/button section. If that is the case the padding of the modal will be top: 32px, horizontal: 32px and bottom: 24px. This is based off the rules below:

Screenshot 2023-12-07 at 3.18.13 PM.png (818×818 px, 50 KB)

To make sure the vertical padding for modals is equal to each other when there is no button section, I added an empty div with a height of 8px to act as on offset so that if there is no button section then the modal will just have a 32px uniform padding across all of its sides

Depends on D10236

Test Plan

Please see screenshot of my inspector showing the correct dimensions below for a modal with no CTA/button section

top has padding of 32px:

Screenshot 2023-12-07 at 3.23.00 PM.png (1×3 px, 1 MB)

horizontal sides have padding of 32px + bottom of 24px

Screenshot 2023-12-07 at 3.23.13 PM.png (1×3 px, 1 MB)

bottom offset of 8px (24+8 = 32)

Screenshot 2023-12-07 at 3.23.16 PM.png (1×3 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 7 2023, 12:11 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 7 2023, 12:11 PM
ginsu edited the summary of this revision. (Show Details)Dec 7 2023, 12:25 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10236: [web] cleanup community creation modal.
ginsu attached a referenced file: F916992: Screenshot 2023-12-07 at 3.23.16 PM.png. (Show Details)
ginsu attached a referenced file: F916991: Screenshot 2023-12-07 at 3.23.13 PM.png. (Show Details)
ginsu attached a referenced file: F916988: Screenshot 2023-12-07 at 3.23.00 PM.png. (Show Details)
ginsu attached a referenced file: F916981: Screenshot 2023-12-07 at 3.18.13 PM.png. (Show Details)
Harbormaster completed remote builds in B24869: Diff 34393.Dec 7 2023, 1:51 PM
ginsu requested review of this revision.Dec 7 2023, 1:51 PM
ginsu added a child revision: D10238: [web] cleanup manage invite links empty link modal.Dec 7 2023, 2:20 PM
rohan accepted this revision.Dec 8 2023, 5:05 AM
This revision is now accepted and ready to land.Dec 8 2023, 5:05 AM
ginsu updated this revision to Diff 37119.Feb 14 2024, 11:58 PM
ginsu edited the summary of this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Feb 15 2024, 12:10 AM
Closed by commit rCOMMb7dcd3f40bdb: [web] match the veritcal padding for modals with no button containers (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMb7dcd3f40bdb: [web] match the veritcal padding for modals with no button containers.
Harbormaster completed remote builds in B26855: Diff 37119.Feb 15 2024, 12:14 AM

Revision Contents
Changeset List

PathSize
web/
modals/
4 lines
4 lines

Diff 37119

View Options

web/modals/modal.css

Loading...
View Options

web/modals/modal.react.js

Loading...