Page MenuHomePhabricator

[native] introduce navigational logic for TagUnfollowedFarcasterChannel screen
ClosedPublic

Authored by ginsu on May 1 2024, 10:58 PM.
Tags
None
Referenced Files
F3526298: D11855.diff
Mon, Dec 23, 9:28 PM
Unknown Object (File)
Thu, Dec 19, 9:44 AM
Unknown Object (File)
Thu, Dec 19, 9:44 AM
Unknown Object (File)
Thu, Dec 19, 9:44 AM
Unknown Object (File)
Thu, Dec 19, 9:44 AM
Unknown Object (File)
Thu, Dec 19, 9:44 AM
Unknown Object (File)
Nov 12 2024, 8:43 AM
Unknown Object (File)
Nov 12 2024, 6:07 AM
Subscribers

Details

Summary

One of our user experiences for tagging a farcaster channel to a community is that we want to allow the user to amnually type the farcaster channel name into a text field to tag the channel if they can't find the channel in the dropdown. This diff introduces all the navigational + boilerplate screen we will need to introduce this user experience

Test Plan

flow + confirmed I was able to navigate to the boilerplate screen

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu added a reviewer: ashoat.

This diff has copy changes that need to be reviewed

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-navigator.react.js
55 ↗(On Diff #39737)

Thought it would make sense to have the header title be the same for both screens, but open to changing it. Regardless this copy should be reviewed

Harbormaster returned this revision to the author for changes because remote builds failed.May 1 2024, 11:12 PM
Harbormaster failed remote builds in B28626: Diff 39737!
ginsu requested review of this revision.May 3 2024, 12:22 AM

will make sure ci passes before landing

ashoat added inline comments.
native/community-settings/tag-farcaster-channel/tag-farcaster-channel-navigator.react.js
55 ↗(On Diff #39737)

Makes sense to me

native/community-settings/tag-farcaster-channel/tag-unfollowed-farcaster-channel.react.js
18 ↗(On Diff #39737)

“Unfollowed” seems weird to me since it seems to imply that it was first followed and then unfollowed

I thought about TagNotFollowedFarcasterChannel and TagCustomFarcasterChannel, but I think I like TagFarcasterChannelByName the best. What do you think?

This revision is now accepted and ready to land.May 4 2024, 10:51 AM
native/community-settings/tag-farcaster-channel/tag-unfollowed-farcaster-channel.react.js
18 ↗(On Diff #39737)

TagFarcasterChannelByName makes sense to me

This revision was landed with ongoing or failed builds.May 5 2024, 5:10 PM
This revision was automatically updated to reflect the committed changes.