Page MenuHomePhabricator
Differential D11857

[native] implement UI for TagUnfollowedFarcasterChannel screen
ClosedPublic
Actions

Authored by ginsu on May 1 2024, 11:09 PM.
Tags
None
Referenced Files
F3303100: D11857.diff
Mon, Nov 18, 10:19 AM
Unknown Object (File)
Fri, Nov 15, 6:10 AM
Unknown Object (File)
Sun, Nov 10, 11:41 AM
Unknown Object (File)
Sun, Nov 10, 6:23 AM
Unknown Object (File)
Fri, Nov 8, 10:02 PM
Unknown Object (File)
Fri, Nov 8, 7:18 PM
Unknown Object (File)
Fri, Nov 8, 7:18 PM
Unknown Object (File)
Fri, Nov 8, 7:18 PM
View All 95 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
Commits
rCOMM64a82f0a6643: [native] implement UI for TagUnfollowedFarcasterChannel screen
Summary

This diff introduces the UI for the TagUnfollowedFarcasterChannel screen. For the UI, I tried to use our invite link screens as inspiration for this UI

Depends on D11855

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.May 1 2024, 11:09 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 1 2024, 11:09 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 1 2024, 11:22 PM
Harbormaster failed remote builds in B28628: Diff 39739!
ginsu edited the summary of this revision. (Show Details)May 1 2024, 11:23 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added a reviewer: inka.
ginsu added a parent revision: D11856: [native] refactor registration button to be submit button.
ginsu attached a referenced file: F1691051: Screen Recording 2024-05-02 at 2.22.23 AM.mov. (Show Details)
ginsu updated this revision to Diff 39740.May 1 2024, 11:26 PM

update

ginsu updated this revision to Diff 39741.May 1 2024, 11:32 PM

update

ginsu edited the test plan for this revision. (Show Details)May 1 2024, 11:33 PM
ginsu attached a referenced file: F1691113: Screen Recording 2024-05-02 at 2.31.08 AM.mov. (Show Details)
Harbormaster completed remote builds in B28629: Diff 39740.May 1 2024, 11:43 PM
Harbormaster completed remote builds in B28630: Diff 39741.May 1 2024, 11:47 PM
ginsu requested review of this revision.May 1 2024, 11:47 PM
ginsu added a child revision: D11865: [lib] introduce fetchFarcasterChannelByName to neynar client class.May 3 2024, 12:41 AM
ginsu edited the summary of this revision. (Show Details)May 5 2024, 5:28 PM
ginsu added a parent revision: D11855: [native] introduce navigational logic for TagUnfollowedFarcasterChannel screen.
ginsu removed a parent revision: D11856: [native] refactor registration button to be submit button.
ginsu added a child revision: D11866: [native] implement onPressTagChannel for TagUnfollowedFarcasterChannel.May 5 2024, 5:45 PM
ginsu removed a parent revision: D11855: [native] introduce navigational logic for TagUnfollowedFarcasterChannel screen.
ginsu removed child revisions: D11866: [native] implement onPressTagChannel for TagUnfollowedFarcasterChannel, D11865: [lib] introduce fetchFarcasterChannelByName to neynar client class.
ginsu added a child revision: D11866: [native] implement onPressTagChannel for TagUnfollowedFarcasterChannel.May 5 2024, 5:48 PM
inka accepted this revision.May 6 2024, 1:23 AM
This revision is now accepted and ready to land.May 6 2024, 1:23 AM
ginsu updated this revision to Diff 39854.May 6 2024, 7:24 AM
ginsu added a parent revision: D11855: [native] introduce navigational logic for TagUnfollowedFarcasterChannel screen.

rebase before landing

This revision was landed with ongoing or failed builds.May 6 2024, 7:26 AM
Closed by commit rCOMM64a82f0a6643: [native] implement UI for TagUnfollowedFarcasterChannel screen (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM64a82f0a6643: [native] implement UI for TagUnfollowedFarcasterChannel screen.
Harbormaster completed remote builds in B28706: Diff 39854.May 6 2024, 7:48 AM

Revision Contents
Changeset List

PathSize
native/
community-settings/
tag-farcaster-channel/
80 lines

Diff 39854

View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-by-name.react.js

Loading...