Details

Reviewers

tomek
kamil

Commits

rCOMMda773f537f42: [keyserver/lib] introduce fetch_community_infos endpoint

Summary

This diff introduces the fetch_community_infos endpoint. Similar to the fetch_primary_invite_links we will call this endpoint whenever we open the community drawer on native or when the window becomes active on web

Depends on D11978

Test Plan

Called this endpoint later in my stack and confirmed that I was getting all the correct community infos

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.May 10 2024, 11:11 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 10 2024, 11:11 AM

ginsu edited the summary of this revision. (Show Details)May 10 2024, 11:13 AM

ginsu added reviewers: tomek, kamil.

ginsu added a parent revision: D11978: [keyserver/lib] update deleteFarcasterChannelTag to use communites table.

ginsu added a child revision: D11996: [lib] introduce fetch community infos redux action.May 10 2024, 11:20 AM

Harbormaster returned this revision to the author for changes because remote builds failed.May 10 2024, 11:24 AM

Harbormaster failed remote builds in B28843: Diff 40083!

ginsu mentioned this in D11997: [web] introduce CommunitiesRefresher.May 10 2024, 11:55 AM

rebase

Harbormaster completed remote builds in B28846: Diff 40087.May 10 2024, 2:04 PM

ginsu requested review of this revision.May 10 2024, 2:04 PM

Similar to the fetch_primary_invite_links we will call this endpoint whenever we open the community drawer on native or when the window becomes active on web

Can you explain to your reviewers why we need to do this?

Looking at the project I think it's so that if the user goes the community settings cog and selects the Farcaster channel option, they will be able to see the Farcaster channel. Similar pattern to how we do it for invite links

tomek accepted this revision.May 13 2024, 3:13 AM

tomek added inline comments.

keyserver/src/responders/community-responders.js
14	Wouldn't that make more sense to place this validator next to `FetchCommunityInfosResponse` type definition?
22	Not sure how useful it is to put `withHolder` in the name - this can easily become outdated by a change in `fetchCommunityInfos`.

This revision is now accepted and ready to land.May 13 2024, 3:13 AM

ginsu mentioned this in D12023: [native] call fetchCommunityInfos from the community drawer.May 13 2024, 11:02 PM

ginsu added a subscriber: inka.May 22 2024, 7:30 AM

ginsu added inline comments.

keyserver/src/responders/community-responders.js
14	It looks like we now put all our response validators in a separate location in `lib/types/validators`. Updating this diff to follow this new convention cc @inka