With our new communities table on the keyserver we want to make sure that if a root level thread is created or deleted (a communitiy) that we also create + delete the respective row in the communities table.
Depends on D11903
Details
Details
Created a thread through the community creation user flow + confirmed that a new row was inserted in both the threads and communities tables. Deleted that root thread (communitiy) and confirmed that the correct row was removed in both the threads table and the communities table
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/src/creators/thread-creator.js | ||
|---|---|---|
| 486–489 ↗ | (On Diff #39847) | Can we make this insert happen in the same statement / transaction as the insert to threads table? What would happen if an exception is thrown after we insert into threads but before we insert into communities? |
| keyserver/src/deleters/thread-deleters.js | ||
| 98 ↗ | (On Diff #39847) | Should we also clean this table in cron.js? |
| keyserver/src/deleters/thread-deleters.js | ||
|---|---|---|
| 98 ↗ | (On Diff #39847) | This function is called by deleteInaccessibleThreads below, which is called from cron.js |
| keyserver/src/creators/thread-creator.js | ||
|---|---|---|
| 344 ↗ | (On Diff #39962) | The newline is just my personal preference + I always find it easier to read w/ more space. Happy to remove if others feel strongly otherwise |
| keyserver/src/deleters/thread-deleters.js | ||
| 98 ↗ | (On Diff #39962) | As mentioned by @ashoat earlier:
|