Paths

Table of Contentst

Differential D12309

[lib][web] Extract logic checking add users permissions
ClosedPublic
Actions

Authored by inka on Jun 4 2024, 2:03 AM.

Tags

None

Referenced Files

	F3282540: D12309.id40943.diff
	Sat, Nov 16, 11:13 AM

	Unknown Object (File)
	Tue, Nov 12, 1:04 PM

	Unknown Object (File)
	Mon, Nov 11, 7:35 AM

	Unknown Object (File)
	Mon, Nov 11, 3:31 AM

	Unknown Object (File)
	Mon, Nov 11, 3:14 AM

	Unknown Object (File)
	Mon, Nov 11, 2:16 AM

	Unknown Object (File)
	Sun, Nov 10, 5:05 PM

	Unknown Object (File)
	Oct 15 2024, 8:05 PM

View All 63 Files

Subscribers

Details

Reviewers

Commits

rCOMM0c9ea4bbfdd1: [lib][web] Extract logic checking add users permissions

Summary

This can be reused on native

Test Plan

tested that in members modal the "Add members" button is displayed when it is supposed to and navigates to proper modals

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jun 4 2024, 2:03 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJun 4 2024, 2:03 AM

inka added a parent revision: D12237: [web] Navigate to invite links instead of add members modal.Jun 4 2024, 2:03 AM

inka added a child revision: D12284: [native] Navigate to invite links instead of add members modal.

Harbormaster completed remote builds in B29425: Diff 40926.Jun 4 2024, 2:19 AM

inka requested review of this revision.Jun 4 2024, 2:19 AM

tomek accepted this revision.Jun 4 2024, 2:45 AM

tomek added inline comments.

lib/permissions/add-users-permissions.js
11 ↗	(On Diff #40926)	How about renaming it to `AddUsersPermissions`?
18 ↗	(On Diff #40926)	I'm not sure if this name is good, because this hook returns more than just the permissions, but I don't have any better alternative.

This revision is now accepted and ready to land.Jun 4 2024, 2:45 AM

Rename type

lib/permissions/add-users-permissions.js
18 ↗	(On Diff #40926)	I'm not 100% happy with it either, but I couldn't come up with anything better

Harbormaster completed remote builds in B29436: Diff 40943.Jun 4 2024, 5:05 AM

Closed by commit rCOMM0c9ea4bbfdd1: [lib][web] Extract logic checking add users permissions (authored by inka). · Explain WhyJun 4 2024, 8:31 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM0c9ea4bbfdd1: [lib][web] Extract logic checking add users permissions.

Revision Contents
Changeset List

Path

Size

lib/

permissions/

add-users-permissions.js

41 lines

web/

modals/

threads/

members/

members-modal.react.js

29 lines

Diff 40965

lib/permissions/add-users-permissions.js

Loading...

web/modals/threads/members/members-modal.react.js

Loading...