Page MenuHomePhabricator
Differential D12318

[lib] Don't remove avatar when fetching username
ClosedPublic
Actions

Authored by inka on Jun 5 2024, 6:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 5:21 AM
Unknown Object (File)
Mon, Nov 11, 2:15 AM
Unknown Object (File)
Mon, Nov 11, 1:19 AM
Unknown Object (File)
Mon, Nov 11, 12:27 AM
Unknown Object (File)
Sun, Nov 10, 5:35 PM
Unknown Object (File)
Oct 11 2024, 5:46 AM
Unknown Object (File)
Oct 11 2024, 5:46 AM
Unknown Object (File)
Oct 11 2024, 5:46 AM
View All 62 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM2daa7abf7c5e: [lib] Don't remove avatar when fetching username
Summary

When findUserIdentitiesActionTypes.success is dispatched, an entry for this id may already exist in the store - we may have gotten the user infos from auth keyserver already. We don't want to forget other values of this user info. Namely - avatar and relationshipStatus.

Test Plan

Dispatched findUserIdentitiesActionTypes.success without avatar for an entry that existed in the store and had an avatar. Checked that the updated entry still had the avatar.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jun 5 2024, 6:09 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJun 5 2024, 6:09 AM
inka added a parent revision: D12313: [keyserver][lib] Add ACKNOWLEDGE relationship action.Jun 5 2024, 6:09 AM
inka added a child revision: D12319: [lib] Fetch user avatars for new user ids.Jun 5 2024, 6:16 AM
Harbormaster completed remote builds in B29451: Diff 40981.Jun 5 2024, 6:40 AM
inka requested review of this revision.Jun 5 2024, 6:40 AM
tomek accepted this revision.Jun 5 2024, 6:59 AM
tomek added inline comments.
lib/reducers/user-reducer.js
258–269 ↗(On Diff #40981)

This can be simplified by iterating over action.payload.userInfos instead of creating an object from it

This revision is now accepted and ready to land.Jun 5 2024, 6:59 AM
inka updated this revision to Diff 41038.Jun 6 2024, 4:37 AM

Address review

Harbormaster completed remote builds in B29485: Diff 41038.Jun 6 2024, 4:53 AM
Closed by commit rCOMM2daa7abf7c5e: [lib] Don't remove avatar when fetching username (authored by inka). · Explain WhyJun 25 2024, 1:21 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM2daa7abf7c5e: [lib] Don't remove avatar when fetching username.

Revision Contents
Changeset List

PathSize
lib/
reducers/
32 lines

Diff 41038

View Options

lib/reducers/user-reducer.js

Loading...