[native] introduce RemoveTagButton
ClosedPublic
Actions

Authored by ginsu on May 15 2024, 1:31 AM.

Details

Reviewers

tomek
inka
ashoat

Commits

rCOMMbdba9420dabf: [native] introduce RemoveTagButton

Summary

This diff introduces RemoveTagButton. RemoveTagButton is reponsible for dispatching the delete farcaster channel tag action whenever the user preses the "Remove tag" button

Depends on D12042

Test Plan

Please see the demo video below

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.May 15 2024, 1:31 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 15 2024, 1:31 AM

ginsu edited the summary of this revision. (Show Details)May 15 2024, 1:32 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: tomek, inka.

ginsu added a parent revision: D12042: [native] extend loading logic to include fetching farcaster channel info.

ginsu attached a referenced file: F1766102: Screen Recording 2024-05-15 at 4.27.02 AM.mov. (Show Details)

ginsu edited the test plan for this revision. (Show Details)

ginsu attached a referenced file: F1766107: Screen Recording 2024-05-15 at 4.14.13 AM.mov. (Show Details)

There is some copy in this diff that needs review

native/community-settings/tag-farcaster-channel/remove-tag-button.react.js
72 ↗	(On Diff #40203)	This copy needs to be reviewed

Harbormaster completed remote builds in B28929: Diff 40203.May 15 2024, 1:50 AM

ginsu requested review of this revision.May 15 2024, 1:50 AM

Can we add a confirmation popup? Actions performed by red buttons seem serious, and I think we should double check if the user actually wanted to do them. Like after pressing Disable to disable an invite link

I'm not as worried about deleting a Farcaster tag. When we delete eg. a thread, there is content lost that can't be recovered. Whereas in the case of deleting the Farcaster tag, it's easy to reestablish it. I personally think this is okay without a confirmation modal/alert

This revision is now accepted and ready to land.May 15 2024, 5:02 PM

ginsu mentioned this in D12060: [keyserver/lib/web] include communityStore in the initialReduxState.May 15 2024, 6:18 PM

ginsu added a child revision: D12060: [keyserver/lib/web] include communityStore in the initialReduxState.May 15 2024, 7:11 PM

rebase before landing

Harbormaster completed remote builds in B29544: Diff 41129.Jun 7 2024, 4:38 PM

Closed by commit rCOMMbdba9420dabf: [native] introduce RemoveTagButton (authored by ginsu). · Explain WhyJun 7 2024, 4:41 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMbdba9420dabf: [native] introduce RemoveTagButton.