[keyserver] update fetchCommunityInfos to query by community ids
ClosedPublic
Actions

Authored by ginsu on Jun 12 2024, 11:41 PM.

Details

Reviewers

tomek
kamil

Commits

rCOMM84f1af818b76: [keyserver] update fetchCommunityInfos to query by community ids

Summary

In D11975, there was some feedback to have createOrUpdateFarcasterChannelTag query by a specific community to improve performance. This diff addresses that

Linear task: https://linear.app/comm/issue/ENG-8374/update-createorupdatefarcasterchanneltag-to-query-by-a-specific

Depends on D12062

Test Plan

Logged out return value of fetchCommunityInfos and confirmed that only one community was being returned

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jun 12 2024, 11:41 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 12 2024, 11:41 PM

ginsu edited the summary of this revision. (Show Details)Jun 12 2024, 11:42 PM

ginsu added reviewers: tomek, kamil.

ginsu added a parent revision: D12062: [keyserver/lib] introduce MANAGE_FARCASTER_CHANNEL_TAGS permission.

Harbormaster completed remote builds in B29637: Diff 41260.Jun 13 2024, 12:01 AM

ginsu requested review of this revision.Jun 13 2024, 12:01 AM

tomek accepted this revision.Jun 13 2024, 3:59 AM

tomek added inline comments.

keyserver/src/creators/farcaster-channel-tag-creator.js
39–44 ↗	(On Diff #41260)	`fetchCommunityInfos` returns an array so maybe keep `communityInfos` as a name?
keyserver/src/fetchers/community-fetchers.js
30–34 ↗	(On Diff #41260)	We should check if this array isn't empty to avoid SQL parse error