Page MenuHomePhabricator
Differential D12512

[lib] Discard keyserver usernames for incremental state sync and processUpdatesActionType
ClosedPublic
Actions

Authored by inka on Jun 20 2024, 4:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 24, 5:45 AM
Unknown Object (File)
Thu, Apr 17, 12:33 PM
Unknown Object (File)
Wed, Apr 16, 2:42 PM
Unknown Object (File)
Wed, Apr 16, 10:34 AM
Unknown Object (File)
Tue, Apr 15, 2:26 AM
Unknown Object (File)
Wed, Apr 9, 12:12 PM
Unknown Object (File)
Mar 17 2025, 9:04 PM
Unknown Object (File)
Mar 17 2025, 7:19 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMMd47af6e867ce: [lib] Discard keyserver usernames for incremental state sync and…
Summary

issue: ENG-8365

Test Plan

Tested that if incremental state sync (or process updates) is dispatched, then for new user infos their username is set to null and for old user infos (that the clients already has in their store) username is unchanged.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
reducers/
7 lines

Diff 41567

View Options

lib/reducers/user-reducer.js

Show All 20 Lines
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
function SecondaryDeviceQRCodeScanner(props: Props): React.Node { function SecondaryDeviceQRCodeScanner(props: Props): React.Node {
const [hasPermission, setHasPermission] = React.useState<?boolean>(null); const [hasPermission, setHasPermission] = React.useState<?boolean>(null);
const [scanned, setScanned] = React.useState(false); const [scanned, setScanned] = React.useState(false);
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const navigation = useNavigation(); const navigation = useNavigation();
const tunnelbrokerContext = useTunnelbroker();
const identityContext = React.useContext(IdentityClientContext);
const addDeviceToList = React.useCallback(
async (newDeviceID: string) => {
invariant(identityContext, 'identity context not set');
const { getDeviceListHistoryForUser, updateDeviceList } =
identityContext.identityClient;
invariant(
updateDeviceList,
'updateDeviceList() should be defined for primary device',
);
const authMetadata = await identityContext.getAuthMetadata();
if (!authMetadata?.userID) {
throw new Error('missing auth metadata');
}
const deviceLists = await getDeviceListHistoryForUser(
authMetadata.userID,
);
const lastSignedDeviceList = deviceLists[deviceLists.length - 1];
const deviceList: RawDeviceList = JSON.parse(
lastSignedDeviceList.rawDeviceList,
);
const { devices } = deviceList;
if (!devices.includes(newDeviceID)) {
const newDeviceList: RawDeviceList = {
devices: [...devices, newDeviceID],
timestamp: Date.now(),
};
await updateDeviceList({
rawDeviceList: JSON.stringify(newDeviceList),
});
return true;
} else {
return false;
}
},
[identityContext],
);
React.useEffect(() => { React.useEffect(() => {
void (async () => { void (async () => {
const { status } = await BarCodeScanner.requestPermissionsAsync(); const { status } = await BarCodeScanner.requestPermissionsAsync();
setHasPermission(status === 'granted'); setHasPermission(status === 'granted');
if (status !== 'granted') { if (status !== 'granted') {
Alert.alert( Alert.alert(
'No access to camera', 'No access to camera',
'Please allow Comm to access your camera in order to scan the QR code.', 'Please allow Comm to access your camera in order to scan the QR code.',
[{ text: 'OK' }], [{ text: 'OK' }],
); );
navigation.goBack(); navigation.goBack();
} }
})(); })();
}, [navigation]); }, [navigation]);
const onConnect = React.useCallback((barCodeEvent: BarCodeEvent) => { const onConnect = React.useCallback(
(barCodeEvent: BarCodeEvent) => {
const { data } = barCodeEvent; const { data } = barCodeEvent;
const parsedData = parseDataFromDeepLink(data); const parsedData = parseDataFromDeepLink(data);
const keysMatch = parsedData?.data?.keys; const keysMatch = parsedData?.data?.keys;
if (!parsedData || !keysMatch) { if (!parsedData || !keysMatch) {
Alert.alert( Alert.alert(
'Scan failed', 'Scan failed',
'QR code does not contain a valid pair of keys.', 'QR code does not contain a valid pair of keys.',
[{ text: 'OK' }], [{ text: 'OK' }],
); );
return; return;
} }
const keys = JSON.parse(decodeURIComponent(keysMatch)); const keys = JSON.parse(decodeURIComponent(keysMatch));
const { aes256, ed25519 } = keys;
void (async () => {
try {
invariant(identityContext, 'identity context not set');
const { deviceID: primaryDeviceID, userID } =
await identityContext.getAuthMetadata();
if (!primaryDeviceID || !userID) {
throw new Error('missing auth metadata');
}
await addDeviceToList(ed25519);
const message = createQRAuthTunnelbrokerMessage(aes256, {
type: qrCodeAuthMessageTypes.DEVICE_LIST_UPDATE_SUCCESS,
userID,
primaryDeviceID,
});
await tunnelbrokerContext.sendMessage({
deviceID: ed25519,
payload: JSON.stringify(message),
});
} catch (err) {
console.log('Primary device error:', err);
Alert.alert( Alert.alert(
'Scan successful', 'Adding device failed',
`QR code contains the following keys: ${JSON.stringify(keys)}`, 'Failed to update the device list',
[{ text: 'OK' }], [{ text: 'OK' }],
); );
}, []); navigation.goBack();
}
})();
},
[
tunnelbrokerContext,
addDeviceToList,
identityContext,
navigation,
],
);
const onCancelScan = React.useCallback(() => setScanned(false), []); const onCancelScan = React.useCallback(() => setScanned(false), []);
const handleBarCodeScanned = React.useCallback( const handleBarCodeScanned = React.useCallback(
(barCodeEvent: BarCodeEvent) => { (barCodeEvent: BarCodeEvent) => {
setScanned(true); setScanned(true);
Alert.alert( Alert.alert(
'Connect with this device?', 'Connect with this device?',
▲ Show 20 Lines • Show All 57 Lines • Show Last 20 Lines