Page MenuHomePhabricator

[lib] Discard keyserver usernames for processServerRequestsActionType
ClosedPublic

Authored by inka on Jun 20 2024, 6:58 AM.
Tags
None
Referenced Files
F3529004: D12513.id41690.diff
Tue, Dec 24, 11:52 AM
F3528892: D12513.id41570.diff
Tue, Dec 24, 11:11 AM
F3526255: D12513.diff
Mon, Dec 23, 9:18 PM
Unknown Object (File)
Thu, Dec 19, 4:44 AM
Unknown Object (File)
Thu, Dec 19, 4:44 AM
Unknown Object (File)
Thu, Dec 19, 4:44 AM
Unknown Object (File)
Thu, Dec 19, 4:44 AM
Unknown Object (File)
Mon, Dec 16, 8:20 PM
Subscribers

Details

Summary

issue: ENG-8365

Test Plan

Tested that if processServerRequestsActionType is dispatched with some userInfos in stateChanges and those users are not in the store, the username is set to null

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.Jun 20 2024, 7:15 AM
kamil added inline comments.
lib/reducers/user-reducer.js
545

is this spread needed?

This revision is now accepted and ready to land.Jun 21 2024, 3:28 AM
lib/reducers/user-reducer.js
545

Yes, because convertUserInfosToReplaceUserOps returns a read only array and we want to push to this array in the next lines