Page MenuHomePhabricator

[lib] Discard keyserver usernames for keyserverAuthActionTypes
ClosedPublic

Authored by inka on Jun 20 2024, 4:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 7:20 PM
Unknown Object (File)
Oct 13 2024, 2:11 AM
Unknown Object (File)
Oct 13 2024, 2:11 AM
Unknown Object (File)
Oct 13 2024, 2:11 AM
Unknown Object (File)
Oct 13 2024, 2:11 AM
Unknown Object (File)
Oct 13 2024, 2:11 AM
Unknown Object (File)
Sep 19 2024, 4:50 AM
Unknown Object (File)
Sep 18 2024, 5:49 PM
Subscribers

Details

Summary

issue: ENG-8365
update_relationships throws for viewers own id, because it doesn't make sense to be updating users relationship with themselves. But the user should always have their own user info sent during keyserver auth, so there is no need to fetch it, for any action

Test Plan

Logged in. Checked that usernames for both the current user and other users are null after keyserver auth and get fetched from identity. Checked that the invalid_user error doesn't show up.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.Jun 20 2024, 4:32 AM
lib/handlers/user-infos-handler.react.js
71–73 ↗(On Diff #41550)

I should check again if userIDsWithoutOwnID is not empty

This revision is now accepted and ready to land.Jun 21 2024, 3:24 AM