[lib] Stop processing user infos from secondary keyservers on keyserverAuthActionTypes
ClosedPublic
Actions

Authored by inka on Thu, Jun 6, 6:43 AM.

Details

Reviewers

tomek
kamil

Commits

rCOMM47f523bb4362: [lib] Stop processing user infos from secondary keyservers on…

Summary

issue: ENG-7832

Test Plan

Checked that user infos from auth keyserver are still being persisted on keyserverAuthActionTypes
EDIT: verified that when connecting to a secondary keyserver no errors appear.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Thu, Jun 6, 6:43 AM

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Jun 6, 6:43 AM

inka added a parent revision: D12331: [lib] Stop processing user infos from secondary keyservers on joinThreadActionTypes and newThreadActionTypes.Thu, Jun 6, 6:43 AM

inka added a child revision: D12333: [lib] Stop processing user infos from secondary keyservers on updateUserAvatarActionTypes.Thu, Jun 6, 6:49 AM

Harbormaster completed remote builds in B29487: Diff 41046.Thu, Jun 6, 6:59 AM

inka requested review of this revision.Thu, Jun 6, 6:59 AM

tomek requested changes to this revision.Thu, Jun 6, 9:53 AM

tomek added inline comments.

lib/actions/user-actions.js
622–623 ↗	(On Diff #41046)	I don't think it is guaranteed that there will always be a response from the authoritative keyserver, e.g. when adding a new keyserver. We probably should add a condition here and extend a test plan to verify a non-auth keyserver auth.