Page MenuHomePhabricator
Differential D12513

[lib] Discard keyserver usernames for processServerRequestsActionType
ClosedPublic
Actions

Authored by inka on Thu, Jun 20, 6:58 AM.
Tags
None
Referenced Files
F2164517: D12513.id41690.diff
Mon, Jul 1, 11:47 PM
F2164512: D12513.id41570.diff
Mon, Jul 1, 11:46 PM
Unknown Object (File)
Sun, Jun 30, 1:54 AM
Unknown Object (File)
Thu, Jun 27, 6:00 PM
Unknown Object (File)
Thu, Jun 27, 2:36 PM
Unknown Object (File)
Wed, Jun 26, 10:18 PM
Unknown Object (File)
Wed, Jun 26, 5:31 AM
Unknown Object (File)
Tue, Jun 25, 4:22 PM
View All 11 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMMc251b8874c5e: [lib] Discard keyserver usernames for processServerRequestsActionType
Summary

issue: ENG-8365

Test Plan

Tested that if processServerRequestsActionType is dispatched with some userInfos in stateChanges and those users are not in the store, the username is set to null

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Thu, Jun 20, 6:58 AM
Herald added a subscriber: ashoat. · View Herald TranscriptThu, Jun 20, 6:58 AM
inka added a parent revision: D12512: [lib] Discard keyserver usernames for incremental state sync and processUpdatesActionType.Thu, Jun 20, 6:58 AM
inka added a child revision: D12514: [lib] Discard keyserver usernames for updateUserAvatarActionTypes.Thu, Jun 20, 7:02 AM
Harbormaster completed remote builds in B29835: Diff 41570.Thu, Jun 20, 7:15 AM
inka requested review of this revision.Thu, Jun 20, 7:15 AM
kamil accepted this revision.Fri, Jun 21, 3:28 AM
kamil added inline comments.
lib/reducers/user-reducer.js
545 ↗(On Diff #41570)

is this spread needed?

This revision is now accepted and ready to land.Fri, Jun 21, 3:28 AM
inka added inline comments.Fri, Jun 21, 5:14 AM
lib/reducers/user-reducer.js
545 ↗(On Diff #41570)

Yes, because convertUserInfosToReplaceUserOps returns a read only array and we want to push to this array in the next lines

Closed by commit rCOMMc251b8874c5e: [lib] Discard keyserver usernames for processServerRequestsActionType (authored by inka). · Explain WhyTue, Jun 25, 1:22 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMc251b8874c5e: [lib] Discard keyserver usernames for processServerRequestsActionType.

Revision Contents
Changeset List

PathSize
lib/
reducers/
16 lines

Diff 41690

View Options

lib/reducers/user-reducer.js

Loading...