fix optional chaining

Accepting, but adding @ashoat as blocking to take another look

Looks reasonable, thanks for updating comments.

This is the only way we have to check for Admins right now, but the isAdminRole work that's coming soon will help make these checks a lot more concrete.

Looks good, thanks for including those unit tests

Feel free to re-add if there's anything specific I can be helpful w/

Actually, I have no idea why I gave that feedback in D9476... it's a hook not a functional component so having userID: string as an argument makes more sense than a Props object.

Didn't read carefully, trusting that it's a simple find/replace diff

This seems like a much cleaner and maintainable approach

Resigning since it looks like others have/will take a look, feel free to re-add if there's something specific I can be helpful with

Looks like a reasonable approach

Kind of looked like the height of the highlighted "cell" area changed when friend request was cancelled and the cell with icon took its place. Can you take a look and create an issue before landing if it's a real issue

Looks good. Probably possible to break apart the memoized block to reduce indentation, but not a priority.. good to land as is

Undrafting after IRL discussion w/ @ashoat

Thanks for explaining, I think using awk is reasonable/practical in this limited use case.

rebase and land

rebase and land

rebase and land

If we're allowing ?UserInfo for userInfo prop, shouldn't we eg render "Copy username" conditionally? Or maybe userInfo can be UserInfo?

Skimmed this very briefly, counting on CI/flow/etc

Requesting changes for @ashoat's suggestion

Kind of like I mentioned in the previous diff, it might make sense to create some sort of higher level abstraction similar to ModalProvider on web to handle these BottomSheets. Every time a new bottom sheet is added, will we need to add isNewBottomSheetActive to the conditional?

Looks good, haven't worked with these markdown rules before so adding @rohan to take another look

Thanks for thorough Test Plan

IIRC we were using some CSS selectors from dist that might need to be updated?

This is incorrect

Thanks for addressing

Looks like straightforward find+replace

Very clean

Accepting to unblock, but would prefer if we could avoid passing contentDimensions to FullScreenViewModal

Looks good, let's make sure to fix import before landing

Makes sense, wonder if there's a way to make FullScreenViewModal a little more "children-agnostic" since saveContentCallback and copyContentCallback are kind of media-specific and presumably FullScreenViewModal should be a general purpose component.