Page MenuHomePhorge
Feed Search

May 8 2024

tomek requested review of D11942: [native] Set the DB version after registration.

I planned changes because I thought there was an issue with the current users - they are already registered, so we won't put the version into the DB for them and their backup won't contain it. Actually, there's no such problem, because in order to create a backup, the app should be run, and the migration from the previous diff will be performed and will put the version into the DB.

May 8 2024, 4:08 PM
tomek planned changes to D11942: [native] Set the DB version after registration.
May 8 2024, 4:03 PM
tomek requested review of D11942: [native] Set the DB version after registration.
May 8 2024, 2:16 PM
tomek requested review of D11937: [lib] Update DB version while running a migration.
May 8 2024, 12:30 PM
tomek requested review of D11936: [lib][web][native] Make all the props of StoreOperations optional.
May 8 2024, 11:41 AM
tomek requested review of D11933: [lib] Create a synced metadata key for DB version.
May 8 2024, 11:04 AM
tomek requested review of D11931: [lib] Expose function that processes operations as a part of SQLite API.
May 8 2024, 10:31 AM
tomek added inline comments to D11921: [native] Create a function that processes all the ops.
May 8 2024, 10:19 AM
tomek accepted D11928: [native] Don't call handleReduxMigrationFailure for legacy migrations.
May 8 2024, 10:01 AM
tomek accepted D11903: [keyserver] introduce a table for communities.
May 8 2024, 9:47 AM

May 7 2024

tomek requested review of D11923: [native] Delete unused functions.
May 7 2024, 4:00 PM
tomek requested review of D11922: [native] Use processDBStoreOperations function everywhere.
May 7 2024, 4:00 PM
tomek requested review of D11921: [native] Create a function that processes all the ops.
May 7 2024, 3:15 PM
tomek accepted D11843: [native] add test button to create initial peer list.
May 7 2024, 9:46 AM
tomek accepted D11841: [lib] add action to set users device lists in `AuxUserStore`.
May 7 2024, 9:44 AM
tomek accepted D11858: Specify android notification priority based on its visual action.
May 7 2024, 9:36 AM
tomek requested changes to D11904: [keyserver] modify thread creator + deleter endpoints to update communities table.
May 7 2024, 9:23 AM
tomek requested changes to D11903: [keyserver] introduce a table for communities.
May 7 2024, 9:04 AM
tomek accepted D11916: [native] Consume `useThreadInChatList` in `native/ThreadSettings`.

flow + close reading for now

Sounds risky for a change that changes the flow.

May 7 2024, 8:53 AM
tomek accepted D11910: [native] add reserved registration methods to IdentityServiceContextProvider.

This code is almost entirely a copy-paste from existing endpoints. Can we reduce the duplication?

May 7 2024, 8:47 AM
tomek added a comment to D11871: [lib] Make sure we run ID conversion on unsupportedMessageInfo.

Thanks for making this change!

May 7 2024, 7:47 AM

May 6 2024

tomek requested review of D11902: [native] Create a single base class for all the ops.
May 6 2024, 1:49 PM
tomek accepted D11887: [native] Update unshimClientDB to reflect best practices.
May 6 2024, 8:06 AM
tomek accepted D11885: [web] Introduce unshimClientDB and use it to unshim FARCASTER_MUTUAL messages.
May 6 2024, 8:04 AM
tomek accepted D11871: [lib] Make sure we run ID conversion on unsupportedMessageInfo.

I considered specifying this on the message specs, but there's no way to do that without leading to an import cycle.

It would be great if we could make a corresponding change to RawUnsupportedMessageInfo type (update unsupportedMessageInfo). Maybe we can define this type in another / new file? The problem with the current solution is that we have to remember to update the validator and our types don't protect us against forgetting about this.

May 6 2024, 7:56 AM
tomek accepted D11870: [lib] Stop shimming SIDEBAR_SOURCE when keyserver can't load source message.
May 6 2024, 7:50 AM

Apr 30 2024

tomek closed D11839: [lib] Display a dev prefix for dev invite links.
Apr 30 2024, 6:02 PM
tomek committed rCOMMc9f87ae6c959: [lib] Display a dev prefix for dev invite links.
Apr 30 2024, 6:02 PM
tomek closed D11838: [keyserver] Update uploads table type.
Apr 30 2024, 6:02 PM
tomek committed rCOMMf8fe718bd0aa: [keyserver] Update uploads table type.
Apr 30 2024, 6:02 PM
tomek updated the summary of D11839: [lib] Display a dev prefix for dev invite links.
Apr 30 2024, 9:48 AM
tomek requested review of D11838: [keyserver] Update uploads table type.
Apr 30 2024, 9:36 AM
tomek accepted D11835: [web] add `GetDeviceListsForUsers` in `IdentityServiceClient`.
Apr 30 2024, 8:54 AM
tomek accepted D11834: [native] add `GetDeviceListsForUsers` in `IdentityServiceClient`.
Apr 30 2024, 8:51 AM
tomek accepted D11833: [CommRustModule] add JSI bindings for `GetDeviceListsForUsers` RPC.
Apr 30 2024, 8:48 AM
tomek accepted D11832: [native] implement `GetDeviceListsForUsers` RPC in `native_rust_library`.
Apr 30 2024, 8:40 AM
tomek accepted D11705: [web] log out if CSAT is missing.

however, my local keyserver/mariadb isn't designed to handle switching between false and true.

What do you mean by that? After you go with https://www.notion.so/commapp/Running-two-keyservers-0d373941f2494d949846da02752b91db instructions, you can change the client's flags however you want - at least that's what I'm doing and it works reliably. So my keyserver is always configured in a multi-keyserver manner.

Apr 30 2024, 8:32 AM
tomek closed D11800: [lib] Properly handle hashing in progress.
Apr 30 2024, 8:23 AM
tomek committed rCOMMde3563ffd621: [lib] Properly handle hashing in progress.
Apr 30 2024, 8:23 AM
tomek updated the diff for D11800: [lib] Properly handle hashing in progress.

Update a comment

Apr 30 2024, 7:59 AM
tomek accepted D11837: [lib] Propagate exceptions in keyserverAuth to callers.
Apr 30 2024, 7:35 AM

Apr 29 2024

tomek accepted D11737: [lib] confirm Tunnelbroker messages after processing.
Apr 29 2024, 12:32 PM
tomek accepted D11732: [lib] handle Tunnelbroker messages sequentially.
Apr 29 2024, 12:31 PM
tomek updated the diff for D11800: [lib] Properly handle hashing in progress.

Fix a comment

Apr 29 2024, 10:44 AM
tomek updated the diff for D11800: [lib] Properly handle hashing in progress.

Add a comment

Apr 29 2024, 10:43 AM
tomek closed D11823: [lib][native][web] Show a message when a user is already a part of a community.
Apr 29 2024, 9:21 AM
tomek committed rCOMMc3200b0b69aa: [lib][native][web] Show a message when a user is already a part of a community.
Apr 29 2024, 9:21 AM
tomek closed D11812: [lib][native][web] Display a message when accepting an invite link times out.
Apr 29 2024, 9:21 AM
tomek committed rCOMM40a81f92f599: [lib][native][web] Display a message when accepting an invite link times out.
Apr 29 2024, 9:21 AM
tomek added inline comments to D11800: [lib] Properly handle hashing in progress.
Apr 29 2024, 9:07 AM
tomek added inline comments to D11823: [lib][native][web] Show a message when a user is already a part of a community.
Apr 29 2024, 8:45 AM
tomek updated the diff for D11823: [lib][native][web] Show a message when a user is already a part of a community.

Simplify

Apr 29 2024, 8:45 AM
tomek accepted D11821: [lib] introduce useDeleteFarcasterChannelTag.
Apr 29 2024, 8:31 AM
tomek accepted D11815: [lib] introduce deleteFarcasterChannelTagActionTypes.
Apr 29 2024, 8:28 AM
tomek accepted D11814: [keyserver/lib] introduce delete_farcaster_channel_tag endpoint.
Apr 29 2024, 8:22 AM
tomek accepted D11813: [keyserver] introduce deleteFarcasterChannelTag.
Apr 29 2024, 8:18 AM
tomek accepted D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.

Not going to block it, but the approach doesn't make too much sense to me. Introducing something just to be removed a little later could be avoided by a better sequencing of work.

Apr 29 2024, 7:54 AM
tomek accepted D11739: [web] render `DBOpsHandler` in `TunnelbrokerProvider`.

Are there any actions that need ops processing dispatched before we render TunnelbrokerProvider?

Apr 29 2024, 7:42 AM
tomek accepted D11737: [lib] confirm Tunnelbroker messages after processing.
Apr 29 2024, 7:36 AM
tomek added inline comments to D11732: [lib] handle Tunnelbroker messages sequentially.
Apr 29 2024, 7:30 AM
tomek accepted D11732: [lib] handle Tunnelbroker messages sequentially.
Apr 29 2024, 7:26 AM

Apr 26 2024

tomek requested review of D11823: [lib][native][web] Show a message when a user is already a part of a community.
Apr 26 2024, 8:41 PM
tomek requested review of D11812: [lib][native][web] Display a message when accepting an invite link times out.
Apr 26 2024, 7:46 PM
tomek updated the test plan for D11800: [lib] Properly handle hashing in progress.
Apr 26 2024, 6:46 PM
tomek updated the summary of D11800: [lib] Properly handle hashing in progress.
Apr 26 2024, 2:27 PM
tomek updated the diff for D11800: [lib] Properly handle hashing in progress.

Handle syncing with non-auth keyservers

Apr 26 2024, 2:26 PM
tomek planned changes to D11800: [lib] Properly handle hashing in progress.
Apr 26 2024, 2:11 PM
tomek requested review of D11800: [lib] Properly handle hashing in progress.
Apr 26 2024, 2:08 PM
tomek accepted D11781: Move MissingRegistrationDataHandler to NavigationHandler.
Apr 26 2024, 12:19 PM

Apr 25 2024

tomek accepted D11760: [web] Fix missing relationship buttons.

Is native also affected by this bug?

Apr 25 2024, 2:17 PM
tomek accepted D11759: [lib][native] Stop persisting CSAT.
Apr 25 2024, 2:05 PM
tomek accepted D11776: [lib] move farcaster types to dedicated file.
Apr 25 2024, 2:03 PM
tomek accepted D11775: [lib] introduce useCreateOrUpdateFarcasterChannelTag.
Apr 25 2024, 2:02 PM
tomek accepted D11774: [lib] introduce createOrUpdateFarcasterChannelTagActionTypes.
Apr 25 2024, 2:00 PM
tomek requested changes to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
Apr 25 2024, 1:58 PM
tomek accepted D11772: [keyserver] introduce barebones createOrUpdateFarcasterChannelTag.
Apr 25 2024, 1:54 PM
tomek accepted D11771: [native] Don't refetch nonce from identity after identity auth.
Apr 25 2024, 1:44 PM
tomek closed D11758: [lib] Bump invite link accept timeout.
Apr 25 2024, 1:01 PM
tomek committed rCOMMe959aefe3335: [lib] Bump invite link accept timeout.
Apr 25 2024, 1:01 PM

Apr 24 2024

tomek requested review of D11758: [lib] Bump invite link accept timeout.
Apr 24 2024, 12:56 PM
tomek accepted D11730: [lib/web/native] update `MessageID` in ops handling.
Apr 24 2024, 11:56 AM
tomek accepted D11754: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.

Will test generally at end to make sure things work as expected.

Is this something that will be done later in the stack?

Apr 24 2024, 11:53 AM
tomek requested changes to D11753: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings*`.
Apr 24 2024, 11:51 AM
tomek accepted D11752: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `MembersModal`.
Apr 24 2024, 11:44 AM
tomek accepted D11751: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsMenu`.
Apr 24 2024, 11:44 AM
tomek accepted D11750: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadMenu`.
Apr 24 2024, 11:43 AM
tomek accepted D11749: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.
Apr 24 2024, 11:42 AM
tomek accepted D11748: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.
Apr 24 2024, 11:41 AM
tomek added a comment to D11747: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `EditThreadAvatar`.

I think you should consider having a test plan that actually verifies that this logic is correct.

Apr 24 2024, 11:40 AM
tomek accepted D11747: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `EditThreadAvatar`.
Apr 24 2024, 11:39 AM
tomek accepted D11746: [lib] Introduce `useThreadHasPermission` hook.
Apr 24 2024, 11:38 AM
tomek accepted D11742: [lib] Pull `filterOutDisabledPermissions(permissionsBitmask)` out of `getCurrentUser`.
Apr 24 2024, 11:29 AM
tomek accepted D11741: [lib] Simplify `threadMemberHasPermission()`.
Apr 24 2024, 11:25 AM
tomek accepted D11738: [lib][native] Move reduceServicesAccessToken and setAccessTokenActionType to native.
Apr 24 2024, 10:57 AM

Apr 23 2024

tomek accepted D11736: [lib] Fix error when deleting a keyserver.
Apr 23 2024, 11:24 AM

Apr 22 2024

tomek closed D11708: [keyserver] Use keyserverID instead of userID when creating invite link blobs.
Apr 22 2024, 12:36 PM
tomek committed rCOMM5f36d95f2311: [keyserver] Use keyserverID instead of userID when creating invite link blobs.
Apr 22 2024, 12:36 PM
tomek updated the test plan for D11708: [keyserver] Use keyserverID instead of userID when creating invite link blobs.
Apr 22 2024, 12:01 PM
tomek updated the test plan for D11708: [keyserver] Use keyserverID instead of userID when creating invite link blobs.
Apr 22 2024, 12:00 PM
tomek accepted D11703: [lib][native] Rename uploadBlob to performHTTPMultipartUpload.
Apr 22 2024, 8:35 AM