Page MenuHomePhabricator
Differential D10315

[web] cleanup thread notifications modal
ClosedPublic
Actions

Authored by ginsu on Dec 12 2023, 12:36 PM.
Tags
None
Referenced Files
F3300158: D10315.diff
Sun, Nov 17, 6:24 PM
Unknown Object (File)
Wed, Nov 13, 10:56 AM
Unknown Object (File)
Thu, Oct 31, 10:09 AM
Unknown Object (File)
Thu, Oct 31, 10:09 AM
Unknown Object (File)
Thu, Oct 31, 10:09 AM
Unknown Object (File)
Thu, Oct 31, 10:09 AM
Unknown Object (File)
Thu, Oct 31, 10:09 AM
Unknown Object (File)
Oct 13 2024, 1:57 AM
View All 51 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMM42e079966f0d: [web] cleanup thread notifications modal
Summary

This diff cleans up the one off styles in the thread notification modal and replaces it with styles of the redesigned modal.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D10282

Test Plan

Please see screenshot below

channel:

Screenshot 2023-12-12 at 3.38.55 PM.png (1×3 px, 891 KB)

subchannel:

Screenshot 2023-12-12 at 3.39.05 PM.png (1×3 px, 938 KB)

parent channel is backgrounded:

Screenshot 2023-12-12 at 3.39.46 PM.png (1×3 px, 906 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 12 2023, 12:36 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 12 2023, 12:36 PM
ginsu edited the summary of this revision. (Show Details)Dec 12 2023, 12:41 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added a parent revision: D10282: [web] cleanup thread notifications modal rendering logic.
ginsu attached a referenced file: F930874: Screenshot 2023-12-12 at 3.39.46 PM.png. (Show Details)
ginsu attached a referenced file: F930875: Screenshot 2023-12-12 at 3.39.05 PM.png. (Show Details)
ginsu attached a referenced file: F930877: Screenshot 2023-12-12 at 3.38.55 PM.png. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a child revision: D10316: [web] cleanup message search modal.Dec 12 2023, 12:46 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 12 2023, 1:15 PM
Harbormaster failed remote builds in B24998: Diff 34539!
ginsu requested review of this revision.Dec 12 2023, 1:23 PM

will make sure ci passes before landing

atul accepted this revision.Dec 13 2023, 10:38 PM
This revision is now accepted and ready to land.Dec 13 2023, 10:38 PM
ginsu updated this revision to Diff 37144.Feb 15 2024, 12:26 AM

rebase before landing

Harbormaster completed remote builds in B26868: Diff 37144.Feb 15 2024, 12:43 AM
Closed by commit rCOMM42e079966f0d: [web] cleanup thread notifications modal (authored by ginsu). · Explain WhyFeb 15 2024, 12:44 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM42e079966f0d: [web] cleanup thread notifications modal.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
notifications/
1 line
45 lines

Diff 37159

View Options

web/modals/threads/notifications/notifications-modal.css

Loading...
View Options

web/modals/threads/notifications/notifications-modal.react.js

Loading...