Page MenuHomePhabricator
Differential D12023

[native] call fetchCommunityInfos from the community drawer
ClosedPublic
Actions

Authored by ginsu on May 13 2024, 11:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 1:59 AM
Unknown Object (File)
Wed, Oct 23, 2:55 AM
Unknown Object (File)
Sat, Oct 19, 6:24 PM
Unknown Object (File)
Oct 14 2024, 7:00 PM
Unknown Object (File)
Oct 14 2024, 6:40 PM
Unknown Object (File)
Oct 13 2024, 5:05 AM
Unknown Object (File)
Oct 13 2024, 5:05 AM
Unknown Object (File)
Oct 13 2024, 5:05 AM
View All 74 Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
kamil
Commits
rCOMM2192cb520ece: [native] call fetchCommunityInfos from the community drawer
Summary

As mentioned in D11995 we want to call the fetch_community_infos endpoint whenever the user opens the community drawer. This is the logic that handles that

Depends on D11997

Test Plan

Confirmed that we were calling fetch_community_infos whenever we open the community drawer

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.May 13 2024, 11:02 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 13 2024, 11:02 PM
ginsu edited the summary of this revision. (Show Details)May 13 2024, 11:03 PM
ginsu added a parent revision: D11997: [web] introduce CommunitiesRefresher.
ginsu edited the summary of this revision. (Show Details)May 13 2024, 11:07 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: tomek, kamil.
Harbormaster completed remote builds in B28886: Diff 40145.May 13 2024, 11:19 PM
ginsu requested review of this revision.May 13 2024, 11:19 PM
ginsu added a child revision: D12024: [native] introduce TagChannelButton.May 13 2024, 11:29 PM
tomek accepted this revision.May 14 2024, 3:22 AM
tomek added inline comments.
native/navigation/community-drawer-content.react.js
62–76

There's no need to await promises and then ignore the result. We can ignore the results immediately.

This revision is now accepted and ready to land.May 14 2024, 3:22 AM
ginsu updated this revision to Diff 40548.May 22 2024, 7:34 AM

address comments

Harbormaster completed remote builds in B29177: Diff 40548.May 22 2024, 8:01 AM
ginsu updated this revision to Diff 41007.Jun 5 2024, 11:05 PM

rebase before landing

Harbormaster completed remote builds in B29472: Diff 41007.Jun 5 2024, 11:25 PM
Closed by commit rCOMM2192cb520ece: [native] call fetchCommunityInfos from the community drawer (authored by ginsu). · Explain WhyJun 5 2024, 11:57 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM2192cb520ece: [native] call fetchCommunityInfos from the community drawer.

Revision Contents
Changeset List

PathSize
native/
navigation/
26 lines

Diff 40145

View Options

native/navigation/community-drawer-content.react.js

Loading...