Page MenuHomePhabricator
Differential D12027

[lib] update community reducer to handle new community action types
ClosedPublic
Actions

Authored by ginsu on May 13 2024, 11:51 PM.
Tags
None
Referenced Files
F3374028: D12027.diff
Tue, Nov 26, 1:21 PM
Unknown Object (File)
Sat, Nov 23, 1:18 AM
Unknown Object (File)
Fri, Nov 15, 6:10 AM
Unknown Object (File)
Thu, Nov 14, 3:54 PM
Unknown Object (File)
Thu, Nov 14, 3:53 PM
Unknown Object (File)
Thu, Nov 7, 8:56 AM
Unknown Object (File)
Thu, Nov 7, 12:03 AM
Unknown Object (File)
Sat, Nov 2, 1:21 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
kamil
Commits
rCOMM974126afaf9e: [lib] update community reducer to handle new community action types
Summary

Earlier in this stack we introduced three new community actions: fetchCommunityInfosActionTypes, createOrUpdateFarcasterChannelTagActionTypes and deleteFarcasterChannelTagActionTypes.

As part of introducing redux actions, we also need to introduce the redux reducer logic for each action type.

Depends on D12025

Test Plan

Tested each action individually, and confirmed using the redux dev tools that I was getting the correct payload + updated state

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.May 13 2024, 11:51 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 13 2024, 11:51 PM
ginsu edited the summary of this revision. (Show Details)May 13 2024, 11:53 PM
ginsu added reviewers: tomek, kamil.
ginsu added a parent revision: D12025: [native] display loading spinner in TagChannelButton during loading state.
ginsu added a child revision: D12026: [lib] introduce fetchFarcasterChannelInfo to neynar client class.
Harbormaster completed remote builds in B28891: Diff 40150.May 14 2024, 12:07 AM
ginsu requested review of this revision.May 14 2024, 12:07 AM
tomek accepted this revision.May 14 2024, 3:36 AM
tomek added inline comments.
lib/reducers/community-reducer.js
32–35 ↗(On Diff #40150)

We can avoid repeated spreading

This revision is now accepted and ready to land.May 14 2024, 3:36 AM
ginsu added a child revision: D12041: [native] display existing farcaster channel tag in TagFarcasterChannel screen.May 15 2024, 1:15 AM
ginsu removed a child revision: D12041: [native] display existing farcaster channel tag in TagFarcasterChannel screen.May 15 2024, 1:18 AM
ginsu updated this revision to Diff 40549.May 22 2024, 7:36 AM

address comments

Harbormaster completed remote builds in B29178: Diff 40549.May 22 2024, 8:05 AM
ginsu updated this revision to Diff 41010.Jun 5 2024, 11:19 PM

rebase before landing

Harbormaster completed remote builds in B29475: Diff 41010.Jun 5 2024, 11:42 PM
Closed by commit rCOMM974126afaf9e: [lib] update community reducer to handle new community action types (authored by ginsu). · Explain WhyJun 5 2024, 11:58 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM974126afaf9e: [lib] update community reducer to handle new community action types.

Revision Contents
Changeset List

PathSize
lib/
reducers/
64 lines

Diff 41010

View Options

lib/reducers/community-reducer.js

Loading...