Page MenuHomePhabricator

[keyserver/lib] update farcaster channel tag blob payload to include keyserver id
ClosedPublic

Authored by ginsu on May 15 2024, 7:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 1:59 AM
Unknown Object (File)
Thu, Oct 24, 9:54 AM
Unknown Object (File)
Thu, Oct 24, 6:42 AM
Unknown Object (File)
Oct 13 2024, 5:22 AM
Unknown Object (File)
Oct 13 2024, 5:22 AM
Unknown Object (File)
Oct 13 2024, 5:22 AM
Unknown Object (File)
Oct 13 2024, 5:22 AM
Unknown Object (File)
Oct 13 2024, 5:21 AM
Subscribers

Details

Summary

While working on the auto-join communities feature, I discovered an issue where the commCommunityID in the downloaded blob payload did not have the keyserverID:

farcasterChannelTagBlobs [
	{
		"commCommunityID": "83887",
		"farcasterChannelID": "comm"
	},
	{
		"commCommunityID": "145350",
		"farcasterChannelID": "memes"
	},
	{
		"commCommunityID": "83887",
		"farcasterChannelID": "farcaster"
	},
	{
		"commCommunityID": "83885",
		"farcasterChannelID": "founders"
	}
]

However, the the thread ids in the threadInfos look like this: 256|83843, where the keyserver id is appended to the front of the thread id and the two ids are separated by a pipe character. This diff updates the value of commCommunityID to follow this convention

Test Plan

flow + confirmed that the creating + updating + deleting farcaster tag all still worked

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu added reviewers: tomek, kamil.
ginsu edited the summary of this revision. (Show Details)
ginsu requested review of this revision.May 15 2024, 8:04 PM
ashoat requested changes to this revision.May 16 2024, 10:23 AM

Doesn't this break the 1-to-1 mapping? It seems like you're making it possible for a Farcaster channel to be tagged to multiple communities (one on each keyserver)

I'm not sure I understand the problem statement. It would help to be more precise/clear about what the product impact is of the issue you've identified.

This revision now requires changes to proceed.May 16 2024, 10:23 AM
ginsu retitled this revision from [keyserver/lib] update farcaster channel tag blob hash to include keyserver id to [keyserver/lib] update farcaster channel tag blob payload to include keyserver id.Jun 13 2024, 1:38 AM
ginsu edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jun 13 2024, 8:18 AM