Page MenuHomePhabricator
Differential D12331

[lib] Stop processing user infos from secondary keyservers on joinThreadActionTypes and newThreadActionTypes
ClosedPublic
Actions

Authored by inka on Jun 6 2024, 4:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 7:32 AM
Unknown Object (File)
Wed, Apr 16, 1:44 AM
Unknown Object (File)
Wed, Apr 16, 1:29 AM
Unknown Object (File)
Mon, Apr 14, 11:33 PM
Unknown Object (File)
Wed, Apr 9, 11:39 AM
Unknown Object (File)
Mon, Apr 7, 3:24 AM
Unknown Object (File)
Fri, Mar 28, 3:20 AM
Unknown Object (File)
Mar 17 2025, 7:24 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMMc4bb2947a732: [lib] Stop processing user infos from secondary keyservers on…
Summary

issue: ENG-7832

Test Plan

Tested that for both actions dispatched for the auth keyserver, the if(keyserverID !== authoritativeKeyserverID()) returns false and the new user infos are added

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
actions/
1 line
reducers/
15 lines
types/
1 line

Diff 41684

View Options

lib/actions/thread-actions.js

// @flow // @flow
import { useRoute } from '@react-navigation/core';
import * as React from 'react'; import * as React from 'react';
import { Animated, Text, View } from 'react-native';
import { TabBarItem } from 'react-native-tab-view';
import { useCurrentUserFID } from 'lib/utils/farcaster-utils.js'; import { useCurrentUserFID } from 'lib/utils/farcaster-utils.js';
import { createChatTabBarButton } from './chat-tab-bar-button.react.js';
import { backgroundChatThreadListOptions } from '../chat/chat-options.js'; import { backgroundChatThreadListOptions } from '../chat/chat-options.js';
import { useSelector } from '../redux/redux-utils.js';
import { useStyles } from '../themes/colors.js';
import { LightTheme, DarkTheme } from '../themes/navigation.js';
import { import {
type NUXTipsOverlayProps, type NUXTipsOverlayProps,
createNUXTipsOverlay, createNUXTipsOverlay,
} from '../tooltip/nux-tips-overlay.react.js'; } from '../tooltip/nux-tips-overlay.react.js';
const mutedTabTipTextBase = const mutedTabTipTextBase =
'When you mute a chat, it automatically gets moved to this tab.'; 'When you mute a chat, it automatically gets moved to this tab.';
const mutedTabTipTextIfFID = const mutedTabTipTextIfFID =
' When Comm automatically adds you to a community associated with a ' + ' When Comm automatically adds you to a community associated with a ' +
'Farcaster channel you follow, we mute them by default.'; 'Farcaster channel you follow, we mute them by default.';
const dummyCallback = () => {};
const dummyNavigationState = { index: 0, routes: [] };
const unboundStyles = {
button: {
flexDirection: 'row',
backgroundColor: 'tabBarBackground',
},
label: {
textAlign: 'center',
textTransform: 'uppercase',
fontSize: 13,
margin: 4,
backgroundColor: 'transparent',
},
icon: {
height: 24,
width: 24,
},
};
function WrappedChatTabBarButton(): React.Node {
const { title, tabBarIcon: Icon } = backgroundChatThreadListOptions;
const position = React.useRef(() => new Animated.Value(0));
const route = useRoute();
const activeTheme = useSelector(state => state.globalThemeInfo.activeTheme);
const color = React.useMemo(
() =>
activeTheme === 'dark' ? DarkTheme.colors.text : LightTheme.colors.text,
[activeTheme],
);
const styles = useStyles(unboundStyles);
const renderLabel = React.useCallback(
({ color: labelColor }: { color: string, ... }) => {
return <Text style={[styles.label, { color: labelColor }]}>{title}</Text>;
},
[styles.label, title],
);
const renderIcon = React.useCallback(
({ color: iconColor }: { color: string, ... }) => {
return (
<View style={styles.icon}>
<Icon color={iconColor} />
</View>
);
},
[styles.icon],
);
const renderLabelText = React.useCallback(() => title, [title]);
return (
<TabBarItem
position={position.current}
route={route}
navigationState={dummyNavigationState}
onPress={dummyCallback}
onLongPress={dummyCallback}
style={styles.button}
getLabelText={renderLabelText}
getAccessible={dummyCallback}
getAccessibilityLabel={dummyCallback}
renderIcon={renderIcon}
getTestID={dummyCallback}
activeColor={color}
renderLabel={renderLabel}
/>
);
}
function MutedTabTip(props: NUXTipsOverlayProps<'MutedTabTip'>): React.Node { function MutedTabTip(props: NUXTipsOverlayProps<'MutedTabTip'>): React.Node {
const fid = useCurrentUserFID(); const fid = useCurrentUserFID();
const text = React.useMemo(() => { const text = React.useMemo(() => {
if (!fid) { if (!fid) {
return mutedTabTipTextBase; return mutedTabTipTextBase;
} }
return mutedTabTipTextBase + mutedTabTipTextIfFID; return mutedTabTipTextBase + mutedTabTipTextIfFID;
}, [fid]); }, [fid]);
const MutedTabTipComponent: React.ComponentType< const MutedTabTipComponent: React.ComponentType<
NUXTipsOverlayProps<'MutedTabTip'>, NUXTipsOverlayProps<'MutedTabTip'>,
> = createNUXTipsOverlay(WrappedChatTabBarButton, text); > = createNUXTipsOverlay(
createChatTabBarButton<'MutedTabTip'>(backgroundChatThreadListOptions),
text,
);
return <MutedTabTipComponent {...props} />; return <MutedTabTipComponent {...props} />;
} }
export default MutedTabTip; export default MutedTabTip;
View Options

lib/reducers/user-reducer.js

// @flow // @flow
import { useRoute } from '@react-navigation/core';
import * as React from 'react'; import * as React from 'react';
import { Animated, Text, View } from 'react-native';
import { TabBarItem } from 'react-native-tab-view';
import { useCurrentUserFID } from 'lib/utils/farcaster-utils.js'; import { useCurrentUserFID } from 'lib/utils/farcaster-utils.js';
import { createChatTabBarButton } from './chat-tab-bar-button.react.js';
import { backgroundChatThreadListOptions } from '../chat/chat-options.js'; import { backgroundChatThreadListOptions } from '../chat/chat-options.js';
import { useSelector } from '../redux/redux-utils.js';
import { useStyles } from '../themes/colors.js';
import { LightTheme, DarkTheme } from '../themes/navigation.js';
import { import {
type NUXTipsOverlayProps, type NUXTipsOverlayProps,
createNUXTipsOverlay, createNUXTipsOverlay,
} from '../tooltip/nux-tips-overlay.react.js'; } from '../tooltip/nux-tips-overlay.react.js';
const mutedTabTipTextBase = const mutedTabTipTextBase =
'When you mute a chat, it automatically gets moved to this tab.'; 'When you mute a chat, it automatically gets moved to this tab.';
const mutedTabTipTextIfFID = const mutedTabTipTextIfFID =
' When Comm automatically adds you to a community associated with a ' + ' When Comm automatically adds you to a community associated with a ' +
'Farcaster channel you follow, we mute them by default.'; 'Farcaster channel you follow, we mute them by default.';
const dummyCallback = () => {};
const dummyNavigationState = { index: 0, routes: [] };
const unboundStyles = {
button: {
flexDirection: 'row',
backgroundColor: 'tabBarBackground',
},
label: {
textAlign: 'center',
textTransform: 'uppercase',
fontSize: 13,
margin: 4,
backgroundColor: 'transparent',
},
icon: {
height: 24,
width: 24,
},
};
function WrappedChatTabBarButton(): React.Node {
const { title, tabBarIcon: Icon } = backgroundChatThreadListOptions;
const position = React.useRef(() => new Animated.Value(0));
const route = useRoute();
const activeTheme = useSelector(state => state.globalThemeInfo.activeTheme);
const color = React.useMemo(
() =>
activeTheme === 'dark' ? DarkTheme.colors.text : LightTheme.colors.text,
[activeTheme],
);
const styles = useStyles(unboundStyles);
const renderLabel = React.useCallback(
({ color: labelColor }: { color: string, ... }) => {
return <Text style={[styles.label, { color: labelColor }]}>{title}</Text>;
},
[styles.label, title],
);
const renderIcon = React.useCallback(
({ color: iconColor }: { color: string, ... }) => {
return (
<View style={styles.icon}>
<Icon color={iconColor} />
</View>
);
},
[styles.icon],
);
const renderLabelText = React.useCallback(() => title, [title]);
return (
<TabBarItem
position={position.current}
route={route}
navigationState={dummyNavigationState}
onPress={dummyCallback}
onLongPress={dummyCallback}
style={styles.button}
getLabelText={renderLabelText}
getAccessible={dummyCallback}
getAccessibilityLabel={dummyCallback}
renderIcon={renderIcon}
getTestID={dummyCallback}
activeColor={color}
renderLabel={renderLabel}
/>
);
}
function MutedTabTip(props: NUXTipsOverlayProps<'MutedTabTip'>): React.Node { function MutedTabTip(props: NUXTipsOverlayProps<'MutedTabTip'>): React.Node {
const fid = useCurrentUserFID(); const fid = useCurrentUserFID();
const text = React.useMemo(() => { const text = React.useMemo(() => {
if (!fid) { if (!fid) {
return mutedTabTipTextBase; return mutedTabTipTextBase;
} }
return mutedTabTipTextBase + mutedTabTipTextIfFID; return mutedTabTipTextBase + mutedTabTipTextIfFID;
}, [fid]); }, [fid]);
const MutedTabTipComponent: React.ComponentType< const MutedTabTipComponent: React.ComponentType<
NUXTipsOverlayProps<'MutedTabTip'>, NUXTipsOverlayProps<'MutedTabTip'>,
> = createNUXTipsOverlay(WrappedChatTabBarButton, text); > = createNUXTipsOverlay(
createChatTabBarButton<'MutedTabTip'>(backgroundChatThreadListOptions),
text,
);
return <MutedTabTipComponent {...props} />; return <MutedTabTipComponent {...props} />;
} }
export default MutedTabTip; export default MutedTabTip;
View Options

lib/types/thread-types.js

// @flow // @flow
import { useRoute } from '@react-navigation/core';
import * as React from 'react'; import * as React from 'react';
import { Animated, Text, View } from 'react-native';
import { TabBarItem } from 'react-native-tab-view';
import { useCurrentUserFID } from 'lib/utils/farcaster-utils.js'; import { useCurrentUserFID } from 'lib/utils/farcaster-utils.js';
import { createChatTabBarButton } from './chat-tab-bar-button.react.js';
import { backgroundChatThreadListOptions } from '../chat/chat-options.js'; import { backgroundChatThreadListOptions } from '../chat/chat-options.js';
import { useSelector } from '../redux/redux-utils.js';
import { useStyles } from '../themes/colors.js';
import { LightTheme, DarkTheme } from '../themes/navigation.js';
import { import {
type NUXTipsOverlayProps, type NUXTipsOverlayProps,
createNUXTipsOverlay, createNUXTipsOverlay,
} from '../tooltip/nux-tips-overlay.react.js'; } from '../tooltip/nux-tips-overlay.react.js';
const mutedTabTipTextBase = const mutedTabTipTextBase =
'When you mute a chat, it automatically gets moved to this tab.'; 'When you mute a chat, it automatically gets moved to this tab.';
const mutedTabTipTextIfFID = const mutedTabTipTextIfFID =
' When Comm automatically adds you to a community associated with a ' + ' When Comm automatically adds you to a community associated with a ' +
'Farcaster channel you follow, we mute them by default.'; 'Farcaster channel you follow, we mute them by default.';
const dummyCallback = () => {};
const dummyNavigationState = { index: 0, routes: [] };
const unboundStyles = {
button: {
flexDirection: 'row',
backgroundColor: 'tabBarBackground',
},
label: {
textAlign: 'center',
textTransform: 'uppercase',
fontSize: 13,
margin: 4,
backgroundColor: 'transparent',
},
icon: {
height: 24,
width: 24,
},
};
function WrappedChatTabBarButton(): React.Node {
const { title, tabBarIcon: Icon } = backgroundChatThreadListOptions;
const position = React.useRef(() => new Animated.Value(0));
const route = useRoute();
const activeTheme = useSelector(state => state.globalThemeInfo.activeTheme);
const color = React.useMemo(
() =>
activeTheme === 'dark' ? DarkTheme.colors.text : LightTheme.colors.text,
[activeTheme],
);
const styles = useStyles(unboundStyles);
const renderLabel = React.useCallback(
({ color: labelColor }: { color: string, ... }) => {
return <Text style={[styles.label, { color: labelColor }]}>{title}</Text>;
},
[styles.label, title],
);
const renderIcon = React.useCallback(
({ color: iconColor }: { color: string, ... }) => {
return (
<View style={styles.icon}>
<Icon color={iconColor} />
</View>
);
},
[styles.icon],
);
const renderLabelText = React.useCallback(() => title, [title]);
return (
<TabBarItem
position={position.current}
route={route}
navigationState={dummyNavigationState}
onPress={dummyCallback}
onLongPress={dummyCallback}
style={styles.button}
getLabelText={renderLabelText}
getAccessible={dummyCallback}
getAccessibilityLabel={dummyCallback}
renderIcon={renderIcon}
getTestID={dummyCallback}
activeColor={color}
renderLabel={renderLabel}
/>
);
}
function MutedTabTip(props: NUXTipsOverlayProps<'MutedTabTip'>): React.Node { function MutedTabTip(props: NUXTipsOverlayProps<'MutedTabTip'>): React.Node {
const fid = useCurrentUserFID(); const fid = useCurrentUserFID();
const text = React.useMemo(() => { const text = React.useMemo(() => {
if (!fid) { if (!fid) {
return mutedTabTipTextBase; return mutedTabTipTextBase;
} }
return mutedTabTipTextBase + mutedTabTipTextIfFID; return mutedTabTipTextBase + mutedTabTipTextIfFID;
}, [fid]); }, [fid]);
const MutedTabTipComponent: React.ComponentType< const MutedTabTipComponent: React.ComponentType<
NUXTipsOverlayProps<'MutedTabTip'>, NUXTipsOverlayProps<'MutedTabTip'>,
> = createNUXTipsOverlay(WrappedChatTabBarButton, text); > = createNUXTipsOverlay(
createChatTabBarButton<'MutedTabTip'>(backgroundChatThreadListOptions),
text,
);
return <MutedTabTipComponent {...props} />; return <MutedTabTipComponent {...props} />;
} }
export default MutedTabTip; export default MutedTabTip;